From nobody Wed Nov 24 15:49:50 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3306A18ADA5A; Wed, 24 Nov 2021 15:49:53 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HzlnX6Hygz3MFM; Wed, 24 Nov 2021 15:49:52 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from aniel.nours.eu (nours.eu [176.31.115.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id A09282FDF5; Wed, 24 Nov 2021 15:49:52 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id D2DE14EB1F; Wed, 24 Nov 2021 16:49:50 +0100 (CET) Date: Wed, 24 Nov 2021 16:49:50 +0100 From: Baptiste Daroussin To: "Bjoern A. Zeeb" Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: a46722b58056 - main - ncurses: register formw as usable lib for LIBADD Message-ID: <20211124154950.iu62azibagbgosjh@aniel.nours.eu> References: <202111241003.1AOA3pxZ008905@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1637768992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AO5pBizeLHX5amJUEBwIXkX1tXN6cC8fEaxOD+iy9j0=; b=bAgXAo9yYjtif+ScvS5/1rIlwHZU4kj4kJm+Wg8mbxPEhh1Gdt2fp+6O+WcDwRWB2BKoip cfjF3JqJ8OSP18JRA4L0gAuvz6wlk0F9hfPfD99GjI+duxolDNwvuUwGMsKQIzMKbDyMZo Ge67k2s/08sn/yRB5uR6nfeOJ/hrP1S/bQDb1/Z/IL0NRb+e/NVptvPDAQ2WFTy1lcAYHI 2cqUSSBCtBg15UahZgE/AMKEpvTV6APZ3W27mTpeIgCKxKUU9BoC99RSzJtMG/Mex59sn0 /oS2mmE4dMS9UCOTjy25attci8dSdEje+baX8/1JXgVdz9vJchXUIOtk+c2idQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1637768992; a=rsa-sha256; cv=none; b=Ba/3l30/YPJfuOjr4wVqIRV6D1xjg7vkJmVgJ8g1C/K+CNmRH5CnUIPHNldvQ7kZp+JqUv l/XrzkZcMufQV6BLeYmn+xi9XFsyYj4hJD8nurq/vDDLo0EzH9RsuO9G6TZzEV8lNJjD5V fMInPbpRL/snEH732sObo7vbG0H+JUMGZdjBq2/Q6PLi4y40CYFv+UnKJY2BQiKDSd06t+ vl8cikDqAquOv+072xZoWkFCd7Vk5dAhwrs7/MXIfM1BDQLFYYteR2qvMdOKimgCELIqUN NCAyNQWC+XDDqmnLf91okkNzRyQDwU41tDSz+/rUGku/bWme+RZz53JGPC+tZw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Wed, Nov 24, 2021 at 03:34:02PM +0000, Bjoern A. Zeeb wrote: > On Wed, 24 Nov 2021, Bjoern A. Zeeb wrote: > > > On Wed, 24 Nov 2021, Bjoern A. Zeeb wrote: > > > > > On Wed, 24 Nov 2021, Baptiste Daroussin wrote: > > > > > > > The branch main has been updated by bapt: > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=a46722b580567799b484b5a81728eaf380777e04 > > > > > > > > commit a46722b580567799b484b5a81728eaf380777e04 > > > > Author: Baptiste Daroussin > > > > AuthorDate: 2021-11-24 09:20:10 +0000 > > > > Commit: Baptiste Daroussin > > > > CommitDate: 2021-11-24 10:02:22 +0000 > > > > > > > > ncurses: register formw as usable lib for LIBADD > > > > > > is LIBFORM to be LIBFORMW or do we need another new entry? > > > > > > 1393 make[7]: "share/mk/bsd.libnames.mk" line 190: > > > lib/ncurses/form: Missing value for LIBFORMW in bsd.libnames.mk. > > > Likely should be: LIBFORMW?= ${LIBDESTDIR}${LIBDIR_BASE}/libformw.a > > > > > > and later still: > > > > 6315 ld: error: unable to find library -lformw > > 6316 cc: error: linker command failed with exit code 1 (use -v to see > > invocation) > > 6317 --- libprivatebsddialog.so.0.full --- > > 6318 *** [libprivatebsddialog.so.0.full] Error code 1 > > > > > > @ 848ee2a3a8b47c9905fc51fefcf60eb371edbb98 > > I've locally fixed this (it seems) like this for now: > > diff --git a/Makefile.inc1 b/Makefile.inc1 > index d8f50cf77d4b..620d9f239b6e 100644 > --- a/Makefile.inc1 > +++ b/Makefile.inc1 > @@ -2943,6 +2943,7 @@ _prebuild_libs= ${_kerberos5_lib_libasn1} \ > ${_lib_casper} \ > lib/ncurses/tinfo \ > lib/ncurses/ncurses \ > + lib/ncurses/form \ > lib/libopie lib/libpam/libpam lib/libthr \ > ${_lib_libradius} lib/libsbuf lib/libtacplus \ > lib/libgeom \ > @@ -2982,6 +2983,7 @@ _lib_libradius= lib/libradius > .endif > > lib/ncurses/ncurses__L: lib/ncurses/tinfo__L > +lib/ncurses/form__L: lib/ncurses/ncurses__L > > .if ${MK_OFED} != "no" > _prebuild_libs+= \ > I think it should be fixed, I don't think it is necessary to add it to the prebuild_libs Best regards, Bapt