From nobody Wed Nov 10 06:40:05 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C5A16184BD8B; Wed, 10 Nov 2021 06:40:12 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HpwFm3F8Yz4hTc; Wed, 10 Nov 2021 06:40:12 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.16.1/8.16.1) with ESMTPS id 1AA6e5vU086921 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 9 Nov 2021 22:40:05 -0800 (PST) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.16.1/8.16.1/Submit) id 1AA6e504086920; Tue, 9 Nov 2021 22:40:05 -0800 (PST) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Tue, 9 Nov 2021 22:40:05 -0800 From: Gleb Smirnoff To: Mike Karels Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 20d59403961d - main - kernel: deprecate Internet Class A/B/C Message-ID: References: <202111091536.1A9Fa1NS099849@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202111091536.1A9Fa1NS099849@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4HpwFm3F8Yz4hTc X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N Mike, On Tue, Nov 09, 2021 at 03:36:01PM +0000, Mike Karels wrote: M> commit 20d59403961d531467cfab22163f49c131cc8b55 M> Author: Mike Karels M> AuthorDate: 2021-10-27 03:01:09 +0000 M> Commit: Mike Karels M> CommitDate: 2021-11-09 15:32:38 +0000 M> M> kernel: deprecate Internet Class A/B/C M> M> Hide historical Class A/B/C macros unless IN_HISTORICAL_NETS is defined; M> define it for user level. Define IN_MULTICAST separately from IN_CLASSD, M> and use it in pf instead of IN_CLASSD. Stop using class for setting M> default masks when not specified; instead, define new default mask M> (24 bits). Warn when an Internet address is set without a mask. M> M> MFC after: 1 month M> Reviewed by: cy M> Differential Revision: https://reviews.freebsd.org/D32708 Just my 2 cents. I wasn't added as reviewer of D32708 and that's why totally missed it. IMHO, such reviews should have #network as reviewer. I'm convinced that the status of classful addressing that was left exactly 10 years go in b365d954cc9c39e9854eeb726a60ae812e0fb2fe was good enough. After that change the only place where classes exist is the mask autoguessing. It was absolutely backward compatible and not breaking any POLA. And had zero code maintainance burden! Nobody have ever had problems with classes since. Did existence of the small piece of code in in_aifaddr_ioctl() or class definitions in in.h created any conflicts with development of any new code? The new /24 default is no better than classes. The only difference that classes maintained POLA and new default doesn't. For example, in my home network I have default router 10.0.0.1 and since it is class A network on my VMs and test boxes I can type # ifconfig vtnet0 10.6.6.6 and that is going to work. With this change no longer. -- Gleb Smirnoff