git: d70ca5b00eed - main - nfsd: Fix f_bavail and f_ffree for NFSv4 when negative
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 08 Nov 2021 21:02:38 UTC
The branch main has been updated by rmacklem:
URL: https://cgit.FreeBSD.org/src/commit/?id=d70ca5b00eede3367ce659a03b2f9cc9729cd0dd
commit d70ca5b00eede3367ce659a03b2f9cc9729cd0dd
Author: Rick Macklem <rmacklem@FreeBSD.org>
AuthorDate: 2021-11-08 20:59:31 +0000
Commit: Rick Macklem <rmacklem@FreeBSD.org>
CommitDate: 2021-11-08 20:59:31 +0000
nfsd: Fix f_bavail and f_ffree for NFSv4 when negative
Since the NFS Space_available and Files_available are unsigned,
the NFSv3 server sets them to 0 when negative, so that they
do not appear to be large positive values for non-FreeBSD clients.
This patch fixes the NFSv4 server to do the same.
Found during a recent IEFT NFSv4 working group testing event.
MFC after: 2 weeks
---
sys/fs/nfs/nfs_commonsubs.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/sys/fs/nfs/nfs_commonsubs.c b/sys/fs/nfs/nfs_commonsubs.c
index 98f1f3d642b3..073da425c20c 100644
--- a/sys/fs/nfs/nfs_commonsubs.c
+++ b/sys/fs/nfs/nfs_commonsubs.c
@@ -2514,6 +2514,17 @@ nfsv4_fillattr(struct nfsrv_descript *nd, struct mount *mp, vnode_t vp,
}
NFSCLRSTATFS_ATTRBIT(retbitp);
}
+ /*
+ * Since NFS handles these values as unsigned on the
+ * wire, there is no way to represent negative values,
+ * so set them to 0. Without this, they will appear
+ * to be very large positive values for clients like
+ * Solaris10.
+ */
+ if (fs->f_bavail < 0)
+ fs->f_bavail = 0;
+ if (fs->f_ffree < 0)
+ fs->f_ffree = 0;
}
#endif