From nobody Wed Nov 03 13:10:37 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id AE5F91830727; Wed, 3 Nov 2021 13:10:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HknFV1t3Xz4ZnB; Wed, 3 Nov 2021 13:10:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id BF1B6193B8; Wed, 3 Nov 2021 13:10:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1A3DAbce050193; Wed, 3 Nov 2021 13:10:37 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1A3DAbMr050192; Wed, 3 Nov 2021 13:10:37 GMT (envelope-from git) Date: Wed, 3 Nov 2021 13:10:37 GMT Message-Id: <202111031310.1A3DAbMr050192@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: e4ce23b238a1 - main - fexecve(2): restore the attempts to calculate the executable path List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e4ce23b238a162f5d36afe8ef49dcd66901138a1 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=e4ce23b238a162f5d36afe8ef49dcd66901138a1 commit e4ce23b238a162f5d36afe8ef49dcd66901138a1 Author: Konstantin Belousov AuthorDate: 2021-11-03 12:58:03 +0000 Commit: Konstantin Belousov CommitDate: 2021-11-03 13:10:22 +0000 fexecve(2): restore the attempts to calculate the executable path vn_fullpath() call was not converted to pass newtextvp, instead it used imgp->vp which is still NULL there. As result vn_fullpath() always returned EINVAL and execpath was recorded from the value of arg0. Sponsored by: The FreeBSD Foundation MFC after: 3 days --- sys/kern/kern_exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/kern_exec.c b/sys/kern/kern_exec.c index 780b917ad21d..c5b450b04240 100644 --- a/sys/kern/kern_exec.c +++ b/sys/kern/kern_exec.c @@ -537,7 +537,7 @@ interpret: &newtextvp); if (error) goto exec_fail; - if (vn_fullpath(imgp->vp, &imgp->execpath, + if (vn_fullpath(newtextvp, &imgp->execpath, &imgp->freepath) != 0) imgp->execpath = args->fname; vn_lock(newtextvp, LK_SHARED | LK_RETRY);