From nobody Wed Dec 29 23:41:30 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C40FE1926BBA; Wed, 29 Dec 2021 23:41:39 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JPSbk494Hz3qp9; Wed, 29 Dec 2021 23:41:38 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.16.1/8.16.1) with ESMTPS id 1BTNfUgW013530 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 29 Dec 2021 15:41:30 -0800 (PST) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.16.1/8.16.1/Submit) id 1BTNfU2o013529; Wed, 29 Dec 2021 15:41:30 -0800 (PST) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Wed, 29 Dec 2021 15:41:30 -0800 From: Gleb Smirnoff To: Kristof Provost Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: eb93b99d6986 - main - in_pcb: delay crfree() down into UMA dtor Message-ID: References: <202112051847.1B5Il2GP030287@gitrepo.freebsd.org> <28AE53F1-2B22-444B-B1EC-1600FA741FE2@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4JPSbk494Hz3qp9 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=softfail (mx1.freebsd.org: 162.251.186.162 is neither permitted nor denied by domain of glebius@freebsd.org) smtp.mailfrom=glebius@freebsd.org X-Spamd-Result: default: False [-0.86 / 15.00]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[glebius]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; DMARC_NA(0.00)[freebsd.org]; R_SPF_SOFTFAIL(0.00)[~all]; NEURAL_HAM_MEDIUM(-0.54)[-0.537]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_SPAM_LONG(0.78)[0.775]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Mon, Dec 27, 2021 at 04:46:54PM -0800, Gleb Smirnoff wrote: T> T> I have created a patch that would mitigate that problem. Once the zones T> T> are global, the jails will eventually die if there is some pcb zone T> T> traffic. T> T> T> T> https://reviews.freebsd.org/D33542 T> T> Despite I still believe that PCB zones belong to global state rather than T> to a VNET, the patch doesn't help to mitigate massive memory leaks with T> vnet jails on a machine that is dedicated solely to run a test suite. T> If machine does nothing except a test suite, there is almost zero pcb T> traffic. If there is no pcb zone traffic, the SMR caches stay, and thus T> destroyed jails will also stay. Our vnet jail "weights" a lot! Even with T> the global PCB zone patch applied, each vnet jail creates 33 UMA zones! T> T> I think we need a KPI to purge the SMR caches, and we also need to put T> vnet jails on a diet. These are two independent problems, of course. Okay, so on top of the D33542 I have another patch that finally allows me to endlessly run the test suite(s): https://github.com/glebius/FreeBSD/commit/355fefcc30036230128d7ac1debcaf60feb24a7e With the patch I still have about 8 - 10 zombie jails left after test suite run. Upon next run they will be recycled, but another 10 zombies will remain. I'm not very happy with the patch in its current form. We need changes to UMA to address problems I described in the commit. I'm not yet putting this patch on the phabricator. Already got too long queue there. -- Gleb Smirnoff