Re: git: 6378393308bc - main - Add an internal libiscsiutil library.

On 12/22/21 10:43 AM, John Baldwin wrote:
> The branch main has been updated by jhb:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=6378393308bc6bd81fb871dacf6b03cf1a390d8b
> 
> commit 6378393308bc6bd81fb871dacf6b03cf1a390d8b
> Author:     John Baldwin <jhb@FreeBSD.org>
> AuthorDate: 2021-12-22 18:35:46 +0000
> Commit:     John Baldwin <jhb@FreeBSD.org>
> CommitDate: 2021-12-22 18:43:11 +0000
> 
>      Add an internal libiscsiutil library.
>      
>      Move some of the code duplicated between ctld(8) and iscsid(8) into a
>      libiscsiutil library.
>      
>      Sharing the low-level PDU code did require having a
>      'struct connection' base class with a method table to permit separate
>      initiator vs target behavior (e.g. in handling proxy PDUs).
>      
>      Reviewed by:    mav, emaste
>      Sponsored by:   Chelsio Communications
>      Differential Revision:  https://reviews.freebsd.org/D33544

I know this has broken the build on some 32-bit platforms due to a
-Wno-cast-align warning.  I'm waiting on a local buildworld to reproduce
so I can work on testing fixes (which will probably just be quieting the
warning via NO_WCAST_ALIGN=yes).  In this case the warning is a false
positive as the structure (ctld_connection) with the stronger alignment
is the one that is allocated and upcasted to the base type internally
and then downcasted again with the warning on the downcast back to the
original type.

-- 
John Baldwin