From nobody Mon Dec 20 07:54:22 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8804F18F7E0A; Mon, 20 Dec 2021 07:54:34 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JHX161Xpfz3MG4; Mon, 20 Dec 2021 07:54:34 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 1122A6978; Mon, 20 Dec 2021 07:54:34 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f171.google.com with SMTP id l8so9007175qtk.6; Sun, 19 Dec 2021 23:54:34 -0800 (PST) X-Gm-Message-State: AOAM5307YfDKYCKqEO9gC4ORgzdZTLgHwpvNH5Ic0Fm9bjw4W96X+T0A rMgv1NgNJP9indBcT6aPauwB/sILbNUdIFAPDrM= X-Google-Smtp-Source: ABdhPJzBQIQ5qMjU+F5d9/Fro3hX1XocgX1x0Xr0ULg+bPaVDiarv5Ryug3ZNT/1K1R5PbQdwyUkJgefWFbFvfMZ3ak= X-Received: by 2002:a05:622a:2d6:: with SMTP id a22mr11288566qtx.29.1639986873704; Sun, 19 Dec 2021 23:54:33 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202112200529.1BK5T0np047358@gitrepo.freebsd.org> In-Reply-To: From: Kyle Evans Date: Mon, 20 Dec 2021 01:54:22 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 4f741801d860 - main - t_setrlimit: Adjust resource limit to 20M To: Wojciech Macek Cc: Marcin Wojtas , Wojciech Macek , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639986874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q0jbxfAtlYNwRaRWskFZqbi2OcWzc4lS9tBPZCjv1xQ=; b=J+ddGd0ybgIrxla2wM/rso6uwKsxxxMA0scoAxwKMIPY8rO0j+EyZ0q1oBGQiWlpdXCuqH HG8PuZT2TO3M+AUbqrj/Tl9C24zpCxJMlYJvxv0qEf9HM+cFsyyIp6euDk0uAF6wdXtK9L QcvXfCRJb6NSlPAU9NNxp+uuq/nk5CiLC7pe4gX1QugsyT47jdmki0MAJBok8TgcdZlhLu NZw5riyTNfCMuuyrd+fUsIA45MLCZI13kXJ9fAsxa6vwV2Rtw3199FKE5vF89qqZpsTwpd PsPh/HV6MNuXKMarMKiwxRHSLMhzEhIVdsxXOK7UgXn87BQf8+GWf9vB6LdCZg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639986874; a=rsa-sha256; cv=none; b=PB1P0mlsFptABen/PyIrxA7TjjFY6cUgigPnpsgK4mBCqd65+M78cnYq1tPhwA1ShnvQrV /EzwhNx4d+62ILOFVZzbf6LiJSaeI84ozhAu7PEqTmFsK9jbUbklZk0exH3VawNv9tfZ0i yy9Ou055AcHAOweOHwNndeSeYPaUBZ3FvUXInNgXPYOIqNrFqAMrK92BYl1o5Aa1VBn4YB WG0/Vp8Y/pPNqo96OHsmy/hkht5dV7lfjHm/n+qQ4UM42qO0oanh6CdbsU0P//oAU52qWm 9vl+t6NLG/B5KoZCQnkOl21r4CUUg3jiB2+dehqCMg5x64dGAqnhAp38jIXgFg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N I found the PR that I was thinking of, that you folks might want to join if you haven't already: https://bugs.freebsd.org/260303 I don't think a revert's necessary, just something to consider if this ends up becoming a non-issue due to other low-level changes. Thanks, Kyle Evans On Mon, Dec 20, 2021 at 1:32 AM Wojciech Macek wrote: > > Hi Kyle, > > Thanks for the comment, I thought this one is discussed but apparently I = was mistaken. > Adding Marcin to handle this on our side. I'm fine with reverting it anyw= ay or do whatever you decide. > > Regards, > Wojtek > > pon., 20 gru 2021 o 07:51 Kyle Evans napisa=C5=82(a)= : >> >> On Sun, Dec 19, 2021 at 11:29 PM Wojciech Macek wrote: >> > >> > The branch main has been updated by wma: >> > >> > URL: https://cgit.FreeBSD.org/src/commit/?id=3D4f741801d86089a1c5d631b= a1e0f1421cdcf7a7e >> > >> > commit 4f741801d86089a1c5d631ba1e0f1421cdcf7a7e >> > Author: Dawid Gorecki >> > AuthorDate: 2021-12-20 05:27:12 +0000 >> > Commit: Wojciech Macek >> > CommitDate: 2021-12-20 05:28:20 +0000 >> > >> > t_setrlimit: Adjust resource limit to 20M >> > >> > With ASLR enabled by default, RLIMIT_STACK test fails due to the f= act >> > that default stack gap can be as big as 15M. Because of that the >> > resource limit of 4M results in test program receiving SIGSEGV >> > immediately after exiting the setrlimit syscall. Since the idea of= this >> > test is to check if rlim_cur does not extend past rlim_max, adjust= ing >> > the resource limit to 20M should not invalidate the test results. >> > >> >> I can't seem to find the PR at the moment, but isn't this exactly the >> kind of thing markj@ talked about trying to avoid elsewhere? It seems >> like this probably should've been involved in the discussion rather >> than hacked around independently. >> >> Thanks, >> >> Kyle Evans