From nobody Fri Dec 17 18:11:47 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0F08918EF9A5; Fri, 17 Dec 2021 18:11:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JFxrg45b3z4jKL; Fri, 17 Dec 2021 18:11:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4B8CC20833; Fri, 17 Dec 2021 18:11:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1BHIBlfN004980; Fri, 17 Dec 2021 18:11:47 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1BHIBlp0004979; Fri, 17 Dec 2021 18:11:47 GMT (envelope-from git) Date: Fri, 17 Dec 2021 18:11:47 GMT Message-Id: <202112171811.1BHIBlp0004979@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: ee5686c614ba - main - ktls: Add a regression test to exercise socket error handling List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ee5686c614ba7e11e8586b2e5b02dfc550679e96 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639764707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5ZMauHlazFDEcohLlKPijZXt/0FOS6OGxVdd0sT7hGI=; b=YbgJ0GA0V/xJqfQogqYO658gS8llUNI0v7rgd8BZ69mDsFrCpKMgJQbmhp/I1ApYtEpD9L tteSk8ucLZ+AWuaIy4aBNBpZCrqyyB1sYjMURTKC5mRBjkwkz5kJnnbPwRp8hj42Yz/qZv FaQeVIzkigmplzAPyi0tveTiH5bq6bWOmYToveuq2BxOBLdi/pw+ZF/ePrLEpxkBtJEQ6q Y6yZg+eW1k4EL/yQ8sxDB/M4z0TQAYN1Z5I32EjEUnYkI2OmzjTiG0aIKqp1IQdwad0TcE mNz5/rUc9F8tbC7quW0WceSM8WPyR1HCTz6zNZmgKR1NrAVlgOChKR+mzwHecA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639764707; a=rsa-sha256; cv=none; b=fFB1d6AMUWc0A18aHcj9WEpQ60PInChmJhusJ6ySc7nDXdy5J21uaUDHaErJyvNt4yJSGU zTzdLnJtIfOP2F4JAcaRoX0vA79DymCC95XTDUDKg/jyBanP5nGQxYrLwKCdIqwUc1lkZq Q+zNdXUw4UXPDacx43ER1YcwNqA+SUgSrt3GyI5/zp3fzwZ0wEsds6MrUM6vOzlI7kVMIf 4EEKgid+JGhdXJHlotD+2Al9XP+FE4k5h2I3Rd/dOYdKIojinFvUmyPTD1x16xwBD+tjQA 3DYONY7K55909vza9yB74hKibHgGVQ5woSXT3c//tcSu0SiH84PqnkHGHqq5qg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=ee5686c614ba7e11e8586b2e5b02dfc550679e96 commit ee5686c614ba7e11e8586b2e5b02dfc550679e96 Author: Mark Johnston AuthorDate: 2021-12-17 16:00:19 +0000 Commit: Mark Johnston CommitDate: 2021-12-17 18:10:22 +0000 ktls: Add a regression test to exercise socket error handling Prior to commit 916c61a5ed37 ("Fix handling of errors from pru_send(PRUS_NOTREADY)") this test triggered a kernel panic due to an mbuf double free. Reviewed by: jhb MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D33517 --- tests/sys/kern/ktls_test.c | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/tests/sys/kern/ktls_test.c b/tests/sys/kern/ktls_test.c index ec71d0c9cd33..9525258a64bc 100644 --- a/tests/sys/kern/ktls_test.c +++ b/tests/sys/kern/ktls_test.c @@ -1722,6 +1722,45 @@ ATF_TC_BODY(ktls_receive_unsupported_##name, tc) \ */ AES_CBC_TESTS(GEN_UNSUPPORTED_RECEIVE_TEST); +/* + * Try to perform an invalid sendto(2) on a TXTLS-enabled socket, to exercise + * KTLS error handling in the socket layer. + */ +ATF_TC_WITHOUT_HEAD(ktls_sendto_baddst); +ATF_TC_BODY(ktls_sendto_baddst, tc) +{ + char buf[32]; + struct sockaddr_in dst; + struct tls_enable en; + ssize_t n; + int s; + + ATF_REQUIRE_KTLS(); + + s = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP); + ATF_REQUIRE(s >= 0); + + build_tls_enable(CRYPTO_AES_NIST_GCM_16, 128 / 8, 0, + TLS_MINOR_VER_THREE, (uint64_t)random(), &en); + + ATF_REQUIRE(setsockopt(s, IPPROTO_TCP, TCP_TXTLS_ENABLE, &en, + sizeof(en)) == 0); + + memset(&dst, 0, sizeof(dst)); + dst.sin_family = AF_INET; + dst.sin_len = sizeof(dst); + dst.sin_addr.s_addr = htonl(INADDR_BROADCAST); + dst.sin_port = htons(12345); + + memset(buf, 0, sizeof(buf)); + n = sendto(s, buf, sizeof(buf), 0, (struct sockaddr *)&dst, + sizeof(dst)); + + /* Can't transmit to the broadcast address over TCP. */ + ATF_REQUIRE_ERRNO(EACCES, n == -1); + ATF_REQUIRE(close(s) == 0); +} + ATF_TP_ADD_TCS(tp) { /* Transmit tests */ @@ -1739,5 +1778,8 @@ ATF_TP_ADD_TCS(tp) TLS_13_TESTS(ADD_PADDING_RECEIVE_TESTS); INVALID_CIPHER_SUITES(ADD_INVALID_RECEIVE_TEST); + /* Miscellaneous */ + ATF_TP_ADD_TC(tp, ktls_sendto_baddst); + return (atf_no_error()); }