From nobody Tue Dec 14 18:55:20 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 74AD618DE488 for ; Tue, 14 Dec 2021 18:55:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ua1-x933.google.com (mail-ua1-x933.google.com [IPv6:2607:f8b0:4864:20::933]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JD6yd2SvKz4lYh for ; Tue, 14 Dec 2021 18:55:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-ua1-x933.google.com with SMTP id n9so17577797uaq.10 for ; Tue, 14 Dec 2021 10:55:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/MChetjbaAl8r3TDD7Trpha/EmPaRLHmnKYqnZk0cNM=; b=KDnHDge+gv699xW5neQdyHiLG5h0ediV5hJzGdIT7W8zEkJfN4e6bkSFxK+re4YLlD 9wHqPY+mOQSyBnbPKTUrgOVrOy4aZmFL+Mpf2lWXPHTJoJoXJfktbA/XuzZu7xVXbhIw hVhwKgtFqKSc848j+FRfxGTUGF7mw4yw9Kh2+V0eCazZMRBIjKRMMRsGmDIve3hfDbbo Khm1oRZf01u4p0wEve1OwV7eohFOdAnNpJiMO7/x9gdwsCwsosM/GUQlzecmDZhkbRMc DQUsyayJzkRGgsqvXdkPmSJuaJ90Att3hXBSljH/4mlCF36/Txf4wirtBdA3f8NOxzPW 9z7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/MChetjbaAl8r3TDD7Trpha/EmPaRLHmnKYqnZk0cNM=; b=Px88Zh3yKBOpsAgaT7FWtq1sx25a8l6usfja2rIP0yg7+AZgzM3r5LYJEXQ2CSa4JU gzwtjqemGsYnKV/pVuyIzJR3L9sfrFCwIrJEjNAyhD/MyEP1Ilu5dxL5dj4ccWYa/jXL HTAtZqm4XTfwJAzhaNIs07Iu11a8b1D/b7fhyekHLiqLHUJJKGFVDIbvMnc0hUnqGamh twHpLnukCSp3EMZMRt0CsCrN/eetMfAjst4jJba04UYBvpsUxBl3I3ll6zT/4RFgBCfV CAHi2cQ8zDJEGarQPdYDeW1/r45RwzaH7yAyJb15zmaJYty6FM/ATPtzSeBE4fL2Fs+x ziFw== X-Gm-Message-State: AOAM533mswutRb9lh5m3lbGBs5c/Mks9xb92ji9vUaWQMRyREq2aIU+8 kWDBVTn2XYs8TmhAimNB8IHRTABfE+H3jmJwIZmjC8D2DkGfUg== X-Google-Smtp-Source: ABdhPJwl0KlaPmS9QkG7przzFs0M98A6g7jGoXl07FVoKKCsK6udJrOas4uY9LypNsaA2U+wctKQv/7UZRfp5mtrLGw= X-Received: by 2002:a67:f950:: with SMTP id u16mr798018vsq.68.1639508131116; Tue, 14 Dec 2021 10:55:31 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202112101831.1BAIVQbm048153@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Tue, 14 Dec 2021 11:55:20 -0700 Message-ID: Subject: Re: git: 4dbc7835cdfc - main - mips: Turn off LLVM MIPS targets by default To: Ed Maste Cc: John Baldwin , Warner Losh , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000c3091005d31fbb29" X-Rspamd-Queue-Id: 4JD6yd2SvKz4lYh X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N --000000000000c3091005d31fbb29 Content-Type: text/plain; charset="UTF-8" On Tue, Dec 14, 2021 at 11:43 AM Ed Maste wrote: > On Tue, 14 Dec 2021 at 13:27, John Baldwin wrote: > > > > This breaks NO_CLEAN=yes builds in I think a lot of object files. > > ... > > Perhaps we should be generating those header files in OBJDIR (and use a > move-if-changed > > scheme to avoid bumping the date if the contents haven't changed) so > that make can handle > > these changes? > > Seems reasonable if that change is straightforward, but we could also > just add a special case in tools/build/depend-cleanup.sh to handle > this. depend-cleanup can be fairly liberal, e.g. delete *.def. > Yea, we have no good way to prevent breakage for things like this short of moving the changing data into a file so dependencies can be tracked. I'm agnostic on the method. I'm also not sure I know of a good way to fix this short of doing a make clean if any of the mips .o files are present. In removing mips, I'm generally uninterested in making sure no clean works over that event because it is a one-shot. But am happy to work with others that are interested to mitigate the damage. Warner --000000000000c3091005d31fbb29--