Re: git: 866036f46c6e - main - bhyve: Support a _VARS.fd file for bootrom

On 12/12/21 7:08 AM, Rebecca Cran wrote:
> The branch main has been updated by bcran:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=866036f46c6e8884cc7a2aa029408366ede40a23
> 
> commit 866036f46c6e8884cc7a2aa029408366ede40a23
> Author:     Rebecca Cran <bcran@FreeBSD.org>
> AuthorDate: 2021-11-28 16:34:33 +0000
> Commit:     Rebecca Cran <bcran@FreeBSD.org>
> CommitDate: 2021-12-12 15:07:27 +0000
> 
>      bhyve: Support a _VARS.fd file for bootrom
>      
>      OVMF creates two separate .fd files, a _CODE.fd file containing
>      the UEFI code, and a _VARS.fd file containing a template of an
>      empty UEFI variable store.
>      
>      OVMF decides to write variables to the memory range just below the
>      boot rom code if it detects a CFI flash device. So here we add
>      just the barest facsimile of CFI command handling to bootrom.c
>      that is needed to placate OVMF.
>      
>      Submitted by: D Scott Phillips <d.scott.phillips@intel.com>
>      Sponsored by: Intel Corporation
>      Differential Revision: https://reviews.freebsd.org/D19976
>      MFC After: 1 week

Hmm, how does this work with the configuration stuff?  I would expect the
vars file to be a separate config file variable (e.g. lpc.vars_file or the like)?
Can you document it in bhyve_config.5 and fix it to use a separate variable if
that is intended?

-- 
John Baldwin