From nobody Mon Dec 13 11:39:43 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3B0F118E1898; Mon, 13 Dec 2021 11:39:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JCKL76nmyz4dWb; Mon, 13 Dec 2021 11:39:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id C540213B44; Mon, 13 Dec 2021 11:39:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1BDBdh6a053406; Mon, 13 Dec 2021 11:39:43 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1BDBdh5e053405; Mon, 13 Dec 2021 11:39:43 GMT (envelope-from git) Date: Mon, 13 Dec 2021 11:39:43 GMT Message-Id: <202112131139.1BDBdh5e053405@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andriy Gapon Subject: git: b416345d5b13 - main - pcf8591: remove write-only variables List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: avg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b416345d5b13c77d82708cab94f43cb6144fbaf7 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639395584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p0VcjdAaHqnyWbR9DshetoZA6Rm9V6zJm0iqRCq9+cg=; b=DzQY7mzte1egl6viJeH2TLRzCw8sQnA0kd2FBMzpQUJRLP6vM/s+8gLRCYbiAXlOsq4npz S00sB/6iY1HOPH6B1Gh+FLDSoUhq7jL4OK46Ue3qgz6F6EpxRnXmUrYLDqtge9fLi87ZZf wXx678HbqIFjGvV74a514trItXWLauVpJ/33QOVyjGfuXNMKF/q6lHT8569wCvhG8l+mbW QUORWybU51wqjqdAY0+JL71GE9H9kSmCx4Gra1jbSqRyDSXeWYoG7I0KITCTrLrIikXl0F 0VW3ILe84Mik9DKFpsIh1CoatxuE2z6YXWNWuQ9JEt7tUBqkr5ZfwYtuc8qGPQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639395584; a=rsa-sha256; cv=none; b=L8DvFtytZwdx46N2tJMOX0vaeJMkJxvc5GZs0Wngo2l8HLE3pGb6m7TzmY+V+OFELDT2Kw xmaV2fEZ3+zLzyITYtx/phBzN5/qWxnMnxss2J4Vqx6I6vQ4eb93OG+c+ffdd8Y6lxzyR+ 3WeyLBC3YksWkYMQzWBY188lXx8KXlUN9fjAKVXNJpbrMFfaW9XIYvhBjYm7+FAeYuwuHi vvHMaVMKQlB+VPIekiKXcLIwfxzXF6osT+vLg6eJ+MG/AUkc9ubDmnGYJIwP5G7+yieYi7 XLpE719NBTDYtpVXCi1CurJVIkAeBnin8c+HaPH6zFrnnhOGlY0ptWjXZlKCQw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by avg: URL: https://cgit.FreeBSD.org/src/commit/?id=b416345d5b13c77d82708cab94f43cb6144fbaf7 commit b416345d5b13c77d82708cab94f43cb6144fbaf7 Author: Andriy Gapon AuthorDate: 2021-12-13 11:10:12 +0000 Commit: Andriy Gapon CommitDate: 2021-12-13 11:39:08 +0000 pcf8591: remove write-only variables MFC after: 1 week --- sys/dev/iicbus/pcf8591.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sys/dev/iicbus/pcf8591.c b/sys/dev/iicbus/pcf8591.c index ff769b368d91..5bae3f0f272c 100644 --- a/sys/dev/iicbus/pcf8591.c +++ b/sys/dev/iicbus/pcf8591.c @@ -141,14 +141,12 @@ pcf8591_select_channel(device_t dev, int channel) static int pcf8591_channel_sysctl(SYSCTL_HANDLER_ARGS) { - struct pcf8591_softc *sc; device_t dev; int error, channel, val; uint8_t reading; dev = arg1; channel = arg2; - sc = device_get_softc(dev); if (req->oldptr != NULL) { error = pcf8591_select_channel(dev, channel); @@ -173,7 +171,6 @@ pcf8591_start(void *arg) struct sysctl_oid_list *tree; struct sysctl_oid *inputs_node; struct sysctl_oid_list *inputs; - int error; sc = arg; dev = sc->sc_dev; @@ -188,7 +185,7 @@ pcf8591_start(void *arg) sc->sc_cfg = 0; sc->sc_output = 0; sc->sc_ch_count = 4; - error = pcf8591_set_config(dev); + (void)pcf8591_set_config(dev); ctx = device_get_sysctl_ctx(dev); tree_node = device_get_sysctl_tree(dev);