From nobody Mon Dec 13 11:37:14 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 71FAB18E1177; Mon, 13 Dec 2021 11:37:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JCKHH1KySz4cjx; Mon, 13 Dec 2021 11:37:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0E08213BFC; Mon, 13 Dec 2021 11:37:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1BDBbEEN053002; Mon, 13 Dec 2021 11:37:14 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1BDBbETN053001; Mon, 13 Dec 2021 11:37:14 GMT (envelope-from git) Date: Mon, 13 Dec 2021 11:37:14 GMT Message-Id: <202112131137.1BDBbETN053001@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andriy Gapon Subject: git: cca0d3bbd8c9 - main - amdsbwd: always enable watchdog register decoding List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: avg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cca0d3bbd8c9f8b50c6940c33704a6c8c464b68f Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639395435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uXNXkK5qdDPMRzbQh1bQ46a6NCf6EhJ1HIkQWHS+u04=; b=k5LTCzY0BrhyDM3DW1SvSTNu4cAo3Jtch61X4tvY9S9JDqup7sFQPaayH6Kz1Oh5qHGmWT W4cA9cmN8LgOmW+Gs2WqwQ8fWpMi/x/jgF825amw5x3/fRX1MAMnFzAOdtmq0QevjQ+/mp r6b0/keq3uxTM5851jEiq/2N6YixLtnVSQ3xvjjKzLgmDa/mczmaDzTrluXY7+AlXAL6xV A2hrR3q7syDGWWtcQeEXjJI0kvaBICDusjcWhGg1l8c03iffKAt84yUeDwgwUqVue/LDfu 1BzMMO4LXQLM5q8VaZgmttECnnTsO+BradzqJhwGkyHWRqJ5xPsy4q7TmgwiOg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639395435; a=rsa-sha256; cv=none; b=l0SRklUj6kUkGHoi/Ritj2UWNJVu/QowhZcTdCWBuztdqTF3G4BJkpQK6L5aWrqWUvVcx/ x0eamcQxEHnutyqrwkKsIgdXf72rL2qxuAzO8j2Yf0kMN8ID0CWcgAQojPup2B/S8JFPBd Buh0KLcoueKXBzlgJsIIlhi4J3Fn78dmf3LsF1eTkFK1eWyTus6OSGWavKk9wqEyEbPA9u kCheAT7sYBlGXWJVEjTX8EZP5qIhxdYUIOgLO6vLWUCQt5XbR8/Ix8XAVK0BxOw/bYw2Sx HJ9kQtu7+dCo6wIVU/1ErrJ0GULSFd12G7rR9q0DSm1hqLYFt3nS6ZNOZYUm2g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by avg: URL: https://cgit.FreeBSD.org/src/commit/?id=cca0d3bbd8c9f8b50c6940c33704a6c8c464b68f commit cca0d3bbd8c9f8b50c6940c33704a6c8c464b68f Author: Andriy Gapon AuthorDate: 2020-05-27 10:15:54 +0000 Commit: Andriy Gapon CommitDate: 2021-12-13 11:36:50 +0000 amdsbwd: always enable watchdog register decoding This seems to be required even if the watchdog is accessed via the common MMIO space. Tested on: - Ryzen 3 3200U APU; - Ryzen 7 5800X CPU with X570 chipset. MFC after: 2 weeks --- sys/dev/amdsbwd/amdsbwd.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/sys/dev/amdsbwd/amdsbwd.c b/sys/dev/amdsbwd/amdsbwd.c index 452b014d2240..a7ab67f1a8b8 100644 --- a/sys/dev/amdsbwd/amdsbwd.c +++ b/sys/dev/amdsbwd/amdsbwd.c @@ -381,24 +381,23 @@ amdsbwd_probe_fch41(device_t dev, struct resource *pmres, uint32_t *addr) uint8_t val; char buf[36]; + /* + * Enable decoding of watchdog MMIO address. + */ + val = pmio_read(pmres, AMDFCH41_PM_DECODE_EN0); + val |= AMDFCH41_WDT_EN; + pmio_write(pmres, AMDFCH41_PM_DECODE_EN0, val); +#ifdef AMDSBWD_DEBUG + val = pmio_read(pmres, AMDFCH41_PM_DECODE_EN0); + device_printf(dev, "AMDFCH41_PM_DECODE_EN0 value = %#04x\n", val); +#endif + val = pmio_read(pmres, AMDFCH41_PM_ISA_CTRL); if ((val & AMDFCH41_MMIO_EN) != 0) { /* Fixed offset for the watchdog within ACPI MMIO range. */ amdsbwd_verbose_printf(dev, "ACPI MMIO range is enabled\n"); *addr = AMDFCH41_MMIO_ADDR + AMDFCH41_MMIO_WDT_OFF; } else { - /* - * Enable decoding of watchdog MMIO address. - */ - val = pmio_read(pmres, AMDFCH41_PM_DECODE_EN0); - val |= AMDFCH41_WDT_EN; - pmio_write(pmres, AMDFCH41_PM_DECODE_EN0, val); -#ifdef AMDSBWD_DEBUG - val = pmio_read(pmres, AMDFCH41_PM_DECODE_EN0); - device_printf(dev, "AMDFCH41_PM_DECODE_EN0 value = %#04x\n", - val); -#endif - /* Special fixed MMIO range for the watchdog. */ *addr = AMDFCH41_WDT_FIXED_ADDR; }