From nobody Fri Sep 25 08:33:35 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hrkW32Bzrz6t3mS for ; Fri, 25 Sep 2026 08:33:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hrkW31D1dz4PFZ for ; Fri, 25 Sep 2026 08:33:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790325215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Y0sYBbgfITBsUhSudFT5/j+DgP+OAta2oMVcK/OFuxo=; b=lBt8QR2Hqn7dKdeAFQkp1INRMAWygChEy3t9uzc7vdLYFr72qpVy0DF1qYBazvJlvNNqVy JdvyjkykWvtjlLa97UfRewbpX6jvnAda0pe7hHp96uyp2PW2GkkoCOFapHW9c8d5DOqR/3 SIhLdAdhzgIt9DnjazrZu0tms3DloA+QSBmQwL19f1aoH0agKcBB1lgTjqQf6blq/HfsFf YglH01YdezhTtDbnAf6O2VlgYryycFki+NbLujpm4rBQkJIpz+EtTmQvoVtdZYv5FcAE5v +twPwtBPXhrYZ9xEqW1aD5WwG5oDexlfSRJfL2+9gx1HZ9AB9aoQi7ATMjALDQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790325215; b=wjGXhwW4Nue444tv4fyiIM7Oe4qFE+24O60hI6SIujMgqpnxs1sYnjl8U9E+LHQEDqklPQ OSyReK7nTxRpDhaqIuJVBHTERsSkAOiiWpLnYe8q+dWxvrdH1gT3oVbiInLX4Sg1clXI/f AwcSOrcx6ehE06FlTdeGe2/bJV9oFpcX0POd8dU4ENsyRjnmOtnFUKVdJ4Bl3S03jYivCG LAscWREbEq6n90FUWyKbY+CZsbypeDihi60HR8pvbama5GhSmBcffF0tIvM8p5dbEH9H6C xEPzEZN596Ai208nHJYOZQtngdfKy3qJf4k/h5CYYHf0wFYL8yTqM76PeGPXDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790325215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Y0sYBbgfITBsUhSudFT5/j+DgP+OAta2oMVcK/OFuxo=; b=qliPRmfmXNcD3mhus8cWLU/AGfhz522nflEFcgZ+T5D0hqz7cT28QXwKJAuIX1iNbVxRfq Vdfi6Tm6Lx+fO2eKhM0Ya9gDEl/qIZtAzDHtLNRF2clc9qWbRQ0m4pPq83WhgfY/K4aiTS OXQlJsMJozth5FFUI1hCk7kqEku1ZT8nlwCwGzFYsCdz5TukwVy+MZ0vviyHV8/mTOBdp1 L9L+rYszNzdQgyPE0+pQz+rpDlCWYTZRweaHfUYoSR5DZ7g0JykoE3QpmycLZrW4u9RNSR q4+h6+zXvPwCiSSr3jWioT7i53nyYGgvA7edMh4LTHEeIUqvDxeGJwZMNZYPcw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hrkW30HfNz12pL for ; Fri, 25 Sep 2026 08:33:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3d4d3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 25 Sep 2026 08:33:35 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Joerg Wunsch Subject: git: 736d7302e445 - stable/14 - cam/cd: avoid integer divide fault in cdstart() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: joerg X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 736d7302e44598cb10557026b0a72e319a63194b Auto-Submitted: auto-generated Date: Fri, 25 Sep 2026 08:33:35 +0000 Message-Id: <6ab631df.3d4d3.4f4f6275@gitrepo.freebsd.org> The branch stable/14 has been updated by joerg: URL: https://cgit.FreeBSD.org/src/commit/?id=736d7302e44598cb10557026b0a72e319a63194b commit 736d7302e44598cb10557026b0a72e319a63194b Author: Joerg Wunsch AuthorDate: 2026-07-26 20:54:01 +0000 Commit: Joerg Wunsch CommitDate: 2026-09-25 08:09:58 +0000 cam/cd: avoid integer divide fault in cdstart() If something goes very badly (e.g. forcibly removing a medium while the OS tries to start it), this could end up in params.blksize being 0 (and params.disksize 1). Avoid an integer divide fault, panicking the kernel, by bailing out before. MFC after: 3 days (cherry picked from commit 34ae0f7834d1bd6bb765d1c12e57e01e32b3e060) --- sys/cam/scsi/scsi_cd.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/sys/cam/scsi/scsi_cd.c b/sys/cam/scsi/scsi_cd.c index da6d25ad0031..6482bb44226d 100644 --- a/sys/cam/scsi/scsi_cd.c +++ b/sys/cam/scsi/scsi_cd.c @@ -930,6 +930,16 @@ cdstart(struct cam_periph *periph, union ccb *start_ccb) return; } + if (softc->params.blksize == 0) { + /* + * Something went utterly wrong. + * Avoid integer divide fault below. + */ + biofinish(bp, NULL, ENXIO); + xpt_release_ccb(start_ccb); + return; + } + scsi_read_write(&start_ccb->csio, /*retries*/ cd_retry_count, /* cbfcnp */ cddone,