From nobody Fri Sep 25 07:46:07 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hrjSH5c1kz6t1PZ for ; Fri, 25 Sep 2026 07:46:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hrjSH2dLfz4KH0 for ; Fri, 25 Sep 2026 07:46:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790322367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jlmwS2OeQcWfp1pQVNRdYKPaYm4W5SjljjWLiXWvsI0=; b=NhmdEx8YdUOr9vg4F6xTE3errqJkUUgfsFAtJyLkV+iSi42kwgYHknrpELAq559uF3I7yM H4bt4nr4JoW7wCYUmd4HE03doa5OM+36ZmQTwtXNq6C7Mce2gg0xm+yX6mvIsNzuZY1kz/ EPY7c/ULKb00Q7khJm2sb7aiEAjaXNfo8TP0wnTW7oQOoO0S/GARn7Tt5nKtvwMlmES4TP 2qOYUAo2nFFUCxD8hlChlMLcJzYNz2rr0wkRGieXyWC3pDaUHEEEKb1lSHRHT4gMst7lY1 RFQRqnkH3xVWeKyC+Bt7DBkvsJ03XXYrgja93nBUCpUuqJWK5cZDNsyUEgAhuA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790322367; b=PFwQvOSwekrRoc2X4vYLDVfCnFZLarWzQ4Qv6f6onhgYgEoHa1fLwy7dmHtse3GtZ7w12D RF8Iunbu1G+3V7lTe8KQbbxlRuh/kLg22uK4LcJD2nu71bZvsfatxlAOeOsjUlPt4RsaVs mXeHpbDmm1br7z4dYa1vAEmGvf4CUf57jTDeJR9uqajLqa5gLDI7ytcdKCSD/0IyOjxoGS IZ4bGOla2wznbp2iPBFqunAz4/ajIjlbvt8qbngADt1YQ/E1taLyW+cL20mbzZpdRbu8A/ fTsIRIuOk8DkQbgZuylLJow++QnECslgibHb/RMt+tM4xPcaizen15AhnPrToA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790322367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jlmwS2OeQcWfp1pQVNRdYKPaYm4W5SjljjWLiXWvsI0=; b=ju/hqobRBcosCXldHZWtDipMEW3dV3Bt/FMMYU0LPqJVczzwpDibqhdjpWtb/syCFGQwly 2ZvPVyeZj0dbt63U8xxMsd8lnjsFj15Fkl/B8nA+ktA5O3taDR05C1HmK79GTYyOvcH/a5 7yVH5M/ofmL8Ez7b1UXqufujG2N+MSexSQSRCN6LejQg2RLWbyj1h6zas0QaPcKoxKZCk5 NG23Unm3DfyitfDcARTkPOTnZ10nvl4Kd31rJyiQutPCscygelwf7qimdC1OsUfq1OrzYz tF98eXQqeJAKeM7RvQ4vy/n+LUhgtjsGIlTKsMFa2bbdWS3RXWpogTQHitNufw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hrjSH19wpz125M for ; Fri, 25 Sep 2026 07:46:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3979d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 25 Sep 2026 07:46:07 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Joerg Wunsch Subject: git: 90745f06bb21 - stable/15 - cam/cd: avoid integer divide fault in cdstart() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: joerg X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 90745f06bb21c0675ea1408515051a8b94101b8c Auto-Submitted: auto-generated Date: Fri, 25 Sep 2026 07:46:07 +0000 Message-Id: <6ab626bf.3979d.1c5d09c5@gitrepo.freebsd.org> The branch stable/15 has been updated by joerg: URL: https://cgit.FreeBSD.org/src/commit/?id=90745f06bb21c0675ea1408515051a8b94101b8c commit 90745f06bb21c0675ea1408515051a8b94101b8c Author: Joerg Wunsch AuthorDate: 2026-07-26 20:54:01 +0000 Commit: Joerg Wunsch CommitDate: 2026-09-25 07:45:34 +0000 cam/cd: avoid integer divide fault in cdstart() If something goes very badly (e.g. forcibly removing a medium while the OS tries to start it), this could end up in params.blksize being 0 (and params.disksize 1). Avoid an integer divide fault, panicking the kernel, by bailing out before. MFC after: 3 days (cherry picked from commit 34ae0f7834d1bd6bb765d1c12e57e01e32b3e060) --- sys/cam/scsi/scsi_cd.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/sys/cam/scsi/scsi_cd.c b/sys/cam/scsi/scsi_cd.c index e622a96ec77e..1e8dc98d53f4 100644 --- a/sys/cam/scsi/scsi_cd.c +++ b/sys/cam/scsi/scsi_cd.c @@ -918,6 +918,16 @@ cdstart(struct cam_periph *periph, union ccb *start_ccb) return; } + if (softc->params.blksize == 0) { + /* + * Something went utterly wrong. + * Avoid integer divide fault below. + */ + biofinish(bp, NULL, ENXIO); + xpt_release_ccb(start_ccb); + return; + } + scsi_read_write(&start_ccb->csio, /*retries*/ cd_retry_count, /* cbfcnp */ cddone,