From nobody Wed Sep 23 10:24:48 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hqY4J5nnyz6spym for ; Wed, 23 Sep 2026 10:24:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hqY4J3m7lz3Cwq for ; Wed, 23 Sep 2026 10:24:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790159088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nz5w+eJm6YS8HKZh1zfggZlqv5mN+UprbmS+Xwbc3zA=; b=iMOYGJDP8RrBAOg31esZdDhaBCTvDDpPRxU24juwIXccQKZwbPX937R4VcQlkqcS7ovcdh p9vxpjmQSu/UVoQREltItyzx6Xhxr+ChO2cIX5pL0C3kJxM1Q/4w6p+ITLXk6kp+a0CgVE yo2vXsoqTAzSPtGWZVHT0vEVlW8riE8asJfzMtepNTyCrK9sK1g7OAq8ZuOn9j3DyjJc/8 Na1L0/umYlnxH/rh1t39KkgIBiJ4KxjJOJQOmsMbdQAGCaUSy5msTcuyafdcKo+kJScJ+2 0faLKWjpVQHTCegvMjvI2pp/RtR04A+mdJgBpHu3X859MdIkLV0HultqHn944g== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790159088; b=H/7F664gReMtudCwFyOS5tg0VOFw3Ry6Q40rNZnfX6qQc2pMpIjadZfXtlIJ/wsKfN0L94 BM2DtnBrUkMkXgvxfsNhiNj4+42tFsVLIXpUFCzeCjsmqLXszAZLgvp8ffmJ8R9Z5Ah28x bmtUZD12XdXEw8SZuTQlidTakH6S1zFirjhjiEV66rjZLP7qtn76IPB8bgQf9s9Re3613U XYmfkwZAL+lq4aEphCRhzBap92y8w5JLVEH9lG7JrrE0XpLMOBZSsvXqg2t5mV8g4QaE3E n3xQAa0CzBVRrdFxM8VVwo4UZqCzytR+vsJMw4HkRfi3HzCNzqsBAzWdVeFpJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790159088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nz5w+eJm6YS8HKZh1zfggZlqv5mN+UprbmS+Xwbc3zA=; b=Z+34aeLSI661ILWpYF0WfEHBVZeq9TODHWlT0WHaqanrHDYf/VbhT66NL4AY22/ZZS8qha r0LZlT6sDuL7PD1JPco8qLZJAESBQCctm5dwKrYcHQEC9TRnDAeap2d8UPcdp1pVbfSlxc gIv0y4hbX0w7m6yhDJlXkxEktnYK4Z6EwK/HT0D/qjpS6dFh76XNdPNtCCzWmPpgkVJDQl tiHqMpTP+dK7/F3aKTmHtepGmf1LZ/No4PSPn/v5WyVuSYGCNrsuVgtFLnVA4oO51ULXEQ +66oG0I0jD+ytcsAKLGRW1JgjnnWu5YzX1tiK6DjRCYe6r+icn4ArgRrG3nJKw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hqY4J2X48zq9b for ; Wed, 23 Sep 2026 10:24:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3cb4d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 23 Sep 2026 10:24:48 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: 26e90d2d2892 - stable/14 - Fix statement with no effect in linuxkpi's xarray.h List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 26e90d2d2892fc9dd07fc7e9c5c342a77c337934 Auto-Submitted: auto-generated Date: Wed, 23 Sep 2026 10:24:48 +0000 Message-Id: <6ab3a8f0.3cb4d.77ea4372@gitrepo.freebsd.org> The branch stable/14 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=26e90d2d2892fc9dd07fc7e9c5c342a77c337934 commit 26e90d2d2892fc9dd07fc7e9c5c342a77c337934 Author: Dimitry Andric AuthorDate: 2026-09-18 07:07:46 +0000 Commit: Dimitry Andric CommitDate: 2026-09-23 10:18:09 +0000 Fix statement with no effect in linuxkpi's xarray.h When compiling the kernel with gcc 14, errors similar to the following are emitted: sys/dev/cxgbe/iw_cxgbe/ev.c: In function 'c4iw_ev_handler': sys/compat/linuxkpi/common/include/linux/xarray.h:132:23: error: statement with no effect [-Werror=unused-value] 132 | flags == 0; \ sys/dev/cxgbe/iw_cxgbe/ev.c:274:17: note: in expansion of macro 'xa_unlock_irqrestore' 274 | xa_unlock_irqrestore(&dev->cqs, flag); | ^~~~~~~~~~~~~~~~~~~~ sys/compat/linuxkpi/common/include/linux/xarray.h:132:23: error: statement with no effect [-Werror=unused-value] 132 | flags == 0; \ sys/dev/cxgbe/iw_cxgbe/ev.c:283:17: note: in expansion of macro 'xa_unlock_irqrestore' 283 | xa_unlock_irqrestore(&dev->cqs, flag); | ^~~~~~~~~~~~~~~~~~~~ It looks like the intent of the "flags == 0" statement was to make the 'flags' macro argument not unused, but it still results in a warning. Use the construct "(void)flags" instead. Reviewed by: bz MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D59787 (cherry picked from commit aca53fc2a6879f45dcbe1a60f91f14a5f6d48448) --- sys/compat/linuxkpi/common/include/linux/xarray.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/compat/linuxkpi/common/include/linux/xarray.h b/sys/compat/linuxkpi/common/include/linux/xarray.h index d293a8f7c2a3..4b015bf00c73 100644 --- a/sys/compat/linuxkpi/common/include/linux/xarray.h +++ b/sys/compat/linuxkpi/common/include/linux/xarray.h @@ -107,7 +107,7 @@ void *__xa_next(struct xarray *, unsigned long *, bool); #define xa_unlock_irqrestore(xa, flags) \ do { \ xa_unlock((xa)); \ - flags == 0; \ + (void)flags; \ } while (0) static inline int