From nobody Wed Sep 23 10:24:02 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hqY3Q642tz6spjl for ; Wed, 23 Sep 2026 10:24:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hqY3Q5VLsz3CNK for ; Wed, 23 Sep 2026 10:24:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790159042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FefT6vZ7091dwcba39MallHOtWVbiEdv5o/jQKRLrKA=; b=VsJl4v5js0ZEUVaQxWY/xLUADsTRsckoMnZ1jv5QpjGApw1XS5RSUxgXl5gTdMyfYYpEXn taC1mB9NicPkRr/uEFQGzz/5WjMV2YtiSq6LQKRbdeY+SS5Pe9/F2iHieSj3Egq8VRps0Z wJrGkS3tpqsBEjfLPafbpS9ltpVaoOBnMvLwh3Z50aUFFFSSQMin3aVMK9vLyovvQuX2sf eG22WLlngCSOKbILP6rrTv2YrdmRUqysJbpx88EwBLwshoZpyfd41Fx4ZW4pgfiJuA83fF wCUNQO88OhsKzs34J8aVQHs9YBuJ1pQ5jWv9C1VxUQvev3jGKV8uEgd08fmgmQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790159042; b=MWBJPuuoahszCKrAAxy7CNeURSM7Jgg6v8yT00Wv6G4jx+VFdQAr+/We5ddccgqEo2/JA1 djuPSSZUcDDd1zaD+vhFrLBOEmJ+yfSXIrZ42XPK+IunWp//Epj/Qu9StanpOsqlqSPlau /rZULK1hBAYGh/8AQJhq+Ylf8KLqFczFoAqCbeSwHhxXdUmWiMObDhGjLuthK2zFL+AFz7 mMSMuZLJRZJmnRgI28wkmgl5yv7QedsddAw6KKPKlKa78kJ9gLVBqLd4kwThKz13Kd+gql lriZHA4X+dx+ag6VFS+j5nOkz72ToukO/3wzETDivUwShfye+7pfZjTnxdaTog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790159042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FefT6vZ7091dwcba39MallHOtWVbiEdv5o/jQKRLrKA=; b=yllzoFo9uGCizK5V4g/v3xvecZM3+LESxuuDMoQo8aMnuQivaOpuW6976lpTkDXOdxpMuJ ieCm8k5jd+Oib+jYH3pVRXKwoUcfVG7y6qwpo7BGw0wPsl4jUtqUTNeTOEZJ7D0B/9BETP Hal2stDLpRe4G1TipDovFMdF7aNVVFbMrOcmnljZVA2s9BhthmKiv7LWrbBfqFYQbCu+WS NqCOYvePSUQoMiGNxwH08GKSVSkLCa/zbGbVbFWKdnqt+Cd+wNKH3xxuhZ6hYZIdCRZtdB 3A7KzsTW1Jq7rFe0bxGEnL4rjyQssLCt1//aQmsdPJi9MMpeqAeteuRuSNAyzg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hqY3Q4FlPzp8K for ; Wed, 23 Sep 2026 10:24:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3dd83 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 23 Sep 2026 10:24:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: 82d6bd170fa5 - stable/15 - Fix statement with no effect in linuxkpi's xarray.h List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 82d6bd170fa59f27b18900c39c0d27fe2d922b36 Auto-Submitted: auto-generated Date: Wed, 23 Sep 2026 10:24:02 +0000 Message-Id: <6ab3a8c2.3dd83.498f14ae@gitrepo.freebsd.org> The branch stable/15 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=82d6bd170fa59f27b18900c39c0d27fe2d922b36 commit 82d6bd170fa59f27b18900c39c0d27fe2d922b36 Author: Dimitry Andric AuthorDate: 2026-09-18 07:07:46 +0000 Commit: Dimitry Andric CommitDate: 2026-09-23 10:18:02 +0000 Fix statement with no effect in linuxkpi's xarray.h When compiling the kernel with gcc 14, errors similar to the following are emitted: sys/dev/cxgbe/iw_cxgbe/ev.c: In function 'c4iw_ev_handler': sys/compat/linuxkpi/common/include/linux/xarray.h:132:23: error: statement with no effect [-Werror=unused-value] 132 | flags == 0; \ sys/dev/cxgbe/iw_cxgbe/ev.c:274:17: note: in expansion of macro 'xa_unlock_irqrestore' 274 | xa_unlock_irqrestore(&dev->cqs, flag); | ^~~~~~~~~~~~~~~~~~~~ sys/compat/linuxkpi/common/include/linux/xarray.h:132:23: error: statement with no effect [-Werror=unused-value] 132 | flags == 0; \ sys/dev/cxgbe/iw_cxgbe/ev.c:283:17: note: in expansion of macro 'xa_unlock_irqrestore' 283 | xa_unlock_irqrestore(&dev->cqs, flag); | ^~~~~~~~~~~~~~~~~~~~ It looks like the intent of the "flags == 0" statement was to make the 'flags' macro argument not unused, but it still results in a warning. Use the construct "(void)flags" instead. Reviewed by: bz MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D59787 (cherry picked from commit aca53fc2a6879f45dcbe1a60f91f14a5f6d48448) --- sys/compat/linuxkpi/common/include/linux/xarray.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/compat/linuxkpi/common/include/linux/xarray.h b/sys/compat/linuxkpi/common/include/linux/xarray.h index b26aa6f0d13a..e05a24259cd9 100644 --- a/sys/compat/linuxkpi/common/include/linux/xarray.h +++ b/sys/compat/linuxkpi/common/include/linux/xarray.h @@ -126,7 +126,7 @@ void *__xa_next(struct xarray *, unsigned long *, bool); #define xa_unlock_irqrestore(xa, flags) \ do { \ xa_unlock((xa)); \ - flags == 0; \ + (void)flags; \ } while (0) static inline int