From nobody Mon Sep 21 05:11:15 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hpBCR1gHdz6tFyy for ; Mon, 21 Sep 2026 05:11:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hpBCR11Glz4STW for ; Mon, 21 Sep 2026 05:11:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789967475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=s7yvgZnpwKcCZrgMUhoszbe6f1bHYkCOoUzTNap0hR4=; b=e4DsSQqX5IeSvkAtRaIIpvY//n6Hj1G4NK5f4xxIisaXIC+lBi2aRkgLVVvti+WzrgAefF IphSTvhxn0aP4SqmTWt9NlDlLailkjkTxxZeQH/kpflW+BuWARMaQMelnmuPz4QXvrL42w Ul1U44EvGwliPkwm2+JZ2cfEZWkTppYq0F/FJxctOUZiZ7K4Hr/LgQEu9/2xhM00y185Zh FBaa/YMuenfgsACLYdZ4v5iKBCE+slmqKVDScdrChdVlLdmPfqkCkDbUbv9TrQ0efFxNVe NDye0pkSM4bZo1/RQwtbz/V/ljZi83rFdL5CNUUWC6FrhOz5PtOEOtFHlXdLHQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789967475; b=COaivp3MRKQXLMgx6gBd0BHtElK0U5f/MpYwGMlufwEow4RFiw5RSy+hDVftku0skWp2Qj DHFRwh5RHe8yb28lVtxlWtDmnYn9bcKEmYNrHl083nzwkhzoi171heFuKXHB1MZZ+cRKoj IQOCF+niSbrtPuzFgPdwBIDyIs2GHopalusGoAExBQCBLarIYQDmju0D1yr9JX3USaTOiA DIYgstqxjjlqQ7z5MwhNu9cLiJ84cGLEMbnI1WRcRpqYhkDJAdE96Tf1IXD1YKWsOvySe3 WByP1B/aIXEXnndk6GZ8iVgDUXkpMlyvKxUB7VIrPP44QS1BogrgDEvNdR4QDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789967475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=s7yvgZnpwKcCZrgMUhoszbe6f1bHYkCOoUzTNap0hR4=; b=YBzlTWq0xFqZt/t+g50CUgpJKhP5aurHulrzRmMOwf4p7jBba7u3YFOlhYOxGd3yjXERdA hCTbe+aU0heTSPupHawRZqDuXSn6s/OADmawDoTtECnmJo6oIMnNZiNe8ykrdiU49zYW6z S+zFeotO9jcLPWPpxHBuQVbW+By12N+hKpq5jc6HE/ne2K98n35d90Zh0QiQi1MPCMhvTd Qxy6RdqJaX4uLc6UxgnY7jDUVG39itMtc8ZAl0Ag6RLIhCL2AQMyanw4I4Bp/okOgLOArk okThRkkLJJJWk97RCVvVKJZ+MN7Qi/hEuo1aZDMdpyPzadZ1N6qND+AUX4RCWA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hpBCR05LPz15GH for ; Mon, 21 Sep 2026 05:11:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 360ef by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 21 Sep 2026 05:11:15 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Jason A. Harmening Subject: git: cb1ee0c32144 - stable/14 - vfs_lookup_cross_mount(): fix missing LK_CANRECURSE List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jah X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: cb1ee0c3214405331bb8085d3be910d4f560edbc Auto-Submitted: auto-generated Date: Mon, 21 Sep 2026 05:11:15 +0000 Message-Id: <6ab0bc73.360ef.492e0bcf@gitrepo.freebsd.org> The branch stable/14 has been updated by jah: URL: https://cgit.FreeBSD.org/src/commit/?id=cb1ee0c3214405331bb8085d3be910d4f560edbc commit cb1ee0c3214405331bb8085d3be910d4f560edbc Author: Jason A. Harmening AuthorDate: 2026-09-07 17:36:20 +0000 Commit: Jason A. Harmening CommitDate: 2026-09-21 05:10:47 +0000 vfs_lookup_cross_mount(): fix missing LK_CANRECURSE This was a rather dumb miss on my part in commit 42442d7a6e. LK_CANRECURSE is clearly needed in any case in which the covered vnode is held exclusive across the call to VFS_ROOT(), regardless of whether it was initially held exclusive or upgraded. The commit message for that change also noted that unionfs lookup only worked without LK_CANRECURSE due to a coincidence of the then-current unionfs implementation. As it happens, said coincidence was recently removed in commit b952606b4f ("unionfs_lock(): eliminate LK_CANRECURSE special- case"). PR: 298201 Reported by: olivier Fixes: 42442d7a6e "Generalize the VV_CROSSLOCK logic in vfs_lookup" Reviewed by: kib, markj, pho Tested by: pho Differential Revision: https://reviews.freebsd.org/D59494 (cherry picked from commit f57ce26f2572efb8adc825ad4efc0e0743a9112f) --- sys/kern/vfs_lookup.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/sys/kern/vfs_lookup.c b/sys/kern/vfs_lookup.c index 1d303fecf493..c0322d59693e 100644 --- a/sys/kern/vfs_lookup.c +++ b/sys/kern/vfs_lookup.c @@ -941,16 +941,20 @@ vfs_lookup_cross_mount(struct nameidata *ndp) * We are going to be holding the vnode lock, which * in this case is shared by the root vnode of the * filesystem mounted at mp, across the call to - * VFS_ROOT(). Make the situation clear to the + * VFS_ROOT(). Make the situation clear to that * filesystem by passing LK_CANRECURSE if the - * lock is held exclusive, or by clearinng - * LK_NODDLKTREAT to allow recursion on the shared - * lock in the presence of an exclusive waiter. + * lock is held exclusive, upgrading the lock (and + * passing LK_CANRECURSE) if the lock is held shared + * but mp requires an exclusive lock for lookup, + * or clearing LK_NODDLKTREAT to allow recursion on + * the shared lock in the presence of an exclusive + * waiter. */ if (VOP_ISLOCKED(dp) == LK_EXCLUSIVE) { crosslkflags &= ~LK_SHARED; crosslkflags |= LK_EXCLUSIVE | LK_CANRECURSE; } else if ((crosslkflags & LK_EXCLUSIVE) != 0) { + crosslkflags |= LK_CANRECURSE; error = vn_lock(dp, LK_UPGRADE); if (error != 0) { MPASS(error == ENOENT);