From nobody Sat Sep 19 07:27:32 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hn1Kc2lxmz6sPyC for ; Sat, 19 Sep 2026 07:27:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hn1Kc2Fw0z4vQw for ; Sat, 19 Sep 2026 07:27:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789802852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Utg6FhgH2APJM+kKPFBwbwmIfpG615CKRDc16ruznwQ=; b=R/ust6VKcaCjcepyJPieRuaxVwG7Wo+ooatnoqgvGqBGmW9paYTzjGmf79UYVKMlKb/lRu 9UomusHcc/XH/hCKq2qN7hx5OVLp28UQTIDz/hVECm24WORsoFCKYHoXxtoXDDuMGsvUYm 4aegn9C0+TAIGwpA05bm7KILQghplKgObIbJEbHvfMwQIlcadH7RCln9fZk7vVdnR76aYc BeM6TT0yqzUi/d+kxdVexamaUHw9p65RGCjpL/h8Ie1II4m+cF6jOb20TmRUjKHwCD2Xsa 3GNKvZoaNwM5Mnz/CCnkIfaXhlLWxHXyl9Frrlbr3PqVC6bzPMIVy9SWD3YPfw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789802852; b=nS9U/2u8vgWZO5m0BOKKZFK9RkXOhRyZKDdp1IggdfKTc8Twm2IH4YhKPmK2KUMr1Hu2o1 uD3LsA0/OiBINUa5rm82BUOPKK9HVfs4a+P8r1sP9dQWGrklENHUybjO44RPIk0zKa1rwr W0O7bcgBjwxgTRVHQkla2V3SMJXRPxsrc5Do89/Od5YUTk8Q5G891jUT+mx88zUpUrie50 78hJZ2jRMbf7sO5nodn/yT6FnWd2WvHQzJoIu96J4W/KJOFnySMcUTR6Uv3cs0QGWlMRN2 gy6vuQkpJweGR7d/VS+rkN+3KWoKtHcqyZdG7UEjJsI9S3BhQcGMeGp2f7US1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789802852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Utg6FhgH2APJM+kKPFBwbwmIfpG615CKRDc16ruznwQ=; b=cEcqNK7XeVT5ZzJ7VHmnEPxEQoFyKwDtOZspDU68TEtcqZLGBCMN9LbMGsAOyUN2fnjo5e z9LxXeatg+2xGV2JqeGjdsycx7TY82vtgMTQRX1IYOiq3H8Rhq31v7YkqttQK1g9dZkqWE XFDs5YfG7Okt1sD2E7dGSl/GYlRVI7nlu00YFJ1XQgD4ZVVzBuf9HV63/vuLhAcWpC7SLt teKpyR/LYOyOnBeImTLz3UkQ35jsCcPj5e74b20y6GLXIFhd/f59lsuQSs7oCSGXg9J0lv jRF4/PHRtR9lEFZjfY5J0UxC0tvEb1svd/rCSZEZncgOwAXfACx7EGAJmUxy+Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hn1Kc11z2zw8W for ; Sat, 19 Sep 2026 07:27:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 434b2 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 19 Sep 2026 07:27:32 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Roman Bogorodskiy Subject: git: 11df1d931657 - stable/15 - bhyve: fix byte order for manually set NVMe eui64 List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: novel X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 11df1d931657e3eeee85b267d50ffea401cfc845 Auto-Submitted: auto-generated Date: Sat, 19 Sep 2026 07:27:32 +0000 Message-Id: <6aae3964.434b2.34f99188@gitrepo.freebsd.org> The branch stable/15 has been updated by novel: URL: https://cgit.FreeBSD.org/src/commit/?id=11df1d931657e3eeee85b267d50ffea401cfc845 commit 11df1d931657e3eeee85b267d50ffea401cfc845 Author: Roman Bogorodskiy AuthorDate: 2026-08-21 13:27:56 +0000 Commit: Roman Bogorodskiy CommitDate: 2026-09-19 07:23:51 +0000 bhyve: fix byte order for manually set NVMe eui64 Manually specified eui64 value gets converted to big endian twice: first using htobe64() and then using be64enc(). On little-endian hosts that results in a little-endian value instead of a big-endian. Fix by removing htobe64() for a user submitted value. Fixes: 409a80e5a434 ("bhyve: Create EUI64 for NVMe namespaces") Reviewed by: chuck Relnotes: yes Sponsored by: The FreeBSD Foundation MFC after: 3 weeks Differential Revision: https://reviews.freebsd.org/D59080 (cherry picked from commit 8bd30a72e7012126a1c8d52b3ba32f844a88f8dc) --- UPDATING | 10 ++++++++++ usr.sbin/bhyve/pci_nvme.c | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/UPDATING b/UPDATING index e8d93352d78e..7fcdaaebae2f 100644 --- a/UPDATING +++ b/UPDATING @@ -12,6 +12,16 @@ Items affecting the ports and packages system can be found in /usr/ports/UPDATING. Please read that file before updating system packages and/or ports. +20260919: + bhyve(8) users who explicitly set the eui64 option for an NVMe + device may need to update their configuration. Due to an incorrect + byte-order conversion, bhyve previously presented manually + configured EUI-64 values to the guest with their bytes reversed. + To preserve the identifier previously visible to the guest, + byte-reverse the value in the eui64 option. Automatically + generated EUI-64 values, used when the option is omitted, + are unaffected. + 20260727: The wait_for_pids() function in rc.subr, used by rc scripts when stopping or restarting a service, has been modified to diff --git a/usr.sbin/bhyve/pci_nvme.c b/usr.sbin/bhyve/pci_nvme.c index 7e6c8bc9d719..f5ea2d5749c1 100644 --- a/usr.sbin/bhyve/pci_nvme.c +++ b/usr.sbin/bhyve/pci_nvme.c @@ -3213,7 +3213,7 @@ pci_nvme_parse_config(struct pci_nvme_softc *sc, nvlist_t *nvl) } value = get_config_value_node(nvl, "eui64"); if (value != NULL) - sc->nvstore.eui64 = htobe64(strtoull(value, NULL, 0)); + sc->nvstore.eui64 = strtoull(value, NULL, 0); value = get_config_value_node(nvl, "dsm"); if (value != NULL) { if (strcmp(value, "auto") == 0)