From nobody Sat Sep 12 00:28:05 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hhXLs6B3gz6rbSd for ; Sat, 12 Sep 2026 00:28:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hhXLs5QsLz4mj1 for ; Sat, 12 Sep 2026 00:28:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789172885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cDyZiLf0Z5GpI1SFM+kN7SPUYaTIfmaL3KOWePRGzGg=; b=rjtjQUQLGwSxrjcycQIdo9l8jeNjCBZgTwRWZYJEHpe2fvlHeVYQlV6dusAU+9K1qQgbTg mWJvYQFFnF1n3KPxkIZy0fY/rdTf5fhKlDarXE49QvU8iBf+pYHDPnEV/IYdfXXuB/GHiV Fw/iwcpgK1Oq/LM8mu/5rF13JfvcCaAQuA9JdL7n99660NcGiECO28K94XSUoF6mei2pit ZFR0/DBnvFQsJ0O8rfUmSl+MpMX8ZJI7kVELn26miN5xjZAvjOtUQpgMZr/eu3cw/xj8UB IWUUARJ4dVwn6uoGs6Cgu8YU7Z28HwH4SckRS4Fqvy5x2GRG7WHh/anBTzdj1Q== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789172885; b=fto+vfamt5LK2cMf9NVPv9FgcNilBkZ0SMPRsT1ahnirz/Qz3HCAGTweq9fV1f0dLhGdXl IolABJm424tFNgabsOsG2UY516eFdyWRxfx6Lk4sLf0UB5JJlDrDN0/XmjX1shVsLaMt8b qvwHE9X2VTdRWb9X6tsYk4Qo+vnTmhudqGraom9wFN0I2XUaetSRe7FBnt79Nu94RRwF+d gTepR4r8zVHWVxuEV4MEnhFDH5J6Sqyk7LrJcjGDxOXJkJKoZiVXxPqFu19m3KWdKFp7NE JnrJuDvkt0MWsLoA0OD8TpNSs58evvLiRNEzoGACAyJZy14IvJdRaJFFErL+GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789172885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cDyZiLf0Z5GpI1SFM+kN7SPUYaTIfmaL3KOWePRGzGg=; b=dzW5APLae3ycjKTvsE8xviKipOQlcETHrBHFvmgQc+zpdGjO1H6CV4lbTs1BbBAW610X9I 1tTo5Rq2BmeXnUahzfqvz9rw4GF9JhW974Gf5MMfVajwzfbOx+jbwSsMJK/1i/A+TP0nuw hfu7fg5FCJrGv9dtBtDpo3YD8rpLAsuXltEAA01ZtC5UiywOJOgQKEktAZJPea0Nd6Sa56 84thUvu6YmXegvdZIyQm/Qiq3i7jQhzQcdLrZZ4Z+GZaNKa51uZ9g8GXm7LfHEEFaTSzdi RbnbHL8+nPiu46bMMQp5rnwhv1Pqtt86NxG5BOv4ezFMrWZ6ZYT7d/RGFuRWgA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hhXLs4TTdzcxW for ; Sat, 12 Sep 2026 00:28:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 473b1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 12 Sep 2026 00:28:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Konstantin Belousov Subject: git: 19fa964bda24 - stable/15 - rtld: explain the use of rtld_bind_lock in rtld_get_addr_slow() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 19fa964bda24a3388090418b4fbc196ad9ce2d5f Auto-Submitted: auto-generated Date: Sat, 12 Sep 2026 00:28:05 +0000 Message-Id: <6aa49c95.473b1.5eb6f857@gitrepo.freebsd.org> The branch stable/15 has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=19fa964bda24a3388090418b4fbc196ad9ce2d5f commit 19fa964bda24a3388090418b4fbc196ad9ce2d5f Author: Konstantin Belousov AuthorDate: 2026-08-30 05:20:46 +0000 Commit: Konstantin Belousov CommitDate: 2026-09-11 06:59:52 +0000 rtld: explain the use of rtld_bind_lock in rtld_get_addr_slow() (cherry picked from commit 5d9e5f49647e129bf814e7887b8201bfce8b53e3) --- libexec/rtld-elf/rtld.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libexec/rtld-elf/rtld.c b/libexec/rtld-elf/rtld.c index 864148df99ba..1cc30e27fa0e 100644 --- a/libexec/rtld-elf/rtld.c +++ b/libexec/rtld-elf/rtld.c @@ -5458,6 +5458,11 @@ unref_dag(Obj_Entry *root) /* * Common code for MD __tls_get_addr(). + * + * The tcb->tcb_dtv data structure is thread-local. The reason that + * the function needs to take the rtld_bind_lock exclusive (as opposed + * to only shared, to safely access obj_list in allocate_module_tls()) + * is to protect the rtld_malloc data. */ static void * tls_get_addr_slow(struct tcb *tcb, int index, size_t offset, bool locked)