From nobody Thu Sep 10 09:48:39 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hgXtc2mHYz6rmDT for ; Thu, 10 Sep 2026 09:48:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hgXtc0kMBz4b75 for ; Thu, 10 Sep 2026 09:48:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789033720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OaFzXy/Nvn47zcHakJnW8qip0U28UjwCLglacuRnJxA=; b=HnLyd7cg218JFDIt7FTxLZdTbiTAUcqkiMtSTkaBlbkrROLqDgMRMIshEUzWqTvcbpCrYX y0xgCNkNIHQVb8sxaBL6TTsUh62Y6Plgg/YamMq/TAHsXNpPCP6bEZUX8BW7DhQzuKl3WD xWaSaoNkshiIdsT8PIF4XIzSNqUd4dq8tLlxre8+xy1D6WwlumcYfa3nq8w3AuUHS5ZRhK clc1DfHJD8l6hbTMqXg4NGNsHIfsbYrZ/0TPsQkPr9Wva+rOqUNPbDfjBdp1yUOeO6yLW5 Brk65UFW5Lrd7s2F0UnMv44TdHzfTi3avm9YexKWgmYsX5YTe5iTYsfqbX5KgA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789033720; b=foFXXXZsvqFuiVSnDgSSp8bKsVynMM73i1qJFKM2SgEuvPb9fonyYEMiOJ7IVFs6rcROdI 9+x80Tkf84Wv/GIehb4K1lY43o0fJKGV+pT/WQz9yWp944C5puIK3xxyVvFS4U8wI3ekXd N8OrlXowHEcqliVlOvYZYLVBwt08DMyKf8PFhQg3vw6wDY1Cbr3bEOhEKB0G7QUtF+Ahku Y5b2BxnLDymDI8y1idrITIhMLEQifksLWKRtXJj7I+JIZMycB9M8GXVYxenMWMsRrCiWwL FDQ39OIK+ZkGakhTmejmxu1eHhIHlsauWCGGk1ry6sTM3/tUAmQn7URzhzw80A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789033720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OaFzXy/Nvn47zcHakJnW8qip0U28UjwCLglacuRnJxA=; b=OCQAEz/dqUkd3pUTp96gQcHEOlUSJ0Tnmijl8BIOwJzcHudjt2Od1hh/yeMduGOIZcr+Wy q7Ln+4wnNU3tGWawEA6r2eOjFD5CjUFY2U0Lei78RoMc3xwhwm/AjQZiHIf6plFSpj6rWv rUO9+s6t1es8DlJQ430OAuK7RL8fDk/UuWBE9feymo/rbfLmlOV5jTKNLaD2fNnnAohoq9 WgHepc2gmnFG4l68hJSUYy418HQVqGLO59ZNSfEX6VEfYgFFsFZxuEyfrHlioceTrCB8HM Ou2CQuVEzRfoTM7hfVVf7QfOfpUmulkr09OfTALNL8KqnzhWZviwNV+saLcy5w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hgXtb6djYzLX7 for ; Thu, 10 Sep 2026 09:48:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 261a3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 10 Sep 2026 09:48:39 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Kim Shrier From: Bjoern A. Zeeb Subject: git: d29f920d9400 - stable/15 - LinuxKPI: 802.11: add != NULL check in ieee80211_tx_status_ext() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: d29f920d94002e67232f1ebcb4e5470a076ac4f0 Auto-Submitted: auto-generated Date: Thu, 10 Sep 2026 09:48:39 +0000 Message-Id: <6aa27cf7.261a3.252fa2f2@gitrepo.freebsd.org> The branch stable/15 has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=d29f920d94002e67232f1ebcb4e5470a076ac4f0 commit d29f920d94002e67232f1ebcb4e5470a076ac4f0 Author: Kim Shrier AuthorDate: 2026-08-31 16:28:51 +0000 Commit: Bjoern A. Zeeb CommitDate: 2026-09-10 09:46:53 +0000 LinuxKPI: 802.11: add != NULL check in ieee80211_tx_status_ext() There seems to be another possible race with net80211 state machine changing the bss from under us (another lvif_bss_synched case). Just do the != NULL check to avoid a NULL pointer deref in ieee80211_ratectl_rate(). (bz extended the original comment and wrote the commit message). Sponosred by: The FreeBSD Foundation (commit) PR: 297184 (cherry picked from commit 0211e64ce1e5ba208f4b96453ce6740a49689b91) --- sys/compat/linuxkpi/common/src/linux_80211.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c index d8b5b631efd8..52897e16df9c 100644 --- a/sys/compat/linuxkpi/common/src/linux_80211.c +++ b/sys/compat/linuxkpi/common/src/linux_80211.c @@ -9122,7 +9122,15 @@ linuxkpi_ieee80211_tx_status_ext(struct ieee80211_hw *hw, IMPROVE("only update rate if needed but that requires us to get a proper rate from mo_sta_statistics"); ieee80211_ratectl_tx_complete(ni, &txs); - ieee80211_ratectl_rate(ni->ni_vap->iv_bss, NULL, 0); + /* + * A tx completion can land here after the vap has been torn + * down (iv_bss cleared on the way to INIT) while frames were + * still in flight; there is no bss node left to rate-adjust. + * This is another case of !lvif->lvif_bss_synched but checking + * that seems too cumbersome. + */ + if (ni->ni_vap->iv_bss != NULL) + ieee80211_ratectl_rate(ni->ni_vap->iv_bss, NULL, 0); #ifdef LINUXKPI_DEBUG_80211 if (linuxkpi_debug_80211 & D80211_TRACE_TX) {