From nobody Mon Sep 07 19:10:59 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hdxVq62fGz6rtLp for ; Mon, 07 Sep 2026 19:10:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hdxVq4srhz47Xy for ; Mon, 07 Sep 2026 19:10:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788808259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=urTPdxz7YVp8sg5fyVe8NJKlFiKvIeHFGNH+r4tyUFc=; b=e423s5y5EmHyphR3MpOrNe/TuTRmOlECy4/oAKRedSYUWTQQ3Fhttq6HGo7yyfOBDm6fhb qcf3zcsKLNWxIMgcnikLVkd/LzZyV9lvLjfYCPjoxbaWe2J/2woWuhfC/3NynTotMG4C2x n/C9quA9wYfX+yk3urNPGiQhV1TGQYflQ+HY3uLfkQ8Kg0hA8HhBxRNf3ri35fEOBvZY4J MEpx47BLWT2Pz5qrm4+QQ9cAwu2waIs8MdNBMkUeQBDXn6TbhFgbUWJVuP//OskFJK/emk 2mdJfF0a1BhK8uldLBGkXKBtthUw+kB7HNaGBVWKoFqJmPOYTfc7UnwMuVXmeA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788808259; a=rsa-sha256; cv=none; b=KLuPrQKVrXULmiKgH5SMpUfpjzV7j42yD4SxzyCOSt/lcRpm+ax2VpdjoonMj4FhsG0aZA sG7nagWp8w3m/MLfidxsXHc7v3c7iel7J1D9ZPYq/Jz1MSHHVLoGnYFfXKFf9Q8OezweMp 0h7vBTwnZ2glAXDMHq2c57c7CFBfCm01XuLuOsgqRv+2fIzCRrt4w0RbAdEkS5Djw/ZaC9 Wk496N4x9PeB2McUON7WtTK/eZTViWJyAsD9/cOghPAzGYUHQb3YF619SFZVSz2Z/AP8ev mUpf8ObaPd061AJDx9iD2yZ8bEBH0YrItkd1HQDP+ICS1eMvpGPX6IJgFLJIlg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788808259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=urTPdxz7YVp8sg5fyVe8NJKlFiKvIeHFGNH+r4tyUFc=; b=WVyvL8EHwb1vcnSddd0HHRzDM72FCV7wkGbZB6NI6vRzElSRcHhXC1DbyGaSLcn9jmFinI 2Cw+AHYbT/1uYGa9DL186Ey7aeFeofCwQPyNx4vkyQfs8OBIxzN9v+tArxAIxv+2PmIh0E A0DbG8vx4y+nlwds5E8jw75N6TVrMOvmaxbhPdGFv1Fzulrj7ykOvYL1t1R44G9AaeCl3p +nEryFNULU4LWHnfu/e4rwEbFAOFCh100FEg+GmdHenNFJvqhYxBDgfzekT169bMMFbs+Y 2Cp1Npsow68Qtromafiohn7fRotNaVmXpxP9DJHNISCdes8lM0mAzrq/YKn0PA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hdxVq3pv9zWtJ for ; Mon, 07 Sep 2026 19:10:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3c3d5 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 07 Sep 2026 19:10:59 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Colin Percival Subject: git: bf95db1639af - stable/15 - gstat: Set errno = 0 before strtoul List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: bf95db1639afd275a7d0c9aacde1a863ce649089 Auto-Submitted: auto-generated Date: Mon, 07 Sep 2026 19:10:59 +0000 Message-Id: <6a9f0c43.3c3d5.74ea4fb8@gitrepo.freebsd.org> The branch stable/15 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=bf95db1639afd275a7d0c9aacde1a863ce649089 commit bf95db1639afd275a7d0c9aacde1a863ce649089 Author: Colin Percival AuthorDate: 2026-08-29 20:22:15 +0000 Commit: Colin Percival CommitDate: 2026-09-07 19:10:50 +0000 gstat: Set errno = 0 before strtoul The strtoul function sets errno on error, but does not clear it on success; when using strtoul and checking errno (as one should) for ERANGE / EINVAL afterwards, it's important to zero errno first. While here, remove a dead store. Reviewed by: phk Fixes: 4fe8c1b67be0 ("Add error and range checking ... ") MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D59270 (cherry picked from commit 6ddb10cf6b7f870d749e96d2ae55976b18896f54) --- usr.sbin/gstat/gstat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/gstat/gstat.c b/usr.sbin/gstat/gstat.c index c650f7120a40..7bf5930939d5 100644 --- a/usr.sbin/gstat/gstat.c +++ b/usr.sbin/gstat/gstat.c @@ -142,7 +142,7 @@ main(int argc, char **argv) strlcpy(f_s, optarg, sizeof(f_s)); break; case 'I': - p = NULL; + errno = 0; i = strtoul(optarg, &p, 0); if (p == optarg || errno == EINVAL || errno == ERANGE) {