From nobody Mon Sep 07 08:42:42 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hdgYv0w25z6rhbJ for ; Mon, 07 Sep 2026 08:42:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hdgYt6dK1z44N8 for ; Mon, 07 Sep 2026 08:42:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788770563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0fEYhXql/6zLXDJUVNult4pvvAC/Zw+CTAhJ5hoQdUg=; b=XoDBnejtFfXjO/ZOj3trfU27tgVpPJWpnflJv+ye2amY4NSigWYoqnuzGR5jsVFmUwbCtz +5rURioaMTXx8vFWCDwI1XLPHbx+H+wfqoCyMe9SItuHecIghe6s4wOSSi23cDsVTBwpeh EtmYjEoWMWMkDgBz7H2SmlHFPo3xOrBG5/DLDYE+1su0gtFRV/Fsgha1/okPfkZb24A5Yl kZuFyHgDfSrzhX6L4WFFszXljIFyTrA41x5UWzEGukiLNZHiET1ETlCWRagTq9rgJPDAxn lnP0K+/sJ4Y44Ule/GRKXcXSbYM4U8y8ZygwubtYPqQZYI2FWnYaeUaaDW1PBw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788770563; a=rsa-sha256; cv=none; b=Jqzqo1og+4GyBI942RxcVW35/OxaGCumtWHsuwn624n432JEIcecXpHQ+63TsZLl3n6RrV rlHqwzzKBLucQVoXJQnPFy6nI2sAA20hrK1icXOTDsrrD31r0z6vNHPHdhmq0Ze/Dm7Qmf LedYUYtiqq8X059uMp1EJosc4B7cGXgcitGSg8KYTTVcNOO+16MHthBsXU8zHHBPypzzZF 2IvzAEWLhedL0hWLom45dDSMeph40ZuZ21bDOCAK4WNc7fMurvIZo0SKpyBw/KDheogKSx s7uxYFFSWLWQXb7mjdmFKUJHtzl5/7muCoTFGN2aMShNQpPPcGBgo2g1w3iJDA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788770563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0fEYhXql/6zLXDJUVNult4pvvAC/Zw+CTAhJ5hoQdUg=; b=KwdST3ugw64XUMJj53TV23vgY6fgIPeZgqSL0AVAGD99cSLoQ8cfgg+lh5iCWkBdHrBCCt BozHXVmVxZlZ2iOgPm4cHgSDQ3q4LKZNFT5H15tr7/q+jYaLW0K7kFkqVs6T0D9Z/Ct5Kp Eu7wajAzdLbQZoNbZySgEEWzhWKWWT2CpoMjBlcp3vFs6DRogMihe9FQPVBH54RNAxGNCB 7YMsyiFTwpaQfPUEDrY2OoYmBm6HkkXvZD2b/3pHPP218kATNDxZ0Qtg5ZTffJpYRuGJo2 JT2h47ZdGRfjyXvho5zIy5YFHvPgGVYUxrTvS3CbaYIx3HRJIR2O/5fOzs5NQw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hdgYt3vQ9z196F for ; Mon, 07 Sep 2026 08:42:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 40830 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 07 Sep 2026 08:42:42 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 58067171721d - stable/15 - sched_4bsd: Remove obsolete SMP scaling for ticks per priority level List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 58067171721db191139eda1e97ca2d31b4854e23 Auto-Submitted: auto-generated Date: Mon, 07 Sep 2026 08:42:42 +0000 Message-Id: <6a9e7902.40830.56dc4c66@gitrepo.freebsd.org> The branch stable/15 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=58067171721db191139eda1e97ca2d31b4854e23 commit 58067171721db191139eda1e97ca2d31b4854e23 Author: Olivier Certner AuthorDate: 2026-06-13 14:19:18 +0000 Commit: Olivier Certner CommitDate: 2026-09-07 08:41:09 +0000 sched_4bsd: Remove obsolete SMP scaling for ticks per priority level The INVERSE_ESTCPU_WEIGHT scaling had been introduced by commit b698380f33ef ("Quick fix for scaling of statclock ticks in the SMP case. ...") to leave more discrimination room for multiple CPUs possibly adding their ticks to the same 'struct ksegrp' (but also slightly changing how CPU hogs are penalized). Then, commit 8460a577a4b4 ("Make KSE a kernel option, ...") introduced the current thread-based code, where tick accounting is only done on the current thread, which renders this trick obsolete on !KSE. Finally, when KSE was removed, the trick became generally obsolete. The trick is actually even harmful because it changes the intended behavior of priorizing more the CPUs that use the less ticks (and so, impairs boosting "interactive" processes). Remove it now. Clamping of 'ts_estcpu' and its relation to the load-average-based decay may be re-examined later. Fixes: 8460a577a4b4 ("Make KSE a kernel option, ...") MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57827 (cherry picked from commit 5217b4a728dc9fd72bc844c2a6bb30a2a28119c4) --- sys/kern/sched_4bsd.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sys/kern/sched_4bsd.c b/sys/kern/sched_4bsd.c index f86dcda218a4..98c5cd8836a8 100644 --- a/sys/kern/sched_4bsd.c +++ b/sys/kern/sched_4bsd.c @@ -70,11 +70,7 @@ * INVERSE_ESTCPU_WEIGHT is only suitable for statclock() frequencies in * the range 100-256 Hz (approximately). */ -#ifdef SMP -#define INVERSE_ESTCPU_WEIGHT (8 * smp_cpus) -#else #define INVERSE_ESTCPU_WEIGHT 8 /* 1 / (priorities per estcpu level). */ -#endif #define NICE_WEIGHT 1 /* Priorities per nice level. */ #define ESTCPULIM(e) \ min((e), INVERSE_ESTCPU_WEIGHT * \