From nobody Thu Sep 03 22:46:09 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hbZT33Z9xz6qYDT for ; Thu, 03 Sep 2026 22:46:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hbZT317MXz3KH1 for ; Thu, 03 Sep 2026 22:46:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788475575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=N4x3X5hOU6PPJh9S7SQrgcbnGlW0ehdphU8vTGUEvM4=; b=QCjeCwnaGVU0iF9PNtEuR1Hc1Vxr/I9/gS+sn4nv7WccJvK08Vak40g8hiTzMY633aunWv cKDOIOAb0DgfNt5tSq6xDB4AkBqbLk6ns8F4yFM+l/OZllAq4oYzyTJ1xNZ+ANSKxCF0M5 ql/5mViP6NxYqqFnrWy3BSkSfHoKlTYewjmCDn/Zry3xutlPXfUX5Cm8HiqhkdRBAQqe19 xkIg1rWkP3JQYdQdTXz9TJ3SSX5OmxsUBHvKnK2DDShUhuDM4IZdETdswD+hJwC4HQt3Ob 08/nWhetcneEdbJKgQsWnCcZIqXvry+9wUcU7YPoY5UgbatKTwZoJIvtTzr7Jg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788475575; a=rsa-sha256; cv=none; b=nd5NMYScUtI+cI+IAzmqnlG+WwQHQPgDazCGBwgCIO4+XLzbFrxQiD4qTCtLaBu+5ICbD+ Vlszk/JCIoEk73tw759poKLax1YUlpYdz0ZOL1pyXNtW65CIeGqXEYp1JI523Ywm5ylZXT rdavC5Dj9BtxIc+N3Uc+/cu3fHNOKUjDXATWK9/jkVMC++Ro8zit2bSq1+3zWyrzd8Gdz9 Nh6FxHsywpqsYaYdmXIZM8x87WADUA2ntOkNFulAkRLX9+39BBtHi/uAMfBsjvEax2OpjG 6F9wDx9X6Wo+fzzE9X14coMR8CTUdWur04haBCpGfqwGnsWqRI17Tyowl9OUWQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788475575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=N4x3X5hOU6PPJh9S7SQrgcbnGlW0ehdphU8vTGUEvM4=; b=TtGE1Vtp1BrtDYVwLYoIugHC6FsBX6mF+AoXpT8cVhS5XGvMezkBukaRlIR5gjuAbaBmzd VrxFL9NCnYjU+V4ZFlquCNNb/aFhJqLu7y1WH/mWtTH6jZEkgLnJmkGQ2tFIjXNsp5PUmO YcvzhM+VlgXGI8RI7MvRQgpgDJPpvzW0LTG3h7btNznZtufB2FKFf5Kkz3F3COV9cFYShH eK6CPZUYexhkhHXSM8pXIcIrBvpuYsMj9R/CfoU/jzIfX969wZtMFUbxP/n8kgDlN7CcFP FB/Y0SDa5X+cgduNsrvhX+e9HSomwxOAbgvAxhlulskIS0JeUsqX7VLXLHqbqw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hbZT26zw6zYt0 for ; Thu, 03 Sep 2026 22:46:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 41a08 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 03 Sep 2026 22:46:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Mark Johnston From: Colin Percival Subject: git: 813eb5a4975a - releng/14.5 - devstat: Fix a kernel stack disclosure List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.5 X-Git-Reftype: branch X-Git-Commit: 813eb5a4975aafd2e5f5799ba4244649b35d4d5b Auto-Submitted: auto-generated Date: Thu, 03 Sep 2026 22:46:09 +0000 Message-Id: <6a99f8b1.41a08.7d705a0f@gitrepo.freebsd.org> The branch releng/14.5 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=813eb5a4975aafd2e5f5799ba4244649b35d4d5b commit 813eb5a4975aafd2e5f5799ba4244649b35d4d5b Author: Mark Johnston AuthorDate: 2026-09-01 16:07:09 +0000 Commit: Colin Percival CommitDate: 2026-09-03 22:45:57 +0000 devstat: Fix a kernel stack disclosure The 16-byte "device_name" field was not zero-filled, so could contain uninitialized stack data. Zero the whole struct, as that's the prevailing pattern for this kind of conversion code, and it's more robust in the face of future revisions to struct devstat. Approved by: re (cperciva) Reviewed by: olce, kib Reported by: Reo Shiseki Fixes: a11d132f6c62 ("devstat: Provide 32-bit compatibility") MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59309 (cherry picked from commit 7cb1a76f88158fb690418336b736e66c238cd4f7) (cherry picked from commit 6e94e0734b9d3036df8c7d94d827f8eb1119905b) --- sys/kern/subr_devstat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/kern/subr_devstat.c b/sys/kern/subr_devstat.c index 1bc37b970cbf..a421a1de2b0f 100644 --- a/sys/kern/subr_devstat.c +++ b/sys/kern/subr_devstat.c @@ -431,6 +431,7 @@ sysctl_devstat(SYSCTL_HANDLER_ARGS) struct devstat32 ds32; unsigned int i; + memset(&ds32, 0, sizeof(ds32)); CP(*nds, ds32, sequence0); CP(*nds, ds32, allocated); CP(*nds, ds32, start_count);