From nobody Wed Sep 02 22:40:48 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hZyPF4PGsz6qpSl for ; Wed, 02 Sep 2026 22:40:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hZyPF0Xhwz41gl for ; Wed, 02 Sep 2026 22:40:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788388849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QX2NxTvgrGBlGfAuhHAAPw36zkd2eeAlVvwujl1Z1g0=; b=FzYG3tkkR9yRK5JwnY85SM1fJO/PSZql3mAzwSKL205Wd96B93Co2Eklt+cW/l7q1o2fQa e1228Y/eQAquek0IG9E38yUb1NzPAQO2FTF66CdT+rNJnsGTSSpwSHb7sA0JBuN14jFytz C9bEpZNJLt31DJgrK/qy/BtB5OEVvevHFqz0OlimPb+NxRKakTVFgCvCHdskZhhOx98vph FG2tXI8FP0ZfKlV734GAyyKQmruaJjnmA6WKDJjZgqg1c+oTQtYn1Gv9xF9cpDCGmvZoQI Q+NiX5V9oHzfjfxiLv6cN94nptUnsPLKyRkQkFknEqDp7oZntRCCWpjeT9m7Qg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788388849; a=rsa-sha256; cv=none; b=BaDPPGboGWaFWLt4mIWcdF3p1QCTwH+blgGcfjSeiqn2yEByEscLbpcTOtXl1EHxAC6Wby 49aFepqoYyVkb/Y9Yj0qasy6pK2NqzTd2pN9foJ8Q64fUEaY/mERxp1qfb/FDifcwX29Ri ehtCEQ9djWF9tH61FbAcvf5YBf7Xcev1rDuSYy7a05o2DEVAOgU+DdC/OH6qIJO31Re6Pt 0tE0zH8jaCxZ8nQ5oVGQxEt9bWyK5nvsb94MQbUGBrkoLzLxF3o4zVYtzww1+9epMNl7Tn bpJ4z4TZp2bJYlLiXDKUJbUAY+Jv9BI9ANffjCgw7KpgzywWYdwE4hJ3ank+bA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788388849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QX2NxTvgrGBlGfAuhHAAPw36zkd2eeAlVvwujl1Z1g0=; b=IDIKCtkUDeLuEHBrxFH1juBl9UvEzoUEF+eZlQjP+BWWnzct+yuIs69maoqAhLNZyjwNze N6uONTbTmHEE9mpCPOxLczIhbFrLKNx+84BXxJoOwUVnCmsPJ1ljFQqUpfBYnF0YR/GOZJ kL+9Lsy84Y3g5KwUmhNzYcFZ4j03ARMCUAgpbMqj89s7M4vebRoQmNrpjT1wpZTLJhHHFc euLjypt/fhrR3hFc0MyuYkJhIdTSSiB7Bh3UgbXv9JMUSKrGec0OTv2kHXq3LHJ4X7uvRz eFKF6Nzt+2BBthF0AwOCnXbrMAqLWQdfeQ+T4ScAQsuuGtaqyJJNTVBUuGZk1w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hZyPD6G1fz12kW for ; Wed, 02 Sep 2026 22:40:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3f09e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 02 Sep 2026 22:40:48 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: abf6f5aaed28 - stable/15 - devstat: Fix a kernel stack disclosure List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: abf6f5aaed283a1cc23e5c4f6296c716c6863bce Auto-Submitted: auto-generated Date: Wed, 02 Sep 2026 22:40:48 +0000 Message-Id: <6a98a5f0.3f09e.7353f36a@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=abf6f5aaed283a1cc23e5c4f6296c716c6863bce commit abf6f5aaed283a1cc23e5c4f6296c716c6863bce Author: Mark Johnston AuthorDate: 2026-09-01 16:07:09 +0000 Commit: Mark Johnston CommitDate: 2026-09-02 17:40:37 +0000 devstat: Fix a kernel stack disclosure The 16-byte "device_name" field was not zero-filled, so could contain uninitialized stack data. Zero the whole struct, as that's the prevailing pattern for this kind of conversion code, and it's more robust in the face of future revisions to struct devstat. Reviewed by: olce, kib Reported by: Reo Shiseki Fixes: a11d132f6c62 ("devstat: Provide 32-bit compatibility") MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59309 (cherry picked from commit 7cb1a76f88158fb690418336b736e66c238cd4f7) --- sys/kern/subr_devstat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/kern/subr_devstat.c b/sys/kern/subr_devstat.c index c62df0e210e1..b0f2a5d8cbf1 100644 --- a/sys/kern/subr_devstat.c +++ b/sys/kern/subr_devstat.c @@ -430,6 +430,7 @@ sysctl_devstat(SYSCTL_HANDLER_ARGS) struct devstat32 ds32; unsigned int i; + memset(&ds32, 0, sizeof(ds32)); CP(*nds, ds32, sequence0); CP(*nds, ds32, allocated); CP(*nds, ds32, start_count);