From nobody Sat Oct 31 20:24:28 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jH8Zh4S4Jz6xFWQ for ; Sat, 31 Oct 2026 20:24:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jH8Zh1yb6z4Njm for ; Sat, 31 Oct 2026 20:24:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793478268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yEFo94S39KhgbMuPda2jiI/oJg8tkyn/pjrTpAwIiEk=; b=Vf7g0MV8fpCv4r+fDPfbQxK+lUaKo/aOS8Zqu/1nNaKM2cedG8pijPw/Wtv0kphZPLNTUv 1KZ+9I5Iawaqhtkzd2dXYyXUtvuarztlby7g1KgNUm435YhcLTmrZyCfZucukIMqLQlJtT 7mR3mQiNRKO7xUR7n1IZTIWvnPCziooUWopn/jLDGs4vke7MX1aWB/tjxpWKl34K4qg892 NceEfVWiStiK8OZw44YfzVH6VdupFOIbgsCW4wHzKxXTuZ7J93NC/3LbKVid9+gVk6KkI0 p9Prz26sTbN1iWvQaPCH1mw+50JWTwHJhtSDAJgk4bOTkMoIjw99hX3tjiY5FA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793478268; b=NncseuxFz/q4AbLMmf49R12+jVwJZ1pEnFS6y2gbFFQ8lqr7goayTBCly+D4Aof8rCFe6x um1TrNORqWm/qgxA8TM1b/V0+683jK0FCU4ZmaHPC7UHPNai7+AYQgUFK4rf2J+dBztPvA 5m3I/qyT6qk08Iq+fdicpLpMPmHem1K7dc8ZqK08mnDzHnDEiLXwD3D8mx+Qtp5s+bdvv4 GzouzHBTuC0TWETIixuHQpgs77b1fr1J37ROb+sRbEr6C0iPF7JyX0T4/GDtebP0jjVFss noC7JZPSoig2tSq/8TdkEgHYBEsOKn2YFKQQ61AgMJeYGFE+r41oHTQS911How== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793478268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yEFo94S39KhgbMuPda2jiI/oJg8tkyn/pjrTpAwIiEk=; b=Lz/sViQpr8Ay8oCfDaMx/MdL+7JYrFIJfFoKB8kr/SeBomrFm3nAjOqCz5MuPC/ZybCcVj t/WbrtM+Tefb8fLpuiDv/HpC9cIVEtMQIIOMGbcCAa05/DKLw+pIfiTZVsLe0vNu/PRQc+ zeyiYN1HRQSIfWh8hbjLq+bHrvQrlCqtfYFAq8KNuLU4dnSNYNE41Xc6n+7QqVhqyzdGmE zBfNkBn325sz7pPrTtKN5lYqczpNhta7UsLAYVY0bmLxJVibbhx6QSWAOEdzWY7TkG0Rle 5N5/Z41jRIPxIRQNc9zG4EBKg6ZTLjnRj3T3aEb6UrBbvDmnHzHok0fc4zJ+aw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jH8Zh1dR0zQvT for ; Sat, 31 Oct 2026 20:24:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 33a7f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 31 Oct 2026 20:24:28 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Christos Longros From: Adrian Chadd Subject: git: 01e4d2be3859 - stable/15 - rge: log silicon revision during attach List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 01e4d2be385945ea8a32fc058b0867f1cadfa2f0 Auto-Submitted: auto-generated Date: Sat, 31 Oct 2026 20:24:28 +0000 Message-Id: <6ae64e7c.33a7f.2b6eb404@gitrepo.freebsd.org> The branch stable/15 has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=01e4d2be385945ea8a32fc058b0867f1cadfa2f0 commit 01e4d2be385945ea8a32fc058b0867f1cadfa2f0 Author: Christos Longros AuthorDate: 2026-02-22 18:06:50 +0000 Commit: Adrian Chadd CommitDate: 2026-10-31 20:15:04 +0000 rge: log silicon revision during attach The initial import from OpenBSD contained chip revision printf() calls commented out, as OpenBSD's bare printf() style does not translate to FreeBSD's device_printf() idiom. The result is that users cannot distinguish RTL8125 from RTL8125B, RTL8125D_1, RTL8125D_2 etc. via dmesg alone, even though all variants show as '' from the PCI probe string. Add proper device_printf() calls including the raw hwrev value, consistent with how re(4) reports chip revisions. Signed-off-by: Christos Longros Reviewed by: zlei, imp, adrian Differential Revision: https://reviews.freebsd.org/D55402 (cherry picked from commit acbf7498f5e11b00ffcd6c12bdb8bd1eddeb6d7f) --- sys/dev/rge/if_rge.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sys/dev/rge/if_rge.c b/sys/dev/rge/if_rge.c index dfa6cd1325e5..b2f1311b4c87 100644 --- a/sys/dev/rge/if_rge.c +++ b/sys/dev/rge/if_rge.c @@ -413,31 +413,31 @@ rge_attach(device_t dev) switch (hwrev) { case 0x60900000: sc->rge_type = MAC_R25; -// device_printf(dev, "RTL8125\n"); + device_printf(dev, "chip rev: RTL8125 (0x%08x)\n", hwrev); break; case 0x64100000: sc->rge_type = MAC_R25B; -// device_printf(dev, "RTL8125B\n"); + device_printf(dev, "chip rev: RTL8125B (0x%08x)\n", hwrev); break; case 0x64900000: sc->rge_type = MAC_R26_1; -// device_printf(dev, "RTL8126_1\n"); + device_printf(dev, "chip rev: RTL8126_1 (0x%08x)\n", hwrev); break; case 0x64a00000: sc->rge_type = MAC_R26_2; -// device_printf(dev, "RTL8126_2\n"); + device_printf(dev, "chip rev: RTL8126_2 (0x%08x)\n", hwrev); break; case 0x68800000: sc->rge_type = MAC_R25D_1; -// device_printf(dev, "RTL8125D_1\n"); + device_printf(dev, "chip rev: RTL8125D_1 (0x%08x)\n", hwrev); break; case 0x68900000: sc->rge_type = MAC_R25D_2; -// device_printf(dev, "RTL8125D_2\n"); + device_printf(dev, "chip rev: RTL8125D_2 (0x%08x)\n", hwrev); break; case 0x6c900000: sc->rge_type = MAC_R27; -// device_printf(dev, "RTL8127\n"); + device_printf(dev, "chip rev: RTL8127 (0x%08x)\n", hwrev); break; default: RGE_PRINT_ERROR(sc, "unknown version 0x%08x\n", hwrev);