From nobody Fri Oct 30 17:27:53 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jGSjP4Bchz6xFDg for ; Fri, 30 Oct 2026 17:27:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jGSjP1vW4z4Tyb for ; Fri, 30 Oct 2026 17:27:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793381273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KaqVCet1YsaygZU+LpxaGXEF821/aJRrG35JzELx+Fo=; b=cYx0aLEwhMpeXC+K3GC2vz8tJL+jWUei0qRNeMJfz19YZwodS74osnbOv+AVR0T7b0fp80 3qRXh8vNZaHQMsC0E8MdH5EZPYWPgx+SnRWlPk3boGcpZ36jRdwZffSv8+S2KWEB8wwIEd lB2vM1YhwWZbOjaH7h7adLYeo+7W2ojXJYjBjfh+kvEGqlH9lw+r++YE9gdL0v1b33Va6W zmL6RwnypFuEH5PFoXGWRp+BdgLrR4VRCk1zTmZV3XYBRkwtrLAKa7wHQ46lqGjbpakY4C p5xBnCIsi/n5/jlnP/uAdKtlNc1GnCmdR4y301G6KIu8HoB6NdbONpLgPQd9fw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793381273; b=s8SEksg80rPkwxbupP3XjF078UgzbNI/FiIdOBA3woAJ+UWT7LyR9CJRveifVDUtjobqdR iZ4wg3JquNKwMydy7As/S98JVr0Igha7PCK6+KXJNRqYZ3AILd9EzEX/sLyDfQuc9Cv/1F YLeoYlw4wt7H/eS4OswPImiA+CG+htVx524Pji7IBMOuE2NSQTaBbNmSUwF3+WU9t/+XaE c7FOKm75Bem/vHe7eBE4cC7ug6zUfPPUJCORjoWy3TRTgS2MiVa/fwWpfDHSaw7HrgVwFq thYSqwdJf3MdL4CjYP8QHZRYvTzWJMz1ulGCAb9Fg2LkBIDirhVhI5/hcbcKSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793381273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KaqVCet1YsaygZU+LpxaGXEF821/aJRrG35JzELx+Fo=; b=NA9+Uf7Mt2jxoz+QCzUlmDRONSWyYpmba8LbNLJ5KJNa9rairFNgMe/REWc8cWUXC0dRam QR3lSFFJ9Cq9fazkM0+mi8bjWhGtRuVtisxifrNpl+p38Cxes6hgOFss0t/LBpXnnB5ort l3zfmzr/bfdJzS6dN3hib18zuCnL+Fm1L3wxIrqVngxv7b20crbFVQgt0sOdlUVesFGzto e/7weAJEPrmHMmbq9+enNU+UQiXq6lVpUE53MQaa8fqDXjDyEty4n2sDCr8GWqhm17tfvs luCBoeMk4ohymI0fSLT1y2WihUP9QG/PnVlxzA/xDLEiC3u/cD7DGxPi6S+OwQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jGSjP1GVxzcVn for ; Fri, 30 Oct 2026 17:27:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3f193 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 30 Oct 2026 17:27:53 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Nick Price From: Kevin Bowling Subject: git: 349012757a04 - stable/15 - bxe(4): don't feed a zero page size to ilog2 during ILT init List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 349012757a0410f35b1326ef5ad1949cf4fc68d6 Auto-Submitted: auto-generated Date: Fri, 30 Oct 2026 17:27:53 +0000 Message-Id: <6ae4d399.3f193.49473504@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=349012757a0410f35b1326ef5ad1949cf4fc68d6 commit 349012757a0410f35b1326ef5ad1949cf4fc68d6 Author: Nick Price AuthorDate: 2026-08-31 23:16:12 +0000 Commit: Kevin Bowling CommitDate: 2026-10-30 17:27:39 +0000 bxe(4): don't feed a zero page size to ilog2 during ILT init FreeBSD's bxe hardwires CNIC_SUPPORT() to 0, so bxe_ilt_set_info() never enters the block that initializes the SRC and TM ILT clients. Those two clients are left zeroed (page_size 0, flags 0), yet ecore_ilt_init_page_size() calls ecore_ilt_init_client_psz() for all four clients unconditionally. For SRC and TM that evaluates ILOG2(page_size >> 12), i.e. ilog2(0). On an INVARIANTS kernel ilog2() asserts "ilog argument must be nonzero" and panics the machine the first time the interface is brought up (bxe_init -> bxe_nic_load -> bxe_init_hw -> ecore_ilt_init_page_size). On a non-INVARIANTS kernel it silently programs a bogus page-size register instead. Restore the else branch that upstream Linux bnx2x carries: when CNIC is not supported, mark the SRC and TM clients with ILT_CLIENT_SKIP_INIT and ILT_CLIENT_SKIP_MEM so ecore_ilt_init_client_psz() skips them. Root-caused from a crash dump on a BCM57810 (device 0x168e): the ILT clients showed CDU and QM populated and SRC and TM zeroed with no skip flag set. Reviewed by: adrian Approved by: adrian (mentor) Differential Revision: https://reviews.freebsd.org/D58587 Signed-off-by: Nick Price (cherry picked from commit 742c5498aca9a9a31a68eb9d5888edf36b7034dd) --- sys/dev/bxe/bxe.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sys/dev/bxe/bxe.c b/sys/dev/bxe/bxe.c index 02d317775231..acc65ee1458a 100644 --- a/sys/dev/bxe/bxe.c +++ b/sys/dev/bxe/bxe.c @@ -5900,6 +5900,11 @@ bxe_ilt_set_info(struct bxe_softc *sc) ilt_client->start, ilt_client->end, ilt_client->page_size, ilt_client->flags, ilog2(ilt_client->page_size >> 12)); + } else { + ilt->clients[ILT_CLIENT_SRC].flags = + (ILT_CLIENT_SKIP_INIT | ILT_CLIENT_SKIP_MEM); + ilt->clients[ILT_CLIENT_TM].flags = + (ILT_CLIENT_SKIP_INIT | ILT_CLIENT_SKIP_MEM); } KASSERT((line <= ILT_MAX_LINES), ("Invalid number of ILT lines!"));