From nobody Thu Oct 29 23:37:13 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jG0y23p8rz6xr6d for ; Thu, 29 Oct 2026 23:37:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jG0y20JLXz4snb for ; Thu, 29 Oct 2026 23:37:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793317034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eK73+PRrCzb/QRkwSrwh4QbLoCWGdQmHNXJmb8xmQlw=; b=IbeapKcdhx49mlbER4rHNP75TjR2IkTkofrpWsTqx+xcjhZzRAEx+1sB0KiWemuxXndPSU gd5Pa6wb+Ojc7/2LNP0YIDhAwrjve5VqhzWA5NpVALryQNlf3fSL/mgVFjFFMqGoHV6IlH GzHzU2qH5EO2MgV/wi3ZP4TfRyNGkIkNqpBamaYLnuz4Mlt/UlhiJiUSQbwQdBfyYd5V+X xahcCRR0+Atq8CdlpBwDD9B4uXMa2qNxZizI6Zauf6ifHx5rtJ6kx7WxFt7tpzbjA2phSX kqtPtRm1zNYdhv/kkzkzTHiR8KzvZZUc2rjiSxlmxGfcweRpJZsCk/dDJ7NmXA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793317034; b=Bi/dnBZo/LZBQRfncbz5rfgpHholuKRoYIHZjeiCpQgFyrFTmiD9FOpxf+dETTJlPC8Lwo cgLoB8nhbmTnjvBxObmnCJj5luUrdbprQE0Kn5n/M2zdljjcsq6/a9TUfrb6OcgDnuFInO mAPR3josCksu0uqcScy5d8NQKTVr7VCAl8opXwXsxzz+AYVOFB0dUPrvvTI0P87CTgJMWs Krrj2KCCNuSKFqKH/5nEW3iYMtpUKpyBykpusINta2H6vFUb1o0BBJSbEP0pp67qUwtO4R 7ewHvKf1MJvojZKSP5LSLUMciWGaRUXbkAEtstMQCg8yNHA0soDV3ovSMUOmTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793317034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eK73+PRrCzb/QRkwSrwh4QbLoCWGdQmHNXJmb8xmQlw=; b=B80QRReIchmOvXi+vRk1hZr5xrqpiapQhSqQsV4TxVKJNyqSgWj5LPjaeerFhDmF3OzdJk lYVt4ZWGaPv00pi2QI1adLerCxNje0WdtXFumMPux6eoCAMZQQwP90IClaksD1RPuY0sbN HBifIM1yQL876lC+Y+8JP9NBQf098xhUJJVW9djEV0FWfzS0ffSLWWs9uZ5A7Ds+hSdSR5 q2t4KBRJEUKdCDZP+Nnou/6vLz1urRcDUJsoMSS0HraF7iX7wlhIzqwBCPeJlMViWEAnlS YnEKRYBjK+hZoFl+CnFpCJmsS5PVEHrICAdV3KcfUeg/QJ0Y4gQBtWFG7x3Hfw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jG0y16c5Nz11xR for ; Thu, 29 Oct 2026 23:37:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3c326 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 23:37:13 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Sumit Saxena From: Kevin Bowling Subject: git: cbda5351914d - stable/15 - if_bnxt: Never ARM Tx CQ as they are not interrupt-driven List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: cbda5351914dabe40a8cc51008e168f398037b3e Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 23:37:13 +0000 Message-Id: <6ae3d8a9.3c326.4c595@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=cbda5351914dabe40a8cc51008e168f398037b3e commit cbda5351914dabe40a8cc51008e168f398037b3e Author: Sumit Saxena AuthorDate: 2026-07-31 16:04:34 +0000 Commit: Kevin Bowling CommitDate: 2026-10-29 23:15:19 +0000 if_bnxt: Never ARM Tx CQ as they are not interrupt-driven Tx completion rings are not interrupt-driven, so there is no need to ring the doorbell with CQ_ARMALL and toggle bits set for them. Stop arming the Tx CQ doorbell on P5+, which makes tx_cp_rings[]->toggle dead, so drop the now-unnecessary toggle bookkeeping for it in process_nq() too. Reviewed by: gallatin Sponsored by: Broadcom Inc. Differential Revision: https://reviews.freebsd.org/D58616 (cherry picked from commit 7781529f31b62a3071995b9f0446b8ded4ec8cf9) --- sys/dev/bnxt/bnxt_en/if_bnxt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/dev/bnxt/bnxt_en/if_bnxt.c b/sys/dev/bnxt/bnxt_en/if_bnxt.c index b55af66b4aef..3a6fe887f7ca 100644 --- a/sys/dev/bnxt/bnxt_en/if_bnxt.c +++ b/sys/dev/bnxt/bnxt_en/if_bnxt.c @@ -3503,7 +3503,7 @@ skip_def_cp_ring: goto fail; if (BNXT_CHIP_P5_PLUS(softc)) - softc->db_ops.bnxt_db_tx_cq(&softc->tx_cp_rings[i], 1); + softc->db_ops.bnxt_db_tx_cq(&softc->tx_cp_rings[i], 0); /* Allocate the TX ring */ rc = bnxt_hwrm_ring_alloc(softc, @@ -4136,7 +4136,6 @@ process_nq(struct bnxt_softc *softc, uint16_t nqid) { struct bnxt_cp_ring *cpr = &softc->nq_rings[nqid]; nq_cn_t *cmp = (nq_cn_t *) cpr->ring.vaddr; - struct bnxt_cp_ring *tx_cpr = &softc->tx_cp_rings[nqid]; struct bnxt_cp_ring *rx_cpr = &softc->rx_cp_rings[nqid]; bool v_bit = cpr->v_bit; uint32_t cons = cpr->cons; @@ -4154,7 +4153,6 @@ process_nq(struct bnxt_softc *softc, uint16_t nqid) if (NQE_CN_TYPE(nq_type) != NQ_CN_TYPE_CQ_NOTIFICATION) { bnxt_process_async_msg(cpr, (tx_cmpl_t *)&cmp[cons]); } else { - tx_cpr->toggle = NQE_CN_TOGGLE(cmp[cons].type); rx_cpr->toggle = NQE_CN_TOGGLE(cmp[cons].type); rx_cqe = true; }