From nobody Thu Oct 29 23:37:10 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jG0xz0qCdz6xqrv for ; Thu, 29 Oct 2026 23:37:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jG0xy5KrMz4sn5 for ; Thu, 29 Oct 2026 23:37:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793317030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=smkPDjv85u2VvPefFoehtVtDjS+K3kavZCBCrzbLyoU=; b=kyqIR2ezM+HRZb34v/BKDF/mJGzEX3inM+BGvXv/JDwmDpO9OL9Og707mhE0P5C5NUs0zW 2nTQhOeMCruUjzuxlTKpGbpnZpnHJgRRbFf4jxaKxBhutf3Gz3hQo7r7zS7R+RLhBxg4y6 OIO134wIDzzjX9MbV7M0TxMrmzL9ZKkCxWKMBKbzgZMx9fjbJGdj6XhwC1+yrAn0cN4FYB wMv/q1hFZUMCbz3iunAk/oHdgl2C5cBDb8kDIFVUE1sky5yqarCLKmhHlV1JlbdxlL47fj KdxJMvq/jNOuGKkP5NLLm44Fb2e2+ldzQS05dCPKs9X6otNOWJIhBcAnFQQq3A== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793317030; b=YM6I5WkC/vLl6/uazr+tJkOtOwegc3U3re3RgiUmnqW0/5CfcXcbFM5xzenJVG5zXBXvl0 QqSsZCdOGvQEBdie9hDkUKvsaniae7Wyhv4vOEt68Z3aQdgZbBQOg7M0EnsLyjoVok5UU7 2sUjMI95GEtQSnP6cGSVTrvQAYNQtm/A48sc2EfLF2yX+8ym007SFrcKbpkN0PQZuKa/ze jNXGYnE5M6fSIye2KZykjM2aiRFBSik2syeN5b/Vhb5o10cOfBcfOruXbdTvGkbUkFq2Jf lySKoFMYWBrXjeIiRJv36unzPlwFqooNzte7a8z1kIJoSCJ9/5HcRK1wgG1uvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793317030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=smkPDjv85u2VvPefFoehtVtDjS+K3kavZCBCrzbLyoU=; b=tA2jXGoP8YZ8FYidSxmdGQOBJcY+wWAYBe98ypDr6EyDi3jBtsGcHc6JjeNQB7iAeHKwya kp2kPCsXGLx6ohXl3+lHzPZhQS53g5I7xpuHGqA+4QmJvClP0Dqrf7Z+H2Y9cQQDmBWZft Buqt+aJUsPvFabtJtg1GpJ0pvMY8NnRESqffJBFl1tFcYZZSWbJAwxnYQbCVLDzua6qnTb O92kfWbLWXDri7DvsPc54Dna/4y7OdKu/0aL75bhDKGIPIrZx3O61zisoRsZ5mF/tjE5Rd QhluyMW81oNf/q2S9GFf9u8Du8D1xirBm5WvKALahdB5enj7phAsVexUynhqzg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jG0xy4ZTHz11xP for ; Thu, 29 Oct 2026 23:37:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3c3c9 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 23:37:10 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Sumit Saxena From: Kevin Bowling Subject: git: cc68c479d4d3 - stable/15 - if_bnxt: Collect hw stats every 250 milliseconds List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: cc68c479d4d3569328b693de3a10120b46732066 Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 23:37:10 +0000 Message-Id: <6ae3d8a6.3c3c9.4eaac0ce@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=cc68c479d4d3569328b693de3a10120b46732066 commit cc68c479d4d3569328b693de3a10120b46732066 Author: Sumit Saxena AuthorDate: 2026-07-31 15:49:32 +0000 Commit: Kevin Bowling CommitDate: 2026-10-29 23:15:19 +0000 if_bnxt: Collect hw stats every 250 milliseconds bnxt_if_timer() only scheduled bnxt_update_admin_status(), which polls HW stats, once per second. Drop the interval to 250ms so stats collection is timely. Reviewed by: gallatin Sponsored by: Broadcom Inc. Differential Revision: https://reviews.freebsd.org/D58610 (cherry picked from commit 492bd0db44bace9475e15dfebdc17076b536533f) --- sys/dev/bnxt/bnxt_en/if_bnxt.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sys/dev/bnxt/bnxt_en/if_bnxt.c b/sys/dev/bnxt/bnxt_en/if_bnxt.c index 21befd82938d..9cab563b1c71 100644 --- a/sys/dev/bnxt/bnxt_en/if_bnxt.c +++ b/sys/dev/bnxt/bnxt_en/if_bnxt.c @@ -4007,6 +4007,10 @@ bnxt_update_admin_status(if_ctx_t ctx) return; } +/* Poll interval for bnxt_update_admin_status(); not sysctl-tunable, unlike + * other driver intervals. */ +#define BNXT_ADMIN_POLL_TICKS (hz / 4) /* 250ms */ + static void bnxt_if_timer(if_ctx_t ctx, uint16_t qid) { @@ -4014,8 +4018,7 @@ bnxt_if_timer(if_ctx_t ctx, uint16_t qid) struct bnxt_softc *softc = iflib_get_softc(ctx); uint64_t ticks_now = ticks; - /* Schedule bnxt_update_admin_status() once per sec */ - if (ticks_now - softc->admin_ticks >= hz) { + if (ticks_now - softc->admin_ticks >= BNXT_ADMIN_POLL_TICKS) { softc->admin_ticks = ticks_now; iflib_admin_intr_deferred(ctx); }