From nobody Thu Oct 29 20:30:25 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFwpT4J6Dz6xcBT for ; Thu, 29 Oct 2026 20:30:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFwpT2vT0z4Q2W for ; Thu, 29 Oct 2026 20:30:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793305825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OY2zKofL823/1R28HA2f0pbgY7O6R10hlGNI5W/Sf8c=; b=JBL1i4Hs1Ti64wPEtOufRqYJxLWmDYgiE1ffnsOXeu9PeeChMnzYYDXxi6+OjhhzzcAtaa mfC6swhhRIzp4vfB/TMUhUFefmHDf0mbZeOFjvyWRZk/h7fQEXS5r0jrUzMvMc7d/stE6n PMaQl6/lLhMV/kNpOLGLOy664AHnxm2J3K+OHn02xtls7BTUn1AvdfnvpBTEA+982lAUmq jMdmHV5PwgtelROCE9Eh6X7d5c9ZDIg5u/UqLQ4p//PmxaXuL1oXUpS/s5Lipc6l5toQeg PByqWK/upViI/Pez4tN+rGHxsVA7ny1S94Ky3wFX28PQ7Bfv7wq+tIyIBRW+eg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793305825; b=lvMuYNbJ8KrTfib4dUcfr/mgL+QxQ1rDoJw+j/OR6l8+YJ5BpK9jGvtBqJ81xXjIV4K7Wn 0wU3rsA95y5tKPs3WQ2acmqNeD+kgILpLorIpeMlAekVZ66g5AFNXOjlQQtj3X+1Qu9ZuY 4Zd/GtHkE7do+lqjxp0Mh7LyihUvcVMWnUpB5kBYRmz0J5JZu8/psVvt3+ydwbxiIkPn9G LxrO6aQMIhtZbWMsCySds0xB8LLTl7T+ditifbp8J79V+4sI8FL9pSEeWTac/U7Wlvp/R3 n7h/vn658Z2rt0arlMDFxey4D7J+gwd+z4xDeWgHaW7mMSVN87ogAke4S+lTYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793305825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OY2zKofL823/1R28HA2f0pbgY7O6R10hlGNI5W/Sf8c=; b=aroPSGwdY6NBAXgcuB0a9HsTpq3s29nOWXZsaSCDfx47CIzgISVR2AN2S6zG1D1YK9bF3T UxLbiOCAOMw0IIb0mLAm8s2kCFngbwznxNLZugKRkRyZtzsjeBc3kSsoKujc4QGNgHef1l RIFE5rqJt5kkGSa6pcbmrDaCtSFcG1/vHAZknPM0sCQFozKxBVUr/um9CWb7CM/+EsVixZ geRYdHpNrR3Ny+bnRlC+UUewE1ZqFa0Xgrm+RBYYa6DueLLPUxiw74ctDQWfv7dnO1wI/3 K4og6NoBEPrey+ohouZGpkUEA/41gPAy8ZrRV8oDXS6InDz6wibeWWn8FGliCg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFwpT1pPXzw4l for ; Thu, 29 Oct 2026 20:30:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 20691 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 20:30:25 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Ryan Moeller From: Kevin Bowling Subject: git: 1b92ab5dc0dc - stable/15 - lib/libifconfig: Fix pointer-sign warnings List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 1b92ab5dc0dc728edd9694af0ddba813b7057810 Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 20:30:25 +0000 Message-Id: <6ae3ace1.20691.321cfa7a@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=1b92ab5dc0dc728edd9694af0ddba813b7057810 commit 1b92ab5dc0dc728edd9694af0ddba813b7057810 Author: Ryan Moeller AuthorDate: 2025-09-18 15:04:35 +0000 Commit: Kevin Bowling CommitDate: 2026-10-29 20:25:20 +0000 lib/libifconfig: Fix pointer-sign warnings Fix all pointer-sign warnings generated when compiling libifconfig. One of these warnings comes from the misuse of snl_add_msg_attr_string for a byte array. Though userland treats carpr_key as a string, it is actually an array of bytes. Handle it as such in libifconfig. While here, fix a small consistency nit in ifconfig_sfp_get_sfp_dump. Signed-off-by: Ryan Moeller Reviewed by: imp, zlei Pull Request: https://github.com/freebsd/freebsd-src/pull/1850 (cherry picked from commit 20cd1b475a1ef9dfca30726999aa1b9a02d5bc39) --- lib/libifconfig/libifconfig_carp.c | 5 +++-- lib/libifconfig/libifconfig_sfp.c | 10 +++++----- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/lib/libifconfig/libifconfig_carp.c b/lib/libifconfig/libifconfig_carp.c index 59faa8def496..8599470cd3f9 100644 --- a/lib/libifconfig/libifconfig_carp.c +++ b/lib/libifconfig/libifconfig_carp.c @@ -53,7 +53,7 @@ static struct snl_attr_parser ap_carp_get[] = { { .type = CARP_NL_STATE, .off = _OUT(carpr_state), .cb = snl_attr_get_uint32 }, { .type = CARP_NL_ADVBASE, .off = _OUT(carpr_advbase), .cb = snl_attr_get_int32 }, { .type = CARP_NL_ADVSKEW, .off = _OUT(carpr_advskew), .cb = snl_attr_get_int32 }, - { .type = CARP_NL_KEY, .off = _OUT(carpr_key), .cb = snl_attr_copy_string, .arg_u32 = CARP_KEY_LEN }, + { .type = CARP_NL_KEY, .off = _OUT(carpr_key), .cb = snl_attr_get_bytes, .arg_u32 = CARP_KEY_LEN }, { .type = CARP_NL_ADDR, .off = _OUT(carpr_addr), .cb = snl_attr_get_in_addr }, { .type = CARP_NL_ADDR6, .off = _OUT(carpr_addr6), .cb = snl_attr_get_in6_addr }, { .type = CARP_NL_VERSION, .off = _OUT(carpr_version), .cb = snl_attr_get_uint8 }, @@ -177,7 +177,8 @@ ifconfig_carp_set_info(ifconfig_handle_t *h, const char *name, &carpr->carpr_addr); snl_add_msg_attr(&nw, CARP_NL_ADDR6, sizeof(carpr->carpr_addr6), &carpr->carpr_addr6); - snl_add_msg_attr_string(&nw, CARP_NL_KEY, carpr->carpr_key); + snl_add_msg_attr(&nw, CARP_NL_KEY, sizeof(carpr->carpr_key), + carpr->carpr_key); snl_add_msg_attr_u8(&nw, CARP_NL_VERSION, carpr->carpr_version); snl_add_msg_attr_u8(&nw, CARP_NL_VRRP_PRIORITY, carpr->carpr_vrrp_prio); snl_add_msg_attr_u16(&nw, CARP_NL_VRRP_ADV_INTER, carpr->carpr_vrrp_adv_inter); diff --git a/lib/libifconfig/libifconfig_sfp.c b/lib/libifconfig/libifconfig_sfp.c index 8deccda5ff76..a2cddf89a13a 100644 --- a/lib/libifconfig/libifconfig_sfp.c +++ b/lib/libifconfig/libifconfig_sfp.c @@ -298,7 +298,7 @@ ifconfig_sfp_get_sfp_info(ifconfig_handle_t *h, const char *name, struct ifconfig_sfp_info *sfp) { struct i2c_info ii; - char buf[8]; + uint8_t buf[8]; memset(sfp, 0, sizeof(*sfp)); @@ -365,7 +365,7 @@ ifconfig_sfp_channel_count(const struct ifconfig_sfp_info *sfp) static void get_sff_string(struct i2c_info *ii, uint8_t addr, uint8_t off, char *dst) { - read_i2c(ii, addr, off, SFF_VENDOR_STRING_SIZE, dst); + read_i2c(ii, addr, off, SFF_VENDOR_STRING_SIZE, (uint8_t *)dst); dst += SFF_VENDOR_STRING_SIZE; do { *dst-- = '\0'; } while (*dst == 0x20); } @@ -373,7 +373,7 @@ get_sff_string(struct i2c_info *ii, uint8_t addr, uint8_t off, char *dst) static void get_sff_date(struct i2c_info *ii, uint8_t addr, uint8_t off, char *dst) { - char buf[SFF_VENDOR_DATE_SIZE]; + uint8_t buf[SFF_VENDOR_DATE_SIZE]; read_i2c(ii, addr, off, SFF_VENDOR_DATE_SIZE, buf); sprintf(dst, "20%c%c-%c%c-%c%c", buf[0], buf[1], buf[2], buf[3], @@ -532,7 +532,7 @@ get_sfp_status(struct i2c_info *ii, struct ifconfig_sfp_status *ss) uint8_t diag_type, flags; /* Read diagnostic monitoring type */ - read_i2c(ii, SFF_8472_BASE, SFF_8472_DIAG_TYPE, 1, (caddr_t)&diag_type); + read_i2c(ii, SFF_8472_BASE, SFF_8472_DIAG_TYPE, 1, &diag_type); if (ii->error != 0) return (-1); @@ -773,7 +773,7 @@ ifconfig_sfp_get_sfp_dump(ifconfig_handle_t *h, const char *name, struct i2c_info ii; uint8_t *buf = dump->data; - memset(dump->data, 0, sizeof(dump->data)); + memset(buf, 0, sizeof(dump->data)); if (i2c_info_init(&ii, h, name) != 0) return (-1);