From nobody Thu Oct 29 07:41:29 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFblG1PwGz6wGBW for ; Thu, 29 Oct 2026 07:41:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFblF6Cqkz4S90 for ; Thu, 29 Oct 2026 07:41:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793259689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wSqgyqyxkkbpfo1dGJdOSzqNTRqpmecDbD9EH5yJVa4=; b=gFziaXLI/aSUe6JJU4L6gm4FEI8VucU6hoUR+siN5U3ODAaW/+nPnbJrICmPR/zDEFjULw ZXPujvkEDL/43JsGRNqaq9K6URkdnxFxL1I8m7zXxADRC0aV5alLVyP/954YOerJ8h97Kq w05oYx27Xu/M/RiUSn5T2vP074n1fZFZwRSsaptszGZHXX5W+yAm0K2GN+kV3YwBFfFVod 4aWrxEU0VWx2QXeE7LfuRvPJlBcI2gtsbhBjn2cYXEa6BAXienSgMEODxiZNvrGlWPuVRV dcUCs5P3VVAOjxbLdfHmeBqyP94UBuM7hVvnYw9Ifcx/r324AcO+lf/ymaU3fw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793259689; b=B/KXbEgACwbQo8q2f2ogkdw/MEKXroXhaLC4f7GgnXE/xSZXWr4yVLFca0P0YR5idR1fGF eBS+/bLIV03vWhVJYgeAlRanftpzmJy6lLrfXxJ2AH61DoJqUBeZxSjShbadtZYi30wbPV TWfbImhesccQwUzU17MFSFYbhoLCXa8X5iD3z+xvaRKf7z7pjjNL3S8j+ADX91MVk1MTQv MM0NUXpGYAzEDfzSiae4A8VEaaG6Og8VXrsNLb22KcCVhnC9C476Ei7s+pLqiSRO+La9YR xKMORTTfYlDr60I9cHDQFS1sZMn2QDcmdicsmF9kloWqyOhdnYu7kXGlRQGouA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793259689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wSqgyqyxkkbpfo1dGJdOSzqNTRqpmecDbD9EH5yJVa4=; b=my/ipi5CtUE/pS57tQ74xjrdnXCU5UJMKcSE0t9QnwRt1FCsyRxU1tMSWAJe5P/WiOL9Cj OJ+OB3MFERc4s82bV16kva3I7fsDzf+n83x81B0iV140/briJP8ZEBAUAiuCRjlSpCsEnO 8d1wd52CPjvhMQ+UkED6oaKEHUwbE6mDk/EXqRWLeYUlq+AYHsrI68RxiLokQHHWBc5yIQ RqKNkrEAAoW9z15SxW2VIiyJpMsmtXDrT8XQvw8BVlEPrjeOQqnOr4kJTgSz1ssd9vYl48 BbIR5Teokz/EOVXd95n0KWJ9WYA7xqzeOHiumh7tMz/Ql3XZQl6hs09Xw1pSMA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFblF5qmyzVCq for ; Thu, 29 Oct 2026 07:41:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 44e98 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 07:41:29 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Gleb Smirnoff From: Kevin Bowling Subject: git: 403586d88a5f - stable/15 - tcp: don't set flowid in tcp_input() List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 403586d88a5f86deb1c5e65f620fd70a70aefc72 Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 07:41:29 +0000 Message-Id: <6ae2f8a9.44e98.73bf15b7@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=403586d88a5f86deb1c5e65f620fd70a70aefc72 commit 403586d88a5f86deb1c5e65f620fd70a70aefc72 Author: Gleb Smirnoff AuthorDate: 2025-12-03 23:15:45 +0000 Commit: Kevin Bowling CommitDate: 2026-10-29 07:37:58 +0000 tcp: don't set flowid in tcp_input() With dd0e6bb996dc setting it always on connect(2) and syncache always picking up the flowid from the incoming packet, any ESTABLISHED connection shall have the flowid already set. Reviewed by: tuexen, gallatin Differential Revision: https://reviews.freebsd.org/D53886 (cherry picked from commit ee18f8be21655c2d98c1c1bd4e081c366fa91c9a) --- sys/netinet/tcp_input.c | 31 ------------------------------- 1 file changed, 31 deletions(-) diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c index 01f82108c5fe..ea032550dfed 100644 --- a/sys/netinet/tcp_input.c +++ b/sys/netinet/tcp_input.c @@ -921,37 +921,6 @@ findpcb: } INP_LOCK_ASSERT(inp); - if ((inp->inp_flowtype == M_HASHTYPE_NONE) && - !SOLISTENING(inp->inp_socket)) { - if (M_HASHTYPE_GET(m) != M_HASHTYPE_NONE) { - inp->inp_flowid = m->m_pkthdr.flowid; - inp->inp_flowtype = M_HASHTYPE_GET(m); -#ifdef RSS - } else { - /* assign flowid by software RSS hash */ -#ifdef INET6 - if (isipv6) { - rss_proto_software_hash_v6(&inp->in6p_faddr, - &inp->in6p_laddr, - inp->inp_fport, - inp->inp_lport, - IPPROTO_TCP, - &inp->inp_flowid, - &inp->inp_flowtype); - } else -#endif /* INET6 */ - { - rss_proto_software_hash_v4(inp->inp_faddr, - inp->inp_laddr, - inp->inp_fport, - inp->inp_lport, - IPPROTO_TCP, - &inp->inp_flowid, - &inp->inp_flowtype); - } -#endif /* RSS */ - } - } #if defined(IPSEC) || defined(IPSEC_SUPPORT) #ifdef INET6 if (isipv6 && IPSEC_ENABLED(ipv6) &&