From nobody Thu Oct 29 06:43:19 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFZS73f22z6xvFL for ; Thu, 29 Oct 2026 06:43:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFZS72DrTz3P1S for ; Thu, 29 Oct 2026 06:43:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793256199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xzhnez6YnmRP8MRz/sOUd3ZfFRZmgogCULLS0irqtVc=; b=iqAqYlHOLNL2AwmR1ck1ID0p2gIUDEI0Aj0laCd19q+Fjw0bLpxXh2ILqYjlhXFoFzdoS9 kBCAhVQmKQCUSR005fwZgJPbMf3tTMtTkNK8W/m9fgOGIF2t//QdNOoiayU2LN74d5+SYv 6hfF3L/I11qLU95wJMD0FwsdUQ8xthlYo8qk8p0xyKi5tGhU0wAOfB4MevxTB/veWfTiyL 11VFp7Y2lYxMNztrHl1Wf4VLblsm2UpZ6tzUUtuCELqUly6fAIx9fu/evtE5dbg990NrJk u2hV6u6/MfGJI9BqZAXnD7ZH+gkH8xK6yWFhCPyq1Q57E/D2AqmaFzO+D27ibg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793256199; b=AXbIGtgQiyG6oyVmn0+Gq7FanRMibJGrNmjr1pmldOAGe0Jkj0R+zc97p3s/OdW2JRtCXr P73fJQlK+6Mr3USKza+68YHU5zhTXjd6ca8CT7nO6TFviRfgIUKOHevwBxEZC/9Wn04snP ofhmaji18Xng/MrnTiCNRYv0/ZMUSZ/MN1rZJJx7OipLlFFps3jGipASqUs7N+oJSHm0Ba /NOIvYq5L5BNu21QXKTQgjxjY7j8DkKYcQAmdTe+LdIPWsit446Wr6CBwK9Cn2R9dOdEEr rQGJoxysTeb04pk+seftYDbecXXR6NA7NJC8e37StsP0T4NEfhDXBuf3eUQPgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793256199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xzhnez6YnmRP8MRz/sOUd3ZfFRZmgogCULLS0irqtVc=; b=QLj+JrQr278bCDosnTe9gyJV04esd8JFGUAjzXB6IRfX3zrOqOALWbCCGp8FdbQNlNdAqH ELvoVLWO+W8eiiUXJUM6Ndls49RYippu6yix9f/1i08dzNaEljUQBr+caVZYbyNuQWh2LK Xkbj9bK1PRRgTdBc+AD8JKlvZknHVhLPQrk4diy3CWaHmz8d5RLsnk3Lu/4Pp0U0JL1efE IS5iMOfERR0O2Z2P6czIVs0A3eTz+rH6hM/I1tAdDBB/AKOiG5H53wb6Lh6uKTOilsen3V mqjZF4GJqc6v/VHkNl8M9uyppwBV7qryBqheLJAnWI55yrZC05jHw0SRXpSMxA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFZS70csFzS52 for ; Thu, 29 Oct 2026 06:43:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3eab1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 06:43:19 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 900df88c5072 - stable/15 - iavf: Reschedule pending virtchnl replies after the processing budget List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 900df88c5072a74a0aefe2c04ebbffeb8c5b1608 Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 06:43:19 +0000 Message-Id: <6ae2eb07.3eab1.31eb8b35@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=900df88c5072a74a0aefe2c04ebbffeb8c5b1608 commit 900df88c5072a74a0aefe2c04ebbffeb8c5b1608 Author: Kevin Bowling AuthorDate: 2026-09-18 11:51:55 +0000 Commit: Kevin Bowling CommitDate: 2026-10-29 06:42:02 +0000 iavf: Reschedule pending virtchnl replies after the processing budget The VC worker ignores the pending count returned by iavf_process_adminq. If a pass exhausts its message budget, replies can remain in the receive ring without another interrupt to schedule the worker. During init, the iflib admin task cannot provide a backstop because init holds the context lock while waiting for ENABLE_QUEUES to complete. Reschedule the VC worker after a successful pass with messages remaining. Keep the per-pass budget and do not retry AdminQ errors. Stop self-rescheduling once detach clears INITIALIZED; the existing polling and reset-recovery gates continue to exclude asynchronous processing. Validation: reproduced the timeout on a three queue E835 VF under Hyper-V. Temporary tracing showed a successful ENABLE_QUEUES reply already in the guest receive ring after a three-message pass left two messages pending. With the fix and no tracing, a GENERIC kernel with WITNESS and INVARIANTS passed three batches of 30 down/up and MTU 1500/9000 cycles without enable/disable timeouts. Sponsored by: BBOX.io (cherry picked from commit 3c52d24acb422f5d80f50612bd990ce760a19de8) --- sys/dev/iavf/if_iavf_iflib.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/sys/dev/iavf/if_iavf_iflib.c b/sys/dev/iavf/if_iavf_iflib.c index 0838eabbec1f..f0d1f39ee20c 100644 --- a/sys/dev/iavf/if_iavf_iflib.c +++ b/sys/dev/iavf/if_iavf_iflib.c @@ -434,9 +434,19 @@ static void iavf_vc_task(void *arg, int pending __unused) { struct iavf_sc *sc = (struct iavf_sc *)arg; - u16 var; + enum iavf_status status; + u16 remaining = 0; - iavf_process_adminq(sc, &var); + status = iavf_process_adminq(sc, &remaining); + /* + * A budget-limited pass may leave replies without another interrupt. + * Keep processing them here: init can hold the iflib context lock + * while waiting for a reply, preventing the iflib admin task from + * making progress. Do not perpetuate the task during detach. + */ + if (status == IAVF_SUCCESS && remaining != 0 && + iavf_test_state(&sc->state, IAVF_STATE_INITIALIZED)) + taskqueue_enqueue(sc->vc_tq, &sc->vc_task); } /**