From nobody Thu Oct 29 06:40:08 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFZNS2zC8z6xtrB for ; Thu, 29 Oct 2026 06:40:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFZNS17pBz3Jf8 for ; Thu, 29 Oct 2026 06:40:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793256008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mRhPPXqcUdjCjl5L5jP6KQyIsY2Rmu3pLvnfEWeg3X0=; b=NbvdfFdB0J1j6LGiA3k4GIxzTkp+x/EJtypalxaimTC11RmWFHxApik1xuor6iFVtBMYJy 2RIBKOLuZVPAVwcoRcUVt/os4dyoImIbdu+hRXMhO4MX4Scx6D3jr8J+qnc3nZfCcXXtna Xc3CX0mm8dDGllfQndJEFnB6We7dSPx3QvxOgYRLtYPFNE4uvBmjS3GMfRyg35ivd9TxLq Ky8vZQQJ5h7xPy5vIoDUPmDgz47OnTlDif8IqFSfP5IDYsJobCP1ZicWMr2NweiRdebSHW ni8YEGXGt6/rq27S2Wh+4Gn3+Hkg5U2VbRVGJueaif29c/f9odFqb4dEsB50/g== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793256008; b=NX3DuOtFpFYJHmHYFl5aE6o/Y4TehA8sqfFDVc0FGifevdZtJLDHYQAt+edvzYKodg5eAX gcz50b2WydYDaK0Eq5Pb9WRzfHiG6l8vDgSH369THVOj8568iVFrBEvQtwB/P44AQJSkno yqbksrwSeTWD/AaimyGW6d++8kL7ldw0RYrugBxKU59X8n+bjfrrM1dLp3NNNSUYzynZjq LQfr+Hah7Qk8SVUERHPFQYedu6LBcZOy26bx0rWOQg8PKL+p0AVNkogK2RrhFddYrmQEID EXpDcOaj4v5IikQsTiRtg+FQaVOFpn5TdXZ1ztt//Pe8lC+7WB8Q0GD/tcoMtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793256008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mRhPPXqcUdjCjl5L5jP6KQyIsY2Rmu3pLvnfEWeg3X0=; b=k7izITLSAtYNzqrNsH2jfbZyn92QVIP7z+TnwFsVsnpUrMsChih4rSXNqT41MwUw2PegVp f7ROdIukVTdNX+IH59yrKJQst519UZgOCg9dlSSRBorr2far5DXCMzhKbdwaq2CL/lqsrt 96syxjmlvnj4p3aLgPebzY0DVr5r/r0hGXwbyOuTBJ8FUT5fGtVHG1lGHGokca6ViJ9JxT C572W4A3Y5JIlNpQwPv5O5LEoZ2y91W1JQctBveM6KmpDj7apfPlv0tnBy1HS7hUDSVML1 unrPknaJaefLjoDG/50/KSVpGSOuBwFoX+7JvKMBgfeAWDiBOo9Zw+0q0bYMAg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFZNS0p3SzS0X for ; Thu, 29 Oct 2026 06:40:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3e790 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 06:40:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: cc9ebb4b425b - stable/15 - ice: Report VF queue enable failures as hardware errors List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: cc9ebb4b425b3282059462f77c0768ce71198f84 Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 06:40:08 +0000 Message-Id: <6ae2ea48.3e790.4264f009@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=cc9ebb4b425b3282059462f77c0768ce71198f84 commit cc9ebb4b425b3282059462f77c0768ce71198f84 Author: Kevin Bowling AuthorDate: 2026-09-17 06:53:41 +0000 Commit: Kevin Bowling CommitDate: 2026-10-29 06:39:04 +0000 ice: Report VF queue enable failures as hardware errors The ENABLE_QUEUES handler has already validated the queue selection before attempting to enable Rx hardware. A timeout or unexpected queue state is an operation failure, not an invalid virtchnl parameter. Return VIRTCHNL_STATUS_ERR_ADMIN_QUEUE_ERROR for these failures, matching the disable path. Keep ERR_PARAM for invalid requests and attempts to enable unconfigured queues. Preserve the recorded state of queues which were enabled before a later queue failed. Sponsored by: BBOX.io (cherry picked from commit d38e0889d20eed3885a020993b72dc9855148ba3) --- sys/dev/ice/ice_iov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/ice/ice_iov.c b/sys/dev/ice/ice_iov.c index 0278d10abd36..0d53f8f14253 100644 --- a/sys/dev/ice/ice_iov.c +++ b/sys/dev/ice/ice_iov.c @@ -1530,7 +1530,7 @@ ice_vc_enable_queues_msg(struct ice_softc *sc, struct ice_vf *vf, u8 *msg_buf) device_printf(sc->dev, "Unable to enable VF-%d Rx queue %d: %s\n", vf->vf_num, bit, ice_err_str(error)); - v_status = VIRTCHNL_STATUS_ERR_PARAM; + v_status = VIRTCHNL_STATUS_ERR_ADMIN_QUEUE_ERROR; goto done; } vf->rxq_enabled |= BIT(bit);