From nobody Thu Oct 29 06:38:18 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFZLL2k9Jz6xtfR for ; Thu, 29 Oct 2026 06:38:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFZLL1Qxgz3FYm for ; Thu, 29 Oct 2026 06:38:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793255898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Uy5aCCofeaRf/DpnyYr1okHK9XTz1a6eI+OlK3urr/s=; b=HSoHqKcqLUauZTzH3fs3tMVLyZlCWtzC+nqPMRMvwGEkUlxwPs1qMgOl1T+X1hC2EGIreZ FYgmXrJtDwOVEfmRT9KQxaPL7/KxFMOZPU+NnujmwH/4Y5zc6fRlZQrQW7bWjBNBA3seGb ezwgvmqaeNA27/Z/TTzoCsZ3DosSdWwafgxMUFvvz4TPfbU6EvUk/Aw0BbVqqFqtx4SVDK LYzn6Ba0uQUZK44DJW97s4X71rpS0k2x6Wcv0DKrSYHXa7tXScg/zT+q+3mhv5UPScLz7A FFbccpj+AkX3pls0kWKz/6FHADx0Gt6Exd6pPT9D7FGNxQ52o2DhnJjxX32T+g== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793255898; b=MHtHxQIDvumwV2AZToKjniDTnW7F0hSBg9wbkP34/Uf7Tgh9ANSWjWKvt6kBWpUngIPgc4 RVbDHXJkn/O2jTlb55/CWp7I0DFpjuMfBPeVlLuygkaskbGFVyrSXJn32wVQXdPW6S+AJ1 j3X441u44yRll02i8ZbMvFYXCz7+pu1xKETdqDuyukLEWDOAaOg+GrvI4y0zlHV2Q9la+l X75wfuE+wiHDd5mwHIFcsLvp7qXx69ntW9RkDYudvKjpB4elKe6HByB+K4MP0+ySF/haYt R64SgOe9SLkmlPxUyLgZvR12uVMY9WUlDeDNH1JPhnTeuqz+gxUTrg6bYeJUQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793255898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Uy5aCCofeaRf/DpnyYr1okHK9XTz1a6eI+OlK3urr/s=; b=xl2DFjXFf9SBzSN8xoCe2B6TYXztu+6+fMovrmHQhXOsjuHx4cNOEZ0m61/b4X2RBdOqyt 0+36/K682oXunsUqLTAv5Z5/h5KfV1Z9W6F968V+YkAbpSomH2QfJVlvRcA509v0RoE9mN DBLUAJ9PWqluWJwq4Tgufw84/wwBFuL6V2VcQ/gAU7N3VUJMvkrD6h7ioCYaIDs7og9V0p 936ukjUthrovIYIRUzzM4AXlN8xPnBDYENtj7/0pFbyX5GLg4tXacUB0ity0SEFChMLr68 JKEn+mZ7eksVMtDslNkcFHpgP+CKf9zLpOQ4QTept5OZ3C87PCiOJcq9wmSdGw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFZLL12JYzRmL for ; Thu, 29 Oct 2026 06:38:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3baf1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 06:38:18 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: f4213419dc89 - stable/15 - enetc: Correct transmit queue timeout detection List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: f4213419dc89d69d178461d351561d6a781db4c2 Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 06:38:18 +0000 Message-Id: <6ae2e9da.3baf1.56050d1c@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=f4213419dc89d69d178461d351561d6a781db4c2 commit f4213419dc89d69d178461d351561d6a781db4c2 Author: Kevin Bowling AuthorDate: 2026-09-07 13:44:59 +0000 Commit: Kevin Bowling CommitDate: 2026-10-29 06:38:08 +0000 enetc: Correct transmit queue timeout detection Test the producer and consumer indices after waiting for transmit completion. The post-decrement loop leaves timeout at -1 on exhaustion, so testing timeout == 0 missed the actual timeout and could report one when the final poll completed successfully. Leave the hardware shutdown sequence unchanged. This only corrects the diagnostic; runtime FLR recovery and command-buffer lifetime handling remain separate work. Sponsored by: BBOX.io (cherry picked from commit 9a1756f831a77ee8292821c9efd38c2125bff88c) --- sys/dev/enetc/if_enetc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/enetc/if_enetc.c b/sys/dev/enetc/if_enetc.c index 55fec66266fe..81e59dc10559 100644 --- a/sys/dev/enetc/if_enetc.c +++ b/sys/dev/enetc/if_enetc.c @@ -972,7 +972,7 @@ enetc_disable_txq(struct enetc_softc *sc, int qid) cidx = ENETC_TXQ_RD4(sc, qid, ENETC_TBCIR); } - if (timeout == 0) + if (pidx != cidx) device_printf(sc->dev, "Timeout while waiting for txq%d to stop transmitting packets\n", qid);