From nobody Thu Oct 29 06:37:34 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFZKW1s8Nz6xtvq for ; Thu, 29 Oct 2026 06:37:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFZKV69SRz3DgY for ; Thu, 29 Oct 2026 06:37:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793255854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=givGXgfSbKFSTix/77jwmYGngjQZwpBHCs89OEb8eMU=; b=RUcguFaBev1kjJ7rY/UFUjtmXxwvAXcaHZXc3yFkscsoyshywO9t2F3+oaLaPIrn951q3P HYKRQCiCHvzYcliQ8hb5faxh5flPzlxIaZR1LEJ41fLkrMjie9R2EflHFBcUbcXi17rZ+z EI3FZBzTUXmph3mt5bQ52rQaDLgeR54jlRhn627ft3k+bBLZr4/eQ2usJFemIt9Cs5i4Ji mkIXg8r6UH3notxt8cjnp+iDOdW9BXAIorDJKim8O/ac41WoKWE7aZFm7ALLYJZVWNXTji J/ESgKEt7r+Cp+pcfTbX1WAIUaSUu8FUFZouiBZENVCB9vs2vzR3MY9oGlUYfw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793255854; b=nmgnEbYlouB8XPyYUiviBU9usjQnW4h/HAjvDFJzJtjTbdnXmfYDud7DmFcWFMK8Y3QbF/ x3a46F/h0j38WNfkCLxZXQsMBmHaZTlWMPnwarY11PwtL5ILDLuFMXBjBftqnQ3ESYsfr7 /MT912xowEmuUZ5hOhCBfZWzoT/2jlBghrBOvhNiIo8ZtSFU/irdMYOJy6FXFOV1SNluPG vYa36YU7Zc2U/4i+Qhkv3AmRUVG/iTon5y/9rznSpg7GiY+GV2E0EYmbopy2kyhKJ5Z8sc +MbCkOwtlnRg171J2sqFPcNMqvPfhONlasoA0bh4sWrU/AKoKchTrZc68vaFJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793255854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=givGXgfSbKFSTix/77jwmYGngjQZwpBHCs89OEb8eMU=; b=MH+xpOshZkmuFbmQjoiydOzEetBqizC0cAGT9J1EXJ3wvBkFg4Ow53OJ1ZSxnEpb76nt/b av49hhezYkNrEJ4V8fSO1KEE1GNam6Mq5zzga3wFOhPk/ZJ2AkDa5RTIuij7TlUpYS9mBm PCaoeDP99M4Z2v0qhn9tBUhytWb7SczSNpSSSFd84FIr3dP6Vp/XcoVNT4WhK+lAoN1YBr FWf64+VtrtB6IXKF0ORrpypbapd3TJOtadYMPlnr2D1po1IqAybSWLR/qvdYCz4aFMbUvj 9+BUKjbkq7NY5lpN9WslQTiOrJ6v8J1qhtW4DTn5nts1yBiCJRLp89wc5a/3Mw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFZKV4pKmzRpr for ; Thu, 29 Oct 2026 06:37:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3e389 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 06:37:34 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 44bf730761ff - stable/15 - ixl: Tie statistics baselines to hardware resource epochs List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 44bf730761ff4e7f2f9851e880c076c822d8b85e Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 06:37:34 +0000 Message-Id: <6ae2e9ae.3e389.689d62a6@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=44bf730761ff4e7f2f9851e880c076c822d8b85e commit 44bf730761ff4e7f2f9851e880c076c822d8b85e Author: Kevin Bowling AuthorDate: 2026-09-03 10:58:30 +0000 Commit: Kevin Bowling CommitDate: 2026-10-29 06:37:25 +0000 ixl: Tie statistics baselines to hardware resource epochs Raw VSI statistics belong to the firmware-assigned counter index and are reset when firmware recreates the VSI. Reusing a baseline across either event makes a counter decrease look like a full width rollover. Reset the PF and main VSI baselines when rebuilding hardware resources. Start a new baseline when firmware assigns a different PF counter index and whenever it allocates a VF VSI. Ordinary interface reinits which retain the hardware resources continue to retain their statistics. This follows the lifecycle used by ice without placing an unconditional statistics reset in ixl_initialize_vsi(), which also runs during ordinary iflib initialization. Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59337 (cherry picked from commit 444168adbe5217ea9b73773e42c60bf75fb7a6fd) --- sys/dev/ixl/ixl_pf_iflib.c | 11 ++++++++++- sys/dev/ixl/ixl_pf_iov.c | 2 ++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/sys/dev/ixl/ixl_pf_iflib.c b/sys/dev/ixl/ixl_pf_iflib.c index 2791ad769f67..b6283855e794 100644 --- a/sys/dev/ixl/ixl_pf_iflib.c +++ b/sys/dev/ixl/ixl_pf_iflib.c @@ -502,7 +502,13 @@ ixl_initialize_vsi(struct ixl_vsi *vsi) ctxt.info.queueing_opt_flags |= I40E_AQ_VSI_QUE_OPT_TCP_ENA; } #endif - /* Save VSI number and info for use later */ + /* + * Save the VSI number and info for later. A changed counter index + * begins a new statistics epoch. + */ + if (vsi->stat_offsets_loaded && + vsi->info.stat_counter_idx != ctxt.info.stat_counter_idx) + ixl_vsi_reset_stats(vsi); vsi->vsi_num = ctxt.vsi_number; bcopy(&ctxt.info, &vsi->info, sizeof(vsi->info)); @@ -1032,6 +1038,9 @@ ixl_rebuild_hw_structs_after_reset(struct ixl_pf *pf, bool is_up) error = EIO; goto ixl_rebuild_hw_structs_after_reset_err; } + /* Firmware has rebuilt the port and VSI counter resources. */ + ixl_pf_reset_stats(pf); + ixl_vsi_reset_stats(vsi); error = i40e_aq_set_phy_int_mask(hw, IXL_DEFAULT_PHY_INT_MASK, NULL); diff --git a/sys/dev/ixl/ixl_pf_iov.c b/sys/dev/ixl/ixl_pf_iov.c index 20432770a064..bdc02f1f11ce 100644 --- a/sys/dev/ixl/ixl_pf_iov.c +++ b/sys/dev/ixl/ixl_pf_iov.c @@ -210,6 +210,8 @@ ixl_vf_alloc_vsi(struct ixl_pf *pf, struct ixl_vf *vf) } memcpy(&vf->vsi.info, &vsi_ctx.info, sizeof(vf->vsi.info)); + /* A newly allocated hardware VSI starts a new statistics epoch. */ + ixl_vsi_reset_stats(&vf->vsi); return (0); fail: