From nobody Thu Oct 29 06:36:22 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFZJ64QHlz6xthT for ; Thu, 29 Oct 2026 06:36:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFZJ621m7z598S for ; Thu, 29 Oct 2026 06:36:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793255782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ee66x5z/9pIFJS6y0ezdiyXZJaJ6e4jQmSWO07F2dms=; b=vrBkQqlVD3K9J+uUQ/iHX+bq1nhnmPB8cu0NKuqO4hG++GHxMaVO9cw09gVSxyjJHCCCbx oDLrtoxqCh6b9f4MKOXflJmLkbL1zbgVUbAU7N+tByeqA6nKaar2gpBLptNChhmBu1YfQr qZ9FrIvI30uWDv/Q81CnmrkvlBkto8UAL7YQ1jzMiVb9Cte1OLZen2f3ImUoQXNUS2x+ZA HBlf8i3WMlLwNDysVZWLGPiaz/s+Bxmmo68s8sd3Jbv7bTqGTaYTovC6fO2hgFIEA2Mw/i 0ZOlZ0533aFc6F52uy1KaiDHQtQPpqV1nEoPQw8lf6TxlETrcYH0z9viqUEufw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793255782; b=i4a8StAnpbt6Stq1NrxwMjlFOjb2kJTAD3Hmx7uYaCgY9cWbOX9JGTBOg4wvyE75FN3OAJ amcXvJ8tC1SqDoTCpjct1/vZxthfxNz07TK19NFhrivuzerUPUmZBww62J9m9dvABSb1uP xU5thGswGDOuR1qPkg6MFgIHd4aNtxw7KGP/arcpscbXim9MvD3YHbpFadA1IVso1JDs+B ZQyQYF/wNzSL75rUjMogfOBbQm+X08j+CxcLvnzk1isM36wHsrMNPpOwrORAO4HYViP+BJ EKeqNHg8PtPRnrNfWLzJMTeCzRJlDT9DqpJvnKsCVuyvULVUf4gR9Bj6dAPqNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793255782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ee66x5z/9pIFJS6y0ezdiyXZJaJ6e4jQmSWO07F2dms=; b=iHvRpdB/fehTLVUX2aurIqvT6I5VaBD6qiDakOHfOztVqejRu6HM9pMHq7sGht/xXaRs3A BZWY1OrYoCRCzZBijknJxooi3jU6dPYW2WvW3QOuYSI8Vr+O9bSSPvGrQoAd+Dw0ARMTpD nLZ0oOLHt4R3kH9YKKdokrfBsEAGIknCS5kDWsTvNbCMKDW3yQyClFo2FRI7Vp0QoXzyN3 fiun173TvhcnHUsP9pCcsyOfRhXzvjp5wDT0HbM4QKyJ4iZ2IT98I332ZKemT/hbRjYMvj cWGfiEmmp0pa7zN28lKztA0UcVPMgdFvjnyY+IovALvBxXOe5vbTan3u9Ol7sA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFZJ61XnyzRkj for ; Thu, 29 Oct 2026 06:36:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3da90 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 06:36:22 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: bf9f511e8563 - stable/15 - ice: Honor iflib transmit completion batching List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: bf9f511e8563f1ecf95a91ec3a162365857002f0 Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 06:36:22 +0000 Message-Id: <6ae2e966.3da90.46b2120a@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=bf9f511e8563f1ecf95a91ec3a162365857002f0 commit bf9f511e8563f1ecf95a91ec3a162365857002f0 Author: Kevin Bowling AuthorDate: 2026-08-18 11:04:33 +0000 Commit: Kevin Bowling CommitDate: 2026-10-29 06:36:13 +0000 ice: Honor iflib transmit completion batching ice marked every transmitted packet RS and recorded every last descriptor in its report-status queue. Hardware therefore wrote descriptor status for every packet, and the driver traversed every packet while reclaiming completed descriptors. iflib marks selected packets with IPI_TX_INTR as completion checkpoints. It forces a checkpoint as deferred work or ring pressure grows. Retain EOP on every packet, but set RS and record the descriptor only at those checkpoints. DPDK uses the same sparse-RS design and defaults tx_rs_thresh to 32. Let iflib choose the adaptive interval for FreeBSD. This reduces PCIe and memory traffic while preserving bounded descriptor reclamation. Validated on an E810-XXV in an A-B-A test with five matched four-stream, TSO-disabled transmit runs per phase. Median throughput was 9.413, 9.413, and 9.414 Gbps. Median whole-system CPU was 21.54%, 17.75%, and 21.62%, respectively. The candidate used less system CPU than both exact-baseline phases in every pair. Interrupt rate was unchanged, no transmit watchdog fired, and normal TSO traffic remained line-rate. DTrace confirmed that only iflib-selected packet-final descriptors carried RS after the change. The effect should be more profound at 200Gbps but my DUT is network limited. Reviewed by: gallatin Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D58910 (cherry picked from commit 99191ce8044dd82d317ec62efea35bf5369cd592) --- sys/dev/ice/ice_iflib_txrx.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/sys/dev/ice/ice_iflib_txrx.c b/sys/dev/ice/ice_iflib_txrx.c index a090717e7c5e..1c89b85ef4b1 100644 --- a/sys/dev/ice/ice_iflib_txrx.c +++ b/sys/dev/ice/ice_iflib_txrx.c @@ -138,10 +138,14 @@ _ice_ift_txd_encap(struct ice_tx_queue *txq, if_pkt_info_t pi) bus_dma_segment_t *segs = pi->ipi_segs; struct ice_tx_desc *txd = NULL; int i, j, mask, pidx_last; - u32 cmd, off; + u32 cmd, off, tx_intr, txd_cmd; cmd = off = 0; i = pi->ipi_pidx; + tx_intr = pi->ipi_flags & IPI_TX_INTR; + txd_cmd = ICE_TX_DESC_CMD_EOP; + if (tx_intr) + txd_cmd |= ICE_TX_DESC_CMD_RS; /* Set up the TSO/CSUM offload */ if (pi->ipi_csum_flags & ICE_CSUM_OFFLOAD) { @@ -177,14 +181,15 @@ _ice_ift_txd_encap(struct ice_tx_queue *txq, if_pkt_info_t pi) } /* Set the last descriptor for report */ -#define ICE_TXD_CMD (ICE_TX_DESC_CMD_EOP | ICE_TX_DESC_CMD_RS) txd->cmd_type_offset_bsz |= - htole64(((u64)ICE_TXD_CMD << ICE_TXD_QW1_CMD_S)); + htole64((u64)txd_cmd << ICE_TXD_QW1_CMD_S); - /* Add to report status array */ - txq->tx_rsq[txq->tx_rs_pidx] = pidx_last; - txq->tx_rs_pidx = (txq->tx_rs_pidx+1) & mask; - MPASS(txq->tx_rs_pidx != txq->tx_rs_cidx); + /* Add to report status array if requesting descriptor writeback. */ + if (tx_intr) { + txq->tx_rsq[txq->tx_rs_pidx] = pidx_last; + txq->tx_rs_pidx = (txq->tx_rs_pidx+1) & mask; + MPASS(txq->tx_rs_pidx != txq->tx_rs_cidx); + } pi->ipi_new_pidx = i;