From nobody Thu Oct 29 06:35:05 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFZGf3XJKz6xtHt for ; Thu, 29 Oct 2026 06:35:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFZGf0vsjz573y for ; Thu, 29 Oct 2026 06:35:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793255706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p4z8Xwfy9+O5K8isGkdmjojxjocpe4/T4TnKtKlXASI=; b=vvz2l+CS8ZkA9pnD8QhAXzlFemjQptqItLhNWt0PsnJj+/nLXBmDM0jJBOTWLRLMkepwcz KH7Jv62AQlyQqO7ddovXoJHq7Z5HiScSiuor1OgDRC5FggVXxvVHVJDD3asfm39LPYYTen IXY6MudBN39547lPn3jNj+NDWyJMha1ebWnHWDgZzWGFbqc22qv2rMK1jh/92H0Ayoype2 jJTq6fdAkKhgIz3zVdiAnxXWayY7PWfohwmw/3BeH1W5TyG2obc0qpB8C0objIe1/Ltfe/ ThU9BvRg7XqxUzHc2SLSqv8hQ6aMcl8lA57XKEblelzL005YYytKJ9gjBRDrEg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793255706; b=G0dKIf/wLmBlP+b1roHy8eRdgecHym5eKpNtpt9eAAxLfPdk9dWOA4PGLv7H0e39boh+/s 0TOQ1wUh2jNZbgskrkKSLHxjm/CVTXR+GYCKRHN9qJ5rWyPRzMMPENfzBkAJfJZDGs7FoT 0mgqn10N67tmpGXKESdqY52sL9RK4ybo51YMl6CfaIRUQjXkhfCgTvBqv+GrHSjAXKd8E0 +kInvLYEhSHIEvoHb9vGrNKHw+gHCPLa+3yXG+raiNSHI2Dp2JWVoI92WGQSLwwLmg0eKW hRy24uGCUs1zwmEDzWF8S3WUUd8gHmV0RJVTp00bj3js5RfM7eL2JY+tiFVyHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793255706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p4z8Xwfy9+O5K8isGkdmjojxjocpe4/T4TnKtKlXASI=; b=yhHmSwWG2tw5XpFMuFZSLRfO9Gtdih1wN5M4VBnwd+5EEOeNPOSWROsZIZeCZdxgEOY5eJ ACzoBbd4LUEoBgiB0JcxRcC2m98G7RRFdEJYkKKA8BULmfjlfQIqwq8qfjKAFnPAbR+g9M e2hAQpvKe9k2A/0nLDCxF22MQOa8IzLh6lMlQlYYIPoQKNtWnSeecGvrUNBLP/T4Pu142k kaXHScj70yR29kWTjHEfhaEyG/8LtTJy/unLB/5Hct5P2VJ4ZrLxxBm5TNAg4SHhT32Aqe dthZ/VkVwDt57KGXu5YSxsWOSyh3HAq+IVvC1qo1ZmfXRY1WRaLw2t4671aQGQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFZGd72x0zRWG for ; Thu, 29 Oct 2026 06:35:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3e383 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 06:35:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Andrew Gallatin From: Kevin Bowling Subject: git: 0677e65308d2 - stable/15 - ixl: use newly exposed RSS hash key API rather than ad-hoc hashing List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 0677e65308d2387ea15df865234b14527d0b7042 Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 06:35:05 +0000 Message-Id: <6ae2e919.3e383.1d852c3d@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=0677e65308d2387ea15df865234b14527d0b7042 commit 0677e65308d2387ea15df865234b14527d0b7042 Author: Andrew Gallatin AuthorDate: 2025-11-22 14:29:32 +0000 Commit: Kevin Bowling CommitDate: 2026-10-29 06:19:24 +0000 ixl: use newly exposed RSS hash key API rather than ad-hoc hashing Differential Revision: https://reviews.freebsd.org/D53094 Sponsored by: Netflix (cherry picked from commit dd615b57df62e2fa858569d66164dcd1ef840c94) --- sys/dev/ixl/ixl.h | 2 -- sys/dev/ixl/ixl_pf_main.c | 15 ++------------- 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/sys/dev/ixl/ixl.h b/sys/dev/ixl/ixl.h index ab0f38307d90..e265c8fbe3eb 100644 --- a/sys/dev/ixl/ixl.h +++ b/sys/dev/ixl/ixl.h @@ -98,10 +98,8 @@ #include #include -#ifdef RSS #include #include -#endif #include "ifdi_if.h" #include "i40e_type.h" diff --git a/sys/dev/ixl/ixl_pf_main.c b/sys/dev/ixl/ixl_pf_main.c index df3bb989b6a0..cfbe88d08173 100644 --- a/sys/dev/ixl/ixl_pf_main.c +++ b/sys/dev/ixl/ixl_pf_main.c @@ -1102,12 +1102,8 @@ ixl_set_rss_key(struct ixl_pf *pf) u32 rss_seed[IXL_RSS_KEY_SIZE_REG]; enum i40e_status_code status; -#ifdef RSS - /* Fetch the configured RSS key */ - rss_getkey((uint8_t *) &rss_seed); -#else - ixl_get_default_rss_key(rss_seed); -#endif + /* Fetch the configured RSS key */ + rss_getkey((uint8_t *) &rss_seed); /* Fill out hash function seed */ if (hw->mac.type == I40E_MAC_X722) { struct i40e_aqc_get_set_rss_key_data key_data; @@ -1133,7 +1129,6 @@ ixl_set_rss_pctypes(struct ixl_pf *pf) struct i40e_hw *hw = &pf->hw; u64 set_hena = 0, hena; -#ifdef RSS u32 rss_hash_config; rss_hash_config = rss_gethashconfig(); @@ -1151,12 +1146,6 @@ ixl_set_rss_pctypes(struct ixl_pf *pf) set_hena |= ((u64)1 << I40E_FILTER_PCTYPE_NONF_IPV6_TCP); if (rss_hash_config & RSS_HASHTYPE_RSS_UDP_IPV6) set_hena |= ((u64)1 << I40E_FILTER_PCTYPE_NONF_IPV6_UDP); -#else - if (hw->mac.type == I40E_MAC_X722) - set_hena = IXL_DEFAULT_RSS_HENA_X722; - else - set_hena = IXL_DEFAULT_RSS_HENA_XL710; -#endif hena = (u64)i40e_read_rx_ctl(hw, I40E_PFQF_HENA(0)) | ((u64)i40e_read_rx_ctl(hw, I40E_PFQF_HENA(1)) << 32); hena |= set_hena;