From nobody Thu Oct 29 06:35:07 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFZGg28Cfz6xtG0 for ; Thu, 29 Oct 2026 06:35:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFZGg0v94z57R0 for ; Thu, 29 Oct 2026 06:35:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793255707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WBj/oZE7Bt+e3YwKZOxLHxvV3gbNaUNwYqDX/4yG+Hc=; b=E6ewh6mLjSwizC9Rz/fNhY0Movf6J/NOaL4ZUy9GZi4xuia2vFPCN4yOXOTB3BFDYZ1hjw 3sWy86IMaLfoL01tA3yB3gDhN7Ki9J0mtzGXFPKnMR9ZGwSAA2FK7MbHG0bsBFiBniA4Wn YUPpMLE0cB9O0XLkLZqNLE8uJBY7EVx1Az3dVAN2f48laeaGB/aJdqI200CTNg4dGt6Dxz 30aqtNOC5UHUFhFV2v5XzVKkVXTV/rqnhK5c3oN4pKtyPaLXcesDO3nQIzDEqw8BVFaQL7 Sv4/OXgaMSDWgklSvidfXDu8Q8Q12gCBOtDWjoimPZu3jFChf8O4DB94apcuYA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793255707; b=eDE+WDHQ9YcPpgl0INHCSxSqPhjNkSvw+tKlAfioeMtF0Ksqg8qGXnoVyPcLkaEmSUd+sw m0B6yJR9V+3eDmNBvIfN56r39dH0J7UomAx760k8MVK/nJvKJf9y1KLleDGdCqrGYgMBNP pZlRhnqbSLg9YTH4LJdSzJxQhEd/Qa5+wEHppCsYtws2IkJRWOH18u+CJooh5whhsmUqhV cEfDH7TEIznZdk1P6j/UNdC3ukjKHf6djtRKaHtmObuDxcHixZ+D7+1kizuSfWgwVGsvf6 fl0IMRqv6Shj0iwqOhyAnegnzi6bncdiIV1wxrZTcGFDXEy/xlUt/z4o/u7nFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793255707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WBj/oZE7Bt+e3YwKZOxLHxvV3gbNaUNwYqDX/4yG+Hc=; b=CI5QEHvLuBTGGX6qIqHJEzQ/5JnJuezBLlAnXYPf6UfJ2oSP6aDBaIDFM1OLtivLzk+Pli CRZckmAmOTH4yu3tb67sfxW2ddhAg+I0g6ZriDYX+ZH3TZzSQYb0XUN+rTPz59mkKrg0A/ 7hDpG8twNQNDzbnbE2f0PINVrh8it3vKxl6eMHcUTaFsbnm3pWp37B1kiDxKahKRsIxqRd DvbPAsK4o1+k3ur7Ldz6icP04aE0H0n7tySHuajROPXUodSntlORwP2qe2Rb1/HewOiTlm dfvnIIfXrbq8EG835fOYX5/b4Xr2rPowgblF3qgGUCza6OU5IrxG0Cgez8kgkw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFZGg0YSrzRR7 for ; Thu, 29 Oct 2026 06:35:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3d9ba by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 06:35:07 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: cd2ad1b456f7 - stable/15 - ixl: Initialize the extended RSS key List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: cd2ad1b456f77817804ec582d4b83e450a322835 Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 06:35:07 +0000 Message-Id: <6ae2e91b.3d9ba.5e918ef1@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=cd2ad1b456f77817804ec582d4b83e450a322835 commit cd2ad1b456f77817804ec582d4b83e450a322835 Author: Kevin Bowling AuthorDate: 2026-09-18 08:29:16 +0000 Commit: Kevin Bowling CommitDate: 2026-10-29 06:19:24 +0000 ixl: Initialize the extended RSS key Zero the complete 52-byte RSS key buffer before fetching the common 40-byte key. Both the X722 AdminQ path and the register path consume all 52 bytes; the trailing extended-key bytes must not come from uninitialized stack storage. This matches the zero padding already used by iavf and ice. Remove the unused driver-default key helper and its declaration. Keep the standard key, hash selections, and indirection policy unchanged. Reviewed by: gallatin Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59791 (cherry picked from commit 0f7bdeadaf9d8101993dd39abee3a6a2ef4e2950) --- sys/dev/ixl/ixl.h | 1 - sys/dev/ixl/ixl_pf_main.c | 2 +- sys/dev/ixl/ixl_txrx.c | 17 ----------------- 3 files changed, 1 insertion(+), 19 deletions(-) diff --git a/sys/dev/ixl/ixl.h b/sys/dev/ixl/ixl.h index e265c8fbe3eb..2d21bf5c12de 100644 --- a/sys/dev/ixl/ixl.h +++ b/sys/dev/ixl/ixl.h @@ -516,7 +516,6 @@ extern const uint8_t ixl_bcast_addr[ETHER_ADDR_LEN]; /* Common function prototypes between PF/VF driver */ void ixl_debug_core(device_t dev, u32 enabled_mask, u32 mask, char *fmt, ...); void ixl_init_tx_ring(struct ixl_vsi *vsi, struct ixl_tx_queue *que); -void ixl_get_default_rss_key(u32 *); const char * i40e_vc_stat_str(struct i40e_hw *hw, enum virtchnl_status_code stat_err); void ixl_init_tx_rsqs(struct ixl_vsi *vsi); diff --git a/sys/dev/ixl/ixl_pf_main.c b/sys/dev/ixl/ixl_pf_main.c index cfbe88d08173..d2a2fb74fe69 100644 --- a/sys/dev/ixl/ixl_pf_main.c +++ b/sys/dev/ixl/ixl_pf_main.c @@ -1099,7 +1099,7 @@ ixl_set_rss_key(struct ixl_pf *pf) struct i40e_hw *hw = &pf->hw; struct ixl_vsi *vsi = &pf->vsi; device_t dev = pf->dev; - u32 rss_seed[IXL_RSS_KEY_SIZE_REG]; + u32 rss_seed[IXL_RSS_KEY_SIZE_REG] = {0}; enum i40e_status_code status; /* Fetch the configured RSS key */ diff --git a/sys/dev/ixl/ixl_txrx.c b/sys/dev/ixl/ixl_txrx.c index aca22bb025ce..d015a93b5360 100644 --- a/sys/dev/ixl/ixl_txrx.c +++ b/sys/dev/ixl/ixl_txrx.c @@ -86,23 +86,6 @@ struct if_txrx ixl_txrx_dwb = { NULL }; -/* - * @key key is saved into this parameter - */ -void -ixl_get_default_rss_key(u32 *key) -{ - MPASS(key != NULL); - - u32 rss_seed[IXL_RSS_KEY_SIZE_REG] = {0x41b01687, - 0x183cfd8c, 0xce880440, 0x580cbc3c, - 0x35897377, 0x328b25e1, 0x4fa98922, - 0xb7d90c14, 0xd5bad70d, 0xcd15a2c1, - 0x0, 0x0, 0x0}; - - bcopy(rss_seed, key, IXL_RSS_KEY_SIZE); -} - /** * i40e_vc_stat_str - convert virtchnl status err code to a string * @hw: pointer to the HW structure