From nobody Thu Oct 29 06:03:17 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFYYx3qTzz6xrZ8 for ; Thu, 29 Oct 2026 06:03:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFYYx0XDNz4sTF for ; Thu, 29 Oct 2026 06:03:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793253797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lh+5dRF0wBV5Xap1YriMtT4Ct6uk6kFSCmzC348fjMI=; b=U0vMr7njoolcK4EfuBdzUq1Q8prnrOFGwV1RwvEUGmUDvYTl1VyjvN1TRSBTjeoagz6cJ2 3i5zqqCdMw85hC9bWacGzU+ESqXELdffVlST1qZKzBQPj3cI8McUPZjxp2A19QUjSH0NaF FPs8qymfwkERk7563d/fMxK6Y2fFa460RlgUF98B8TlGgQkkuSL81rrgwBzfMKiMKVAFR+ e0mIfsgkWwYcBElYZxJui/p5T7mpFotnWqdqkobw2LFb0fEStT/LCsT2JIgUV8VKVB6so/ 72VyhVrIACXFcrGKfphU4t5MuIDyfy5rv2Ian2fkPp0ZQCgtUto2C1An8qlBKQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793253797; b=taOxFKv/1MJOzrLI56MZgtXXeRDKDoTSZP/W3QsDh8PmOSfft6PvXL7x9vVevAEMEx7Lh9 lOlERASYZbuwvPYOpbauvCZiUX5kgW/pLdXz59/VxVvAFNb9TUtReFhhKqUYFPzStWv9Qx GJJK/TN1zId5GmT2WdiiDNvduVOAtkbSiMtdluwgGQ0/Aj/2mtOkELESXFFhxtognIH5ae EfZIqq09tKJQeziocUKELcmyZWvqBC1e4/XGZDCsNkkap0RyS/PRR6vT5+NvSAnPFkURYq YEOeVfWbvTvRwRnRzW0Px+IQ9sOr3CacpwFeUPoe0J6S3J9OjAmuBBOCBIJ6ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793253797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lh+5dRF0wBV5Xap1YriMtT4Ct6uk6kFSCmzC348fjMI=; b=Q1skb6lFnl6k8xqgT/LZcDz5cF3IcXAGyVPvKZElIY0jiUr1ipWPIuLlD61JFgiRbRAq8m lnm+At3OGOmYQxeX+XI6dflamQ0FtapkAZCbY8/286lh+KZI7AP6phu1v4E2XspBxAD/Fa gwEpWnPEtleAR5334FCoKUfuMo52n9PNE7uj93hSP6H09AMN36WcYDJWMj5C+wyfJLsYV5 +xLzCe2dhCOevJUjIQwX+Cp7n2OKWZigT08VxkL9DuTT67JAtu3QRbkf9tFZUBkpNtLKKj aKA/qojVJgyZGmpO6HFGP7Kye3i2TraEiwLqDrnVRPpRFM7961rUDFv4f49Erw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFYYx06xGzQsk for ; Thu, 29 Oct 2026 06:03:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 39871 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 06:03:17 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Andrew Gallatin From: Kevin Bowling Subject: git: 3543b9600cb8 - stable/15 - iflib: null out freed mbuf in iflib_txsd_free List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 3543b9600cb89c20e053abf23c8f016d2eaae804 Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 06:03:17 +0000 Message-Id: <6ae2e1a5.39871.64cece62@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=3543b9600cb89c20e053abf23c8f016d2eaae804 commit 3543b9600cb89c20e053abf23c8f016d2eaae804 Author: Andrew Gallatin AuthorDate: 2026-01-19 15:41:02 +0000 Commit: Kevin Bowling CommitDate: 2026-10-29 05:38:10 +0000 iflib: null out freed mbuf in iflib_txsd_free When adding the IFLIB_GET_MBUF/FLAGS, I neglected to NULL out the mbuf in the descriptor ring. I didn't think this should matter as the I thought this code was only used when the ring was about to be freed. But I was wrong, and leaving a stale mbuf in there can cause panics. Reported by: Marek Zarychta (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292547) Fixes: 14d93f612f26 Sponsored by: Netflix (cherry picked from commit d91ae61f8fc2dd4ab3c208f25570b91a0725e2e4) --- sys/net/iflib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/net/iflib.c b/sys/net/iflib.c index 7bd10487afe1..910694ebf336 100644 --- a/sys/net/iflib.c +++ b/sys/net/iflib.c @@ -2084,6 +2084,7 @@ iflib_txsd_free(if_ctx_t ctx, iflib_txq_t txq, int i) bus_dmamap_unload(txq->ift_tso_buf_tag, txq->ift_sds.ifsd_tso_map[i]); } + txq->ift_sds.ifsd_m[i] = NULL; m_freem(m); DBG_COUNTER_INC(tx_frees); }