From nobody Mon Oct 26 19:46:47 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jD3zW2MYxz6xWgr for ; Mon, 26 Oct 2026 19:46:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jD3zW1p4Xz4qP3 for ; Mon, 26 Oct 2026 19:46:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793044007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fAUHiejtyncTkMQ0b4C1QMOzCCsWigMC0bS3RdhnJak=; b=AfegYOXskrU9R8iTrsfDPYlb7gUVVhPPd4jGv4bRyelg6MnYu0x6+oITCf3whlXuvCuawl IowtJMxW0yZG4YIlwQBY9POVs3e7OG34vPENftLRPOKo5fJOB1cAUkiCg3LiR6O+AwGPaw l0Nagujpf/SdUL5gKgFB5g/6OlkpcV3OMMoVtcqNlWcMcoCf7k14EznD7dJQ/FfYN8Xxpe eC1e/BDCvAeywMhFGwGWumtRuESQUdiMO7DBtm+TlP6zDbRSucld54F61Ty0NjAmYNU2DR vQaJesdw9QZJJpVqs6YY5fAeqid7GM71wYOk8qRaxCZPm5gsvQGCwB6atWefSg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793044007; b=gw1Uyy86y55GpxjOq6XdC3JjE/sbRnEP3ni09gfERmVIh3i0WwVZ6lPuCSyK4D0bLOhryw wsr9omuUVKmF2TmiOUEKAUSb9Olz8vU85lrrsLPXOl7MduPhAt62CClr90ZDGmFz5PjAIh QyQGkz121nwuWLHnm6MdDet7OMDL/mhfj+e0Ity23kVt80Du91XS88iPtnpno9prSBKg9Q PbC9rf0IAeKuz0xBQupPebWB4ElsxguFBBS+8E5T0dmzuPG/yH/7aeVrCAW++yfhkCwpo3 WCkhJR/7hidZiTBEovTUjeZ+tZ+SmxVvTmnov+Bj4VbmXex1F7YZQqrtDv708w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793044007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fAUHiejtyncTkMQ0b4C1QMOzCCsWigMC0bS3RdhnJak=; b=JC4PJVOPHAYqAxE4Hf7T1g3nIywl4NCncfYD7rLqAq7a3Lw4JKl6YLeKnX/xY54UdC5WM/ 8o+VqU5k29ftFLoMbY/sStYqwEXRyZxaceaVKuY8wrzBFgfwW0gxzupmpxFNEf27KGNVIr CQioEQ2gp4ybh4oZJO5Ty/MYZY49bF7mcQDVAELB+dzajOdvx7EZAVsumEEKiSAtC1MwTV YiKh1S+/2dckWXPHhixprf3qIpN8Gbz+YsCY//a7ZfMA7qWU18sEgPrBnP9dFzSgwg90Y4 chMPNVNfrdPHT/lr2iPHRIc6rgCqf0PfTxH7sf972Y8upsvMmCf8zJdPiF2JwA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jD3zW11bPzpLy for ; Mon, 26 Oct 2026 19:46:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 39326 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 26 Oct 2026 19:46:47 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Andrew Griffiths From: Mark Johnston Subject: git: d0e92d89a9f0 - stable/14 - ipfilter: fix inverted range check on the lookup iterator unit List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: d0e92d89a9f03b0045b6eba086338a220485c381 Auto-Submitted: auto-generated Date: Mon, 26 Oct 2026 19:46:47 +0000 Message-Id: <6adfae27.39326.7c3c940a@gitrepo.freebsd.org> The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=d0e92d89a9f03b0045b6eba086338a220485c381 commit d0e92d89a9f03b0045b6eba086338a220485c381 Author: Andrew Griffiths AuthorDate: 2026-09-06 20:44:35 +0000 Commit: Mark Johnston CommitDate: 2026-10-26 14:12:15 +0000 ipfilter: fix inverted range check on the lookup iterator unit ipf_lookup_iterate() validates iter.ili_unit with if (iter.ili_unit < IPL_LOGALL && iter.ili_unit > IPL_LOGMAX) or alternatively, if (iter.ili_unit < -1 && iter.ili_unit > 7) ipf_lookup_add(), ipf_lookup_delete(), ipf_lookup_stats() ipf_lookup_flush() validate with a || Submitted by calif.io for the OpenAI Patch The Planet program Signed-off-by: Andrew Griffiths Reviewed by: markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D59726 (cherry picked from commit cb035c19c3e76d547eb7d4bca1f1106b117c27a0) --- sys/netpfil/ipfilter/netinet/ip_lookup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netpfil/ipfilter/netinet/ip_lookup.c b/sys/netpfil/ipfilter/netinet/ip_lookup.c index f9e00d3ec40b..02c3d06afdd8 100644 --- a/sys/netpfil/ipfilter/netinet/ip_lookup.c +++ b/sys/netpfil/ipfilter/netinet/ip_lookup.c @@ -666,7 +666,7 @@ ipf_lookup_iterate(ipf_main_softc_t *softc, void *data, int uid, void *ctx) if (err != 0) return (err); - if (iter.ili_unit < IPL_LOGALL && iter.ili_unit > IPL_LOGMAX) { + if (iter.ili_unit < IPL_LOGALL || iter.ili_unit > IPL_LOGMAX) { IPFERROR(50038); return (EINVAL); }