From nobody Sat Oct 24 01:18:24 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jBMTY2ctlz6wqL8 for ; Sat, 24 Oct 2026 01:18:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jBMTY0KS5z4LG9 for ; Sat, 24 Oct 2026 01:18:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792804705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Mo1A2Euu8tTdolV7fWfk7SGGVLT/9sHH77wS6CFK8f4=; b=S7Gw9Y3UUSnQBLeXH9fJcP3uEWED6RrBc9jOtV+T7AKGvrKHhTA9HBMP/Ye39wz3lvjyMm FoBXvYnU1xFQytR/f5W1m78qcddceqkA316F5fES/ge/0IY70iix0vTmmqHcQOU1wlZABn YNBgfMOWDdBho4cBJr2A3+KlP+mM0+YtSxlQDTpKvWQEwyfT0zTJKycQUknD66EhSNxyc3 KY6nHCFoRtkNDfgRWxeQnXsYxLVx4RKkSseV4U9kfxlW0XxQllNfQbO0JZDodi2PZ39PpQ NFKBM4K1bCyLgKcgAELg3IL0spMBsy9fKpD6kOLPRnP1zQfK49rD4jlnJwiNuA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1792804705; b=YLSNN/IKnG0sp5ron1uLZgojPpJxHQ+BmPQme424OEWbmXWMAcngBF5rMHAHOEem6AkvPS TyMyCboEmr/pYDK7kK+j8k8UNFouf1Ri8JO3fwwWkReo0xyQ5jrzPCYJK1gxP9cEAjQ05x np/69/DaEqA8rzaHT0amH9TNKSzBeH19Eri3IGkoNN7JVB0QnEOonJqFkTrsZ/q2P7tl4u 4pgV5d+iWRapVkGZ/WF9HmJgLHmVKbqGFdmRXKIVVcZU32YqXQYybejmpzqjmKFejgnbf2 JWBZuhiy4CxvzHZ2Q7GFaJaqlx9lGp4tSmKsncFQufRaJvq1dHpCv5+hklRQLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792804705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Mo1A2Euu8tTdolV7fWfk7SGGVLT/9sHH77wS6CFK8f4=; b=pHHT0z3WZe2XSJP24qTHt29QW6CB/O7mMAaR+JPCWddfXhUB5NVNmI+M1qMiaw5G7NppRB 5epQ6wcaI0ytAS8GU3GZdxpyZPn4m/NSx7TkOfYcH+2fHiTpqpoUjoemy1MtM0hr+Ns8Do y4wK8uNRp29gE+vYSE7+P+gI08hEkchmUAN+SUQPk2mm3iFccVjDwr7hY2ookuZw8r16ac RMOO05ZfU57+fm6BoQ6TWWY6cX4kdD+uy6nfNIT6MnT/Rp6ojmLxaUkHopsgpHbrNOefR9 R4y/Mzd0xRI8LrN+8WJ/Ub9i8kHT+W3BX4o51nHYpgCROkOiPEr7ve5TY5lghg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jBMTX75kJzw0L for ; Sat, 24 Oct 2026 01:18:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24306 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 24 Oct 2026 01:18:24 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Quent=?utf-8?Q?in Th=C3=A9?=bault From: Kyle Evans Subject: git: cdc894780c50 - stable/14 - bhyve: tpm: allow the last dword of the CRB command buffer List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: cdc894780c5014acf8278fa1f7ba02040096ce26 Auto-Submitted: auto-generated Date: Sat, 24 Oct 2026 01:18:24 +0000 Message-Id: <6adc0760.24306.63f1772b@gitrepo.freebsd.org> The branch stable/14 has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=cdc894780c5014acf8278fa1f7ba02040096ce26 commit cdc894780c5014acf8278fa1f7ba02040096ce26 Author: Quentin Thébault AuthorDate: 2026-08-07 14:02:08 +0000 Commit: Kyle Evans CommitDate: 2026-10-23 02:52:52 +0000 bhyve: tpm: allow the last dword of the CRB command buffer The bounds check rejected any access ending exactly at the end of the register block, so a four byte write at offset 0xffc was refused, returning EINVAL and killing the VM. PR: 291063 Fixes: 75909086a45d ("bhyve: allow read/write to full CRB buffer") Sponsored by: Defenso Signed-off-by: Quentin Thébault Reviewed-by: aokblast, kevans, markj (cherry picked from commit 4505445ccdb9555efc23262a971a18ca03486969) --- usr.sbin/bhyve/tpm_intf_crb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/bhyve/tpm_intf_crb.c b/usr.sbin/bhyve/tpm_intf_crb.c index b1f5b72b6285..b499d17aaf01 100644 --- a/usr.sbin/bhyve/tpm_intf_crb.c +++ b/usr.sbin/bhyve/tpm_intf_crb.c @@ -322,7 +322,7 @@ tpm_crb_mem_handler(struct vcpu *vcpu __unused, const int dir, crb = arg1; off = addr - TPM_CRB_ADDRESS; - if (off > TPM_CRB_REGS_SIZE || off + size >= TPM_CRB_REGS_SIZE) { + if (off > TPM_CRB_REGS_SIZE || off + size > TPM_CRB_REGS_SIZE) { return (EINVAL); }