From nobody Fri Oct 23 17:38:32 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jB9Gw4PTnz6xM5X for ; Fri, 23 Oct 2026 17:38:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jB9Gw3jjSz56Jy for ; Fri, 23 Oct 2026 17:38:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792777112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=N39WZpVbJ8Nh+1i7rMLyffMPzeRcOkx7FU5rhxLMMqI=; b=tSeVz/OaiCiN/SD7OHUcjmfQo/On23Qd3XAH7YCpzdS6FjHzgUXJDVBePO12kHt8FflTyS 28/YtYPvbFpggUFS7aMF/R1HItsHAv/AGjVEKTFRzO5KVndd5Hk/t7Si1TevoT3bQcRYaf b1873/Nq/AvODsaUgEgRwp4y59SSHwl6ekRxQOaMc69M7EwTRiXvcVhEfmdX16bM6nQ0Mw UB1e9/1NVUIUW6sPhmM9avM/A6RjGg96ztiT7ZDohIMwJd642BGnU9KvQHdVB19sUdCQkp UtDwqbi+ikje5NsLBA50tj6eF3kj6TffsHHoDRtx0Yhi2zkSnZYu4slDUmm0SA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1792777112; b=T0ojKYz3GfQVnOvDWy7ecM/uBMuMabCD1RZ7A7zVqxMNmbQwmWCjahZ/u23NJA7razkW8+ 6qs4mLpSyjHkwkEksYQjNCnvnU89Y+wwhPbSgktDYjr94Wtfz+u9jVo4bihM3Uaz36O4yT +pz7VpzW7r6iXamWYNpl1zIWcKo3Cbyq38PK3+LLUjiHxhoXGezks/uLI/crcsKiIi8rJ/ n2EwW2NwaKCrzYFJpu8F0jPSTb4Naux+iBfoiTeatyj4Qml9UxUU3Gd7MWyp5lkmyqbLco RlAl6whpuaSFUD1EDnIi1q9Si9Sp0DEbADfVlCBupwiB8ll1bmLhEbX570SrIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792777112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=N39WZpVbJ8Nh+1i7rMLyffMPzeRcOkx7FU5rhxLMMqI=; b=GuHInTWDWBvHfGglnDayKl2+Pyt4WyZdTRzeINL5Ok2fD8C4QGquqnlB1/Uy4RuNpRo6h+ aXjluvG20QXnXgaDbQbL25nKNy9Ox4ZGnd5+Tgq8IIWkQmK38scSMwVjL+OrKZc7bgXYhe qCrPkn3DjW/3oD1LWeuBOlgCGb+RQWJpQlFBdtQ6264+poklqZ8z+c4oXs8uxt26ks9F16 1eGhRs/dgD4S076GOUYp25TKp9Ixgmfp6tj06OKWbLl/jy1IRHD875J3M5nhcVo+lft/RM csXVrL5g2cyF2kLZqZa+rJiN+AK3TSWD8hyZYjUKCF+yvvzagRXf5+512J8mMQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jB9Gw352Kzg8V for ; Fri, 23 Oct 2026 17:38:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3ed76 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 23 Oct 2026 17:38:32 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: f23fa56df5df - stable/15 - tcp md5: fix accounting of ACK with bad signatures List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: f23fa56df5df61f967dcf7d5307cb6181a766776 Auto-Submitted: auto-generated Date: Fri, 23 Oct 2026 17:38:32 +0000 Message-Id: <6adb9b98.3ed76.33557299@gitrepo.freebsd.org> The branch stable/15 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=f23fa56df5df61f967dcf7d5307cb6181a766776 commit f23fa56df5df61f967dcf7d5307cb6181a766776 Author: Michael Tuexen AuthorDate: 2026-09-04 07:24:40 +0000 Commit: Michael Tuexen CommitDate: 2026-10-23 17:37:21 +0000 tcp md5: fix accounting of ACK with bad signatures When processing the ACK of the initial TCP handshake using the SYN cookie, don't increment the counter for unexpected signatures (tcps_sig_err_sigopt). The correct counter (tcps_sig_rcvbadsig) for bad signatures is already incremented in TCPMD5_INPUT(). Reported by: Hannes Elfert Reviewed by: rscheff Differential Revision: https://reviews.freebsd.org/D59302 (cherry picked from commit 2fb53436cd05f65164d166ef3ab33660fe451470) --- sys/netinet/tcp_syncache.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/netinet/tcp_syncache.c b/sys/netinet/tcp_syncache.c index 7c1c1f95856a..9209970eee5a 100644 --- a/sys/netinet/tcp_syncache.c +++ b/sys/netinet/tcp_syncache.c @@ -1145,7 +1145,6 @@ syncache_expand(struct in_conninfo *inc, struct tcpopt *to, struct tcphdr *th, s, __func__); free(s, M_TCPLOG); } - TCPSTAT_INC(tcps_sig_err_sigopt); return (-1); /* Do not send RST */ } #endif /* TCP_SIGNATURE */