From nobody Fri Oct 23 17:37:05 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jB9FF3DKfz6xM36 for ; Fri, 23 Oct 2026 17:37:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jB9FF2lrSz55SL for ; Fri, 23 Oct 2026 17:37:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792777025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bAGM/vSx2wmMHzcjG+/qdiGJQ4vOpUmNPwElR9/C1Sc=; b=PUXfbEJAfU9tpMi9vaLJJc8woXWIzSEUW8x3CCBdJ6eaeuLAtQPI2Xp2OsuMlon54nh+4l TyRwj3J4FSxEdnQgNb4o+PeL3m9cGs5GUb1Bdog7mmnWON3WvIR4rir1y3G7b8WfIXGyag vf6ye0rygM4o2eyFwPMpUoiQw+jZKkGprvc3xwI0UQVELVPGIJub/Tkn5jTbG9aeEbnCJ5 R6ez0vR3lsvaOkaGeeoMiMMEQEVqH/cF/N4AzHTTGyPAmkjHkEBbTNLLuqwuvT2ja+qxia FYH7HCHUh12IZnuYckvO4CavXEADVSG4GRD1tiS21t8GFuG7fOuWtxR/05NRkA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1792777025; b=bSd3Es/u37m4giMID80syq69xVvRJIiMilbRKkGs5O4Cit5LuXWj4QL8xI8IChfm32eBkq 1pXjqlw3z9pnmZQiESb44QawrpUya7VRutkBwmfmmmyUxWJ/vQZ1yViWDCZrViJhKNlHgP frOaCsIhoRBaFBMVv2pW3D9pt44cYiBUbeJQFAMhVb+Qwgl5Mu4L9Xt6R/pB04rsEXHr0A A3ieRwzVR0dZjrboBg+wPQcDJGWZAoqnbHfZxLyV21fPwA6jO32ZOsJhExTTrN4o9Ghm2R N32fq/xMIEf8WwG2tbi2RTQkITeR6pfYT8xoN7oWuukwjrAi6T2bHaGW11nLFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792777025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bAGM/vSx2wmMHzcjG+/qdiGJQ4vOpUmNPwElR9/C1Sc=; b=XQPIo7aR4oxOuZu89Xma3gpbxySEps9jy1XCBMd4ZRd6TAuxs8Pmk+ik0Jf2SzH1phDMDw Hh7klgXjdhHOTCElox4Iqp+bq8pkWgQ7wfdyQBUD0R0ZKPi/uRWFu5331GvoAa2FaedxBO d+THqHjhcAToruf5Z6QHy/xUawvsVKv3PoerZwvgfxR6EL9KPOS06PHfJUATH9rPEv0o7K wcRn10eIFAEaKqQcoeWPqyR9Si8x6SuPUZySeBbktNqNQgDVOecEWfbCX0RdF8VrvXxVHv FHJpciSgnGSvlylXYB6DwQ7kJ5AnQNliAzebcBmkFE+kNYBsYGtX0fWXIHN9mQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jB9FF2QCJzg8R for ; Fri, 23 Oct 2026 17:37:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 183e0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 23 Oct 2026 17:37:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 3d5546429b99 - stable/15 - tcp md5: improve handling of tcps_sig_err_sigopt counter List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 3d5546429b996626238498da78ebff79580595ee Auto-Submitted: auto-generated Date: Fri, 23 Oct 2026 17:37:05 +0000 Message-Id: <6adb9b41.183e0.55b69421@gitrepo.freebsd.org> The branch stable/15 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=3d5546429b996626238498da78ebff79580595ee commit 3d5546429b996626238498da78ebff79580595ee Author: Michael Tuexen AuthorDate: 2026-08-31 13:12:54 +0000 Commit: Michael Tuexen CommitDate: 2026-10-23 17:35:37 +0000 tcp md5: improve handling of tcps_sig_err_sigopt counter For non listening TCP endpoints, increment the tcps_sig_err_sigopt counter when TCP MD5 is not enabled in the TCP connection, but a segment containing a TCP MD5 option is received. Also increment the counter when using the RACK or BBR stack. Reported by: Hannes Elfert Reviewed by: rrs Differential Revision: https://reviews.freebsd.org/D59249 (cherry picked from commit c6ae11c1b0d96fd2ed0b55c655ff58a46b26ddcb) --- sys/netinet/tcp_input.c | 6 ++---- sys/netinet/tcp_stacks/bbr.c | 5 +++++ sys/netinet/tcp_stacks/rack.c | 5 +++++ 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c index a1786952741e..f47e60bede8c 100644 --- a/sys/netinet/tcp_input.c +++ b/sys/netinet/tcp_input.c @@ -1606,11 +1606,9 @@ tcp_do_segment(struct tcpcb *tp, struct mbuf *m, struct tcphdr *th, to.to_flags &= ~TOF_SACK; } #if defined(IPSEC_SUPPORT) || defined(TCP_SIGNATURE) - if ((tp->t_flags & TF_SIGNATURE) != 0 && - (to.to_flags & TOF_SIGNATURE) == 0) { + if ((tp->t_flags & TF_SIGNATURE) == 0 && + (to.to_flags & TOF_SIGNATURE) != 0) TCPSTAT_INC(tcps_sig_err_sigopt); - /* XXX: should drop? */ - } #endif /* * If echoed timestamp is later than the current time, diff --git a/sys/netinet/tcp_stacks/bbr.c b/sys/netinet/tcp_stacks/bbr.c index f2d7867df9b4..1bd87ad9bc31 100644 --- a/sys/netinet/tcp_stacks/bbr.c +++ b/sys/netinet/tcp_stacks/bbr.c @@ -11354,6 +11354,11 @@ bbr_do_segment_nounlock(struct tcpcb *tp, struct mbuf *m, struct tcphdr *th, */ to.to_flags &= ~TOF_SACK; } +#if defined(IPSEC_SUPPORT) || defined(TCP_SIGNATURE) + if ((tp->t_flags & TF_SIGNATURE) == 0 && + (to.to_flags & TOF_SIGNATURE) != 0) + KMOD_TCPSTAT_INC(tcps_sig_err_sigopt); +#endif /* * If timestamps were negotiated during SYN/ACK and a * segment without a timestamp is received, silently drop diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index 86ea34f46a05..91aa589bce74 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -16336,6 +16336,11 @@ rack_do_segment_nounlock(struct tcpcb *tp, struct mbuf *m, struct tcphdr *th, */ to.to_flags &= ~TOF_SACK; } +#if defined(IPSEC_SUPPORT) || defined(TCP_SIGNATURE) + if ((tp->t_flags & TF_SIGNATURE) == 0 && + (to.to_flags & TOF_SIGNATURE) != 0) + KMOD_TCPSTAT_INC(tcps_sig_err_sigopt); +#endif if ((tp->t_state >= TCPS_FIN_WAIT_1) && (tp->t_flags & TF_GPUTINPROG)) { /*