From nobody Thu Oct 15 07:49:02 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j50ZQ457Mz6vPKT for ; Thu, 15 Oct 2026 07:49:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j50ZQ3X4rz4HCt for ; Thu, 15 Oct 2026 07:49:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792050542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YDgu0ZHv2hOgjYYZIT+Mw4S46XEvnCPffXUlspdx5Ys=; b=TiPcJ6p7hh9IBFsWRRoxVyZw6TtJ2l6KIIs8p0auxPPsamIr2C3bB2wS2wegYw36E1wbkR BCpYs15I085sQ3+/Sc0RPD4x723xgeHIlPTrYMtVkRdYl/XgIZlM5XDjg+Xe2gntgnBEqs dZLmrQuqNwaRHUmrkCqTmFblBSz5Z1GdifXJpklOnnWrrzdz2hQnN2qbA2fo76j4mR+LQp G14R3Cqu08fWdqXuqO7J+5ocqb48sih2xt/l0qw0J1gPHTIWa2jeTPl06WXMj1n/61Mp9b qZrcQMk0KuBOJOfT7e8cbdvuqEmDQuq0kg4/YFJwkeLm0gXyLpw872ntEBBMIQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1792050542; b=S0yp47ftrsruf/UCiogBVPGscK7Q/rqtTwPQEDItoxgaGdTx5+9Lu0iJkH0eUcPLVI1Duk mQBr77cjI6x/cskgHhCCp7ell6MgAhSWnxqBDJCoVMjLewMfuQHqb6RCcezwfCHrpQq0th Gr3mAVqgvmWn9Lc7mlTvuDnliW8tAKlbmJdVnLVsDcJNSGb3zOX9zSvN5gc1U3k8w0dVhG cMy4gEEZvE9J7HKRpo/g4D4GiC5ivggRdZ5Sjg5uoFov+uJ0rxP6MvdgaeYzBxVqfFNShX KJaaN75sRzGFI/cb8ehviu9RDNRlZ7DDJqIY+KsPiCQwFTExouKubppm4QMOng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792050542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YDgu0ZHv2hOgjYYZIT+Mw4S46XEvnCPffXUlspdx5Ys=; b=S4kS7q27BE6rzl1jZYXLyxjvDoP16yI45o+554ontYrL1YsORtd/LzNIyG0IK8K98MyXcX ScpK1LCqYFiVcvL+aHksJo4SN7J1+r7qt7LBycXhv7An0w4t3U6vcbfF+OAr+JqKnBUn6m 5TMVx7RBonFwH711RjU4YMatVWtumBenFgewMe+ML/KnrRMwfKIKKBNYxFs+qy2X+WHTbm fEps8HUCRyF2u5/7ZlQpkUQrj6AS65UNe5PxkfL7M8V3J9pV7dJCKsu2pDSoTXbXgGEcQD w57jFNSi+EuyStNsQ6r1gYd6TTzihMeSgLrAnLnuSF9NL7qv2vI8LRXWrIy5uw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j50ZQ2b9VzNT0 for ; Thu, 15 Oct 2026 07:49:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1ddaf by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 15 Oct 2026 07:49:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Piotr Kubaj Subject: git: ceaf30c92ed7 - stable/15 - virtio_gpu: use an X8R8G8B8 resource on big-endian guests List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pkubaj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: ceaf30c92ed7a44f532e24742ed08bcf730c8ac1 Auto-Submitted: auto-generated Date: Thu, 15 Oct 2026 07:49:02 +0000 Message-Id: <6ad0856e.1ddaf.369fce26@gitrepo.freebsd.org> The branch stable/15 has been updated by pkubaj: URL: https://cgit.FreeBSD.org/src/commit/?id=ceaf30c92ed7a44f532e24742ed08bcf730c8ac1 commit ceaf30c92ed7a44f532e24742ed08bcf730c8ac1 Author: Piotr Kubaj AuthorDate: 2026-09-28 08:43:35 +0000 Commit: Piotr Kubaj CommitDate: 2026-10-15 07:40:39 +0000 virtio_gpu: use an X8R8G8B8 resource on big-endian guests The virtio-gpu resource formats are defined by byte order in memory, while vt(4) and the X server (through vt_fb and the fb mmap) write native 32-bit 0x00RRGGBB pixels into the shadow framebuffer. On a big-endian guest such as powerpc64 those pixels land in memory as 00 RR GG BB, which the host interprets under B8G8R8X8 with red and blue swapped and the padding byte taken as blue: white renders yellow and blue renders black. Request X8R8G8B8 on big-endian guests instead, which is also what the Linux driver does (DRM_FORMAT_HOST_XRGB8888). Reproduced with a colour test pattern on a powerpc64 QEMU pseries guest using the identically coded out-of-tree fork of this driver (graphics/virtio-gpu-qemu-kmod); little-endian guests are unchanged. Differential Revision: https://reviews.freebsd.org/D60085 Approved by: jhibbits MFC after: 1 week (cherry picked from commit 7cf02164a517824c07faed91c009be90f2f17ec0) --- sys/dev/virtio/gpu/virtio_gpu.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sys/dev/virtio/gpu/virtio_gpu.c b/sys/dev/virtio/gpu/virtio_gpu.c index b95bae9fe286..2cbfc472909c 100644 --- a/sys/dev/virtio/gpu/virtio_gpu.c +++ b/sys/dev/virtio/gpu/virtio_gpu.c @@ -61,6 +61,12 @@ /* The guest can allocate resource IDs, we only need one */ #define VTGPU_RESOURCE_ID 1 +#if _BYTE_ORDER == _BIG_ENDIAN +#define VTGPU_FORMAT VIRTIO_GPU_FORMAT_X8R8G8B8_UNORM +#else +#define VTGPU_FORMAT VIRTIO_GPU_FORMAT_B8G8R8X8_UNORM +#endif + struct vtgpu_softc { /* Must be first so we can cast from info -> softc */ struct fb_info vtgpu_fb_info; @@ -556,7 +562,7 @@ vtgpu_create_2d(struct vtgpu_softc *sc) atomic_fetchadd_64(&sc->vtgpu_next_fence, 1)); s.req.resource_id = htole32(VTGPU_RESOURCE_ID); - s.req.format = htole32(VIRTIO_GPU_FORMAT_B8G8R8X8_UNORM); + s.req.format = htole32(VTGPU_FORMAT); s.req.width = htole32(sc->vtgpu_fb_info.fb_width); s.req.height = htole32(sc->vtgpu_fb_info.fb_height);