From nobody Fri Oct 09 00:20:31 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j16vh1NLHz6Z1xt for ; Fri, 09 Oct 2026 00:20:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j16vh0YNRz4LVJ for ; Fri, 09 Oct 2026 00:20:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791505232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WVfkwdHowoGPuQKFOtbaIGVSTNOdo1NZIut5xwWICvg=; b=HGFSL8Wj1bzgwRFItAQQ5v7dkkgpVToqiMTx0Ol029vaedOqKQE7x0roerjQjyXnd3atQH gz6WIb28n1MmS8RjD/SNuo3WnGsrLhqWM5PkhbFzIVzaAwK61t0goG18EP/R4vys3B4rbM A9lXC0REwUEMwELXZw1l72jwN11YQJgPR6lu3/JOwcoy101EHwonDo5FL8XWb3gcTnERjS jWPPf6uXi3UiUJ8KieO7JNe9cqnsH7i+tzi1l0giQT8lYd/32n6vdj0tRxZ2tgayE+GwEd nT50QERnltTBbRvxPsQbw4333J/3+WCYMEnx2+ZuQE1C/7mVViIDv595L/vRDw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791505232; b=juV95dPmInxq/NE7lB20xgSM2GVUZ5BRaFA1ssFXrsbpc65Q57L5onWgB5dlBHb0GDmzdT MVnEFwR3YqE3hCHZJQQyVryE6bCYGF/HmzQ7F0oXDz+vn9UUZSXQWVgUN/NhEI++gX4fgv xH/UPPVe+E1YFsjf07O1akxMnvRxSGzlW5djesLLxajofWPIvbRmtX0m1+rTWwX+syYbic zeY0RxyufxQM4GEEcBOrRPyQNLrZsveCDM5R12Wqo5Qr+fPuy/UHUXP0uTtFZcQiUGWxIj K65/hPhkw9djBZa1jywzVwav8LNQv/JRsePpcQaPRVb9rINmajYxI0ZjEEDoVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791505232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WVfkwdHowoGPuQKFOtbaIGVSTNOdo1NZIut5xwWICvg=; b=mkGJ13mE9V9ZPn5srGHTJ72W0fxHWb9vch/038KGBed4Hzw1MnLLceAaBeOwnGpHNj/9qV 3NdazF6PNweyMQIGInw2JeIR3ighY5W5UO3JOU4grXc6tXRg8bv4vnR/9uSlKUJOBXstPj 1oMCCmovEFPEKmA+3N6pawABYIf4x2MJeuqTDKSmqdE7SiXwFNTjP5c2ex3vRV7N+235YJ DeydZcjZMHUrJE8bk2jh+1TdhpYndDx0kuAOHhKZqqC3V0R68+z7wyd+BG6Y6o8RXkbDIY U7AuBgrr4XJI4iD2BthzyN7E8vhqaVJOxat+OBIkS1ujtgSbkmuIm7ix5TDCZg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j16vg6k7xz12qt for ; Fri, 09 Oct 2026 00:20:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 18173 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 09 Oct 2026 00:20:31 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: d143c08f88ca - stable/14 - ppp: Don't fetch a non-existent variadic argument List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: d143c08f88ca91d5280e26399daf94d7636b7779 Auto-Submitted: auto-generated Date: Fri, 09 Oct 2026 00:20:31 +0000 Message-Id: <6ac8334f.18173.11dd765e@gitrepo.freebsd.org> The branch stable/14 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=d143c08f88ca91d5280e26399daf94d7636b7779 commit d143c08f88ca91d5280e26399daf94d7636b7779 Author: John Baldwin AuthorDate: 2026-06-10 13:44:10 +0000 Commit: John Baldwin CommitDate: 2026-10-08 18:23:13 +0000 ppp: Don't fetch a non-existent variadic argument Only fetch the optional mode argument to ID0open to pass to open(2) if O_CREAT is present in the flags argument. It is UB to fetch an argument that doesn't exist. On CHERI this UB results in a fault. Reviewed by: brooks Obtained from: CheriBSD Sponsored by: AFRL, DARPA Differential Revision: https://reviews.freebsd.org/D57137 (cherry picked from commit b5a8b933d4994835e10226562ff8126298c96693) --- usr.sbin/ppp/id.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/usr.sbin/ppp/id.c b/usr.sbin/ppp/id.c index 5dd98cfee024..015218184b23 100644 --- a/usr.sbin/ppp/id.c +++ b/usr.sbin/ppp/id.c @@ -145,7 +145,10 @@ ID0open(const char *path, int flags, ...) va_start(ap, flags); ID0set0(); - ret = open(path, flags, va_arg(ap, int)); + if (flags & O_CREAT) + ret = open(path, flags, va_arg(ap, int)); + else + ret = open(path, flags); log_Printf(LogID0, "%d = open(\"%s\", %d)\n", ret, path, flags); ID0setuser(); va_end(ap);