From nobody Tue Oct 06 17:39:24 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hzk5n22QVz4nGX4 for ; Tue, 06 Oct 2026 17:39:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hzk5n1b1Nz3HYV for ; Tue, 06 Oct 2026 17:39:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791308365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SSDnYyf5JhrZeQXatn7nIv0Gjg+DkeQhiDulra2iCTs=; b=Qs6XF3itz0VOjkfF1J7Z7rl7Kjn7nqym32/m8Pa16r3sxVs/6CNaUFypQZSAXWZUTKvbmg 68h4P87dNGiL4IKFe/OEfJthMsXVWaXkl6qVtNNj9dgbvVJqAbeWFEX13vsUF9tseJJumn TV9Gwj4eUYESD7PEBWHxkYDWlAWKCprxmnN59c1o/2jc0uKn/pLS/V77K0DVIjD8KMp4DM LKVonl1KSa4RCWRbOQTKEJfJ0ZVm+JoKOvkGD7EV8MIcFr5QGuLI25UlO9RaMbJ8REIj2L LZxv7wMnDD054ViDN3MXm9hRfcbzR6WrDPYsaYPsyw4bv3PaLfVzVVcLsTAbrw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791308365; b=nXz/0wG2F9aBNNpWudDjegc4TZROytXEU62zXV2wXWGhN3Mdbavx+ZpeMTL0LclqT0PiMd OSf/nrn1JtR31nJAYB1Tnmsn5t9JwcgiTvY1/wVeSV2FPTufzDyof80CZMFepIiN2bJBSD xeEfu1dse197zE2JTwCrHwKEgpprGWx6WKn3cZ+lOFu4y/vIKLfvhrIEvw5f7ozkwRF5lx KU/aTrlJ5gU8uw9/8zornt9QXNyaazsEyPG80FgxZwrTc6DqBv4dx2kEFlc4RKKclUAoNE 6CAXecnoFzEVVB7kZEbpMK1AWfdkEIHQwiPDfZO5iSC26ouL5ojOOhbLx4+jTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791308365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SSDnYyf5JhrZeQXatn7nIv0Gjg+DkeQhiDulra2iCTs=; b=W1U3CQwMPrPRN5Cc/T9bLBphWnEiJJtJOAmDUf9RXP+qy0wil88fNUioRGmcA10SJ+0m6d kS62fGQJPkvlL9t9krgwrgoZYkoqSxGtYpDLh6JcnuAU7IwMiMk+QA7TszlsVxCzEfJQE+ b9QpiJ0PwehmcFjBpPkKVDyW8H/xNyxQhE2zJjr3up3fPx8cDvnmEtcOnJIAh9eNMLOvXJ +XRzJvP3RXum2O4qyQ+nVN9wlxHUzIB1gYhuaPBY19QypSy89N4MtS4khSlRDOQ1Y7efRG fsnQNTBAQXRDBF7VRb2uWpKq5kUvze1ef0gzChKixa1nysSbsAclGGmRrFHxYA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hzk5n0MFbzFnh for ; Tue, 06 Oct 2026 17:39:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 37025 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 06 Oct 2026 17:39:24 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Maxim Konovalov Subject: git: 2da109690be8 - stable/15 - dummynet: do not overflow the points[ED_MAX_SAMPLES_NO] array List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: maxim X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 2da109690be8f29f03b68150c827f47db81ad8b5 Auto-Submitted: auto-generated Date: Tue, 06 Oct 2026 17:39:24 +0000 Message-Id: <6ac5324c.37025.72601dd1@gitrepo.freebsd.org> The branch stable/15 has been updated by maxim: URL: https://cgit.FreeBSD.org/src/commit/?id=2da109690be8f29f03b68150c827f47db81ad8b5 commit 2da109690be8f29f03b68150c827f47db81ad8b5 Author: Maxim Konovalov AuthorDate: 2026-09-21 23:32:09 +0000 Commit: Maxim Konovalov CommitDate: 2026-10-06 17:36:21 +0000 dummynet: do not overflow the points[ED_MAX_SAMPLES_NO] array Otherwise, the following would segfault dnctl pipe 1 config bw 1Mbit/s profile 1025points.txt Found with: Claude Code Sonnet 5 MFC after: 2 weeks (cherry picked from commit 04fcf30961266cd77139b40774cb0d6ef6eb2be5) --- sbin/ipfw/dummynet.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sbin/ipfw/dummynet.c b/sbin/ipfw/dummynet.c index a0cefcffd183..3cf9a1854365 100644 --- a/sbin/ipfw/dummynet.c +++ b/sbin/ipfw/dummynet.c @@ -959,6 +959,9 @@ load_extra_delays(const char *filename, struct dn_profile *p, } else if (do_points) { if (!is_valid_number(name) || !is_valid_number(arg)) errx(ED_EFMT("invalid point found")); + if (points_no >= ED_MAX_SAMPLES_NO) + errx(ED_EFMT("too many samples, maximum is %d"), + ED_MAX_SAMPLES_NO); if (delay_first) { points[points_no].delay = atof(name); points[points_no].prob = atof(arg);