From nobody Fri Oct 02 15:50:07 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hxCsX1L2xz6vc8t for ; Fri, 02 Oct 2026 15:50:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hxCsW3kK6z4hWb for ; Fri, 02 Oct 2026 15:50:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790956207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=H6OafvRFb8aL76ClUp9Nu01oTpkpcotMOXsT0d/pUpc=; b=Jk7/e/V+IGoDRIQF7wxxkewvUdCj5bxzIL42YtLeqWSQS0jHUMOHr6rcxLaRdCHAQbHuz4 71OCmAhbPNjMPw0GMwlOKxMVTxtKd+Zcr64Ai+Tp6lNWk3PHdCuaqV5esp5N0ig5twfXIH Vwl5EpoF5WEPnctnHQwlu3qHoINxT2T1ieX/VgPhx1nHBoasl5hbp0YWfgdpuKQN5gNYJ+ ViQOvSkFie+IpRN40Byb2sL6/i3tPTbJms23gsXxnwaBhzVAuZqjAs3lUbPENJ2MOjNtYs pXW1/uZiSF6JN2Njqa096MKktOa5cAfhJQ7SKexdH+DxRGTCDteUUqmloMabWg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790956207; b=qVw0I+6G1twDpN7vV5Xw7d/9UkzosW+CONqmpiYrTVQIIyBEEFQZ5cWEytWd2L5arip88y rYbmaDITrisiCp6L0eCKjZBTPy3vJM+5oYFY7xSSu9Pn0uYSiCP8/illc5lbIjBY1Q7tGB DGwS1AhoLJgA99HGttjIEHtiq1RukQCjkoL2sFRB+nP+7veqpN139KnaW8PU84/bLhkog2 OOQuOWYFOdDAllP7lSpBuV887aULIFlMpG+fkCpK/gJUEloeX6L3XVUQKhuFpxfQCm/9ZY EFynAS+gEEdGvjuJRejaSrog2N3Y9wBLZcbXIlRK57d2NoAi7iKeu+EE+g1/rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790956207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=H6OafvRFb8aL76ClUp9Nu01oTpkpcotMOXsT0d/pUpc=; b=qbd7b7/LC01mNNGwSZ27nFbONnn2DboX8xmDMCkDl9KNFEN1cT70Z7TuWaXhMEv6XdgCpw vlFNhdFAin3VObAWsSaPTD4xFZA6nE9KvqzJ7VfL53SKLADovv+YDfTvl4OdkXZgtbcCeT XF/rtCIxh69EpjSkONxL5p3/KGRWuLo9iQ+Hty8bjHmSoKiTWW/dqTfhNU3w0XPAXMUhA7 0qCL/XFno22QUKY652qc8FVY+d0qEwMeyK7LwHYVyzUMXpFXrMedWHn4YuDYAqxV14cFKY Idf07ADwx8OOgBQobB3fAAS5ElP0Nl1SacpPHS+EbHJvr4bMZZ9+dT0UHn2Cgg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hxCsW2bktzNjx for ; Fri, 02 Oct 2026 15:50:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4132e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 02 Oct 2026 15:50:07 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Minsoo Choo Subject: git: abed4cb15735 - stable/14 - sched: factor out hogticks calculation into sched_update_hogticks() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mchoo X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: abed4cb15735d9743da4ef979ceef0ec678289d1 Auto-Submitted: auto-generated Date: Fri, 02 Oct 2026 15:50:07 +0000 Message-Id: <6abfd2af.4132e.7ebc0c12@gitrepo.freebsd.org> The branch stable/14 has been updated by mchoo: URL: https://cgit.FreeBSD.org/src/commit/?id=abed4cb15735d9743da4ef979ceef0ec678289d1 commit abed4cb15735d9743da4ef979ceef0ec678289d1 Author: Minsoo Choo AuthorDate: 2026-09-06 22:49:02 +0000 Commit: Minsoo Choo CommitDate: 2026-10-02 15:44:55 +0000 sched: factor out hogticks calculation into sched_update_hogticks() Suggested by: olce Reviewed by: olce Approved by: olce (mentor) MFC after: 2 weeks Sponsored by: FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59471 (cherry picked from commit 5a879394ba2eac14f65b466a46dae39326df00db) --- sys/kern/sched_4bsd.c | 16 ++++++++++------ sys/kern/sched_ule.c | 17 +++++++++++------ 2 files changed, 21 insertions(+), 12 deletions(-) diff --git a/sys/kern/sched_4bsd.c b/sys/kern/sched_4bsd.c index f66c73597b67..d494f6d7ba29 100644 --- a/sys/kern/sched_4bsd.c +++ b/sys/kern/sched_4bsd.c @@ -134,6 +134,13 @@ static int realstathz = 127; /* stathz is sometimes 0 and run off of hz. */ static int sched_tdcnt; /* Total runnable threads in the system. */ static int sched_slice = 12; /* Thread run time before rescheduling. */ +static inline void +sched_update_hogticks(void) +{ + hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / + realstathz); +} + static void setup_runqs(void); static void schedcpu(void); static void schedcpu_thread(void); @@ -209,8 +216,7 @@ sysctl_kern_quantum(SYSCTL_HANDLER_ARGS) if (new_val <= 0) return (EINVAL); sched_slice = imax(1, (new_val + period / 2) / period); - hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / - realstathz); + sched_update_hogticks(); return (0); } @@ -226,8 +232,7 @@ sysctl_kern_slice(SYSCTL_HANDLER_ARGS) if (new_val <= 0) return (EINVAL); sched_slice = new_val; - hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / - realstathz); + sched_update_hogticks(); return (0); } @@ -664,8 +669,7 @@ sched_initticks(void *dummy) realstathz = stathz ? stathz : hz; sched_slice = realstathz / 10; /* ~100ms */ - hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / - realstathz); + sched_update_hogticks(); } /* External interfaces start here */ diff --git a/sys/kern/sched_ule.c b/sys/kern/sched_ule.c index 9a7adfed338c..30226aa31071 100644 --- a/sys/kern/sched_ule.c +++ b/sys/kern/sched_ule.c @@ -235,6 +235,14 @@ static int __read_mostly tickincr = 8 << SCHED_TICK_SHIFT; static int __read_mostly realstathz = 127; /* reset during boot. */ static int __read_mostly sched_slice = 10; /* reset during boot. */ static int __read_mostly sched_slice_min = 1; /* reset during boot. */ + +static inline void +sched_update_hogticks(void) +{ + hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / + realstathz); +} + #ifdef PREEMPTION #ifdef FULL_PREEMPTION static int __read_mostly preempt_thresh = PRI_MAX_IDLE + 1; @@ -1665,8 +1673,7 @@ sched_initticks(void *dummy) realstathz = stathz ? stathz : hz; sched_slice = realstathz / SCHED_SLICE_DEFAULT_DIVISOR; sched_slice_min = sched_slice / SCHED_SLICE_MIN_DIVISOR; - hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / - realstathz); + sched_update_hogticks(); /* * tickincr is shifted out by 10 to avoid rounding errors due to @@ -3434,8 +3441,7 @@ sysctl_kern_quantum(SYSCTL_HANDLER_ARGS) return (EINVAL); sched_slice = imax(1, (new_val + period / 2) / period); sched_slice_min = imax(1, sched_slice / SCHED_SLICE_MIN_DIVISOR); - hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / - realstathz); + sched_update_hogticks(); return (0); } @@ -3452,8 +3458,7 @@ sysctl_kern_slice(SYSCTL_HANDLER_ARGS) return (EINVAL); sched_slice = new_val; sched_slice_min = imax(1, sched_slice / SCHED_SLICE_MIN_DIVISOR); - hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / - realstathz); + sched_update_hogticks(); return (0); }