From nobody Fri Oct 02 15:50:03 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hxCsS05WLz6vcBy for ; Fri, 02 Oct 2026 15:50:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hxCsR257Hz4hRM for ; Fri, 02 Oct 2026 15:50:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790956203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bOPBVVh67E4dsx8u9a/euwWXL3arm+D7+efqRfOUqjA=; b=OFrrz3pQ9EGFxcH+0ZuYj75zSvQyulqflC00woYTOGwNDzHJSQGsHHzhgj63ggvXFnLVhV qmstpUrt8KZTOkwvOIcARcX3XAfMi1HQMFhP76w7bAcOwtKGMiIetVReZl/O70ZAc1uP02 VqwdRurF3YySNLeL+YfZsrKFpYEBDai/F/ojb0pyui3CoS/uw5httlkZGJhOIIfvkDTBQe 9DviCL9NswwzUyKInuwDeYVviy8+Pl7G9AftoA/T/ij/t+aH3RCO2v4ViMu+lWhgZWFx/K T/bRD9uZTHwt+udbjnBtladj+yqHmNZKMBTqUEjfEKaK6P8gb4GN+Bzac6SRCA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790956203; b=fmZP8tAYhxKanwlIWx4dq1q/ilx6VKfzDDEdyutTnhoqBUZRQEjzu2VP+xYPCdC9YLA7ta E72syP6Wl6O/0uttKNikbEFCJfZ58qKzLALdqceZqda/AeMILeS9zCedBdHYIpeVUeL3Z3 c7fadpGDP7MG8Wqcc3ly9tLExPRfgqqYOOEp6qvsLNLFJCteXFAvN3aeDlaSPCkqXvh4gq O7cdRQKHUk1s6Y++qRdKx0zKooWCTFZIKp0jsY0/GL1wN+UcDukG+Ke7F/E5L7lLuuQbIP zIXrhs2fvk+S+b4rwTmKjlME4SWzpnEA0g1htMCg+rbkINw00XOguxKo9/p9Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790956203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bOPBVVh67E4dsx8u9a/euwWXL3arm+D7+efqRfOUqjA=; b=CuiijL0X1mG2jqKysqWDD7vLk6lqdn4Gp54tdai+P6OPEPwzkT59OqKkuEt54ExdgX0rwZ Kuqe0KZy1co9bug5P02AeJ0y+MRZgfIwhhkuQJUfv1Tv3ZJMAjDwpck1ufEd5IVI1uDpkG B6eq+IVz+Vn1mtIH3p2H6tMrbunLvlCkI/ThzwUWn4kLs/bPItmUIfrCXRPJXnV+9gObx6 rjhRCCCF7KK8GvjGdOV77sd69ujXejV2s2+KF2lMfbkOalaCdddHa9mAG4wamwjI4KjXhr q74HBmu9iHSRixHjfGAChuSvR4yseu7oiJahTCSBuFT88NaPCHx85TbHw8w0Rg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hxCsR19M3zNhG for ; Fri, 02 Oct 2026 15:50:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 41223 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 02 Oct 2026 15:50:03 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Minsoo Choo Subject: git: 8ad706ea6eef - stable/14 - sched_4bsd: fix vague comment List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mchoo X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 8ad706ea6eef230dee369a68de0b2ab562fab343 Auto-Submitted: auto-generated Date: Fri, 02 Oct 2026 15:50:03 +0000 Message-Id: <6abfd2ab.41223.48dddbef@gitrepo.freebsd.org> The branch stable/14 has been updated by mchoo: URL: https://cgit.FreeBSD.org/src/commit/?id=8ad706ea6eef230dee369a68de0b2ab562fab343 commit 8ad706ea6eef230dee369a68de0b2ab562fab343 Author: Minsoo Choo AuthorDate: 2026-08-24 02:25:37 +0000 Commit: Minsoo Choo CommitDate: 2026-10-02 15:44:54 +0000 sched_4bsd: fix vague comment The comment "was incremented in schedcpu()" doesn't give enough background for decrementing ts_slptime by 1 (thus ignoring decay_cpu() for 1 ts_slptime). More accurately, ts_slptime is decremented by 1 because decay_cpu() has already executed once in schedcpu() when ts_slptime was 1. Reviewed by: olce Approved by: olce (mentor) MFC after: 2 weeks Sponsored by: FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59406 (cherry picked from commit cd33abbce5a5c3b454f00ca3d0ecd71c2234106c) --- sys/kern/sched_4bsd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/kern/sched_4bsd.c b/sys/kern/sched_4bsd.c index 35685b06f7db..f66c73597b67 100644 --- a/sys/kern/sched_4bsd.c +++ b/sys/kern/sched_4bsd.c @@ -597,7 +597,8 @@ updatepri(struct thread *td) ts->ts_estcpu = 0; else { newcpu = ts->ts_estcpu; - ts->ts_slptime--; /* was incremented in schedcpu() */ + /* schedcpu() performs one decay_cpu() on its own. */ + ts->ts_slptime--; while (newcpu && --ts->ts_slptime) newcpu = decay_cpu(loadfac, newcpu); ts->ts_estcpu = newcpu;