From nobody Tue Nov 03 09:10:52 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jJjV46qhkz6yQgC for ; Tue, 03 Nov 2026 09:10:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jJjV41yshz4V89 for ; Tue, 03 Nov 2026 09:10:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793697052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kqGlpBjRQ8GvDvha1vDX0kAwiTjHIV5l0pryCU7dBzQ=; b=AoB0bmYCxD4FqpLlupDUZAt3i8TUaERDxR2diwnKNBuyqyFPQBmp7LcdFUvneeL7+fIEcd BQRHrbwjVy6X6GtD6grZ0z0KHR2IOHUlzsNHPm38HsKOkX0Ay91/Z3tWn1yVQovg30d4cE mlCtvYM/WdZy4ihf39r/vn3nJcb6K+I8oTavSyCvXGni0HEu11tG/2h0BHzeqGuCV6RSxv sGXbGT9xyGf9FxavFFcDTxkh7oF/SVk1WxflW0+9BVtROXXHIagKs2BD331gSgNkAWjJvc nmJ3870MzsuGCh86vNCPB3XXwy5lWzwRdrdsx/Ua78DRjW/NVwiHXB4e/2YRtA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793697052; b=myIEQ+A0UAj+e4yRogGmoDZc+BxcIPN4AWbi0LWS+CfpP1STMXFHLAkGxVO4v4TD5BQsme i8n0n+cCn59RF2hkiOEGv92w4egfReX5a2hcKAfWU1GgQuFOASVolVgIXdvuz7TyheN+UO HIgoCqX3F8dOkJ5LJnTxq10jpNuBxGUt0/GPkhTk9UsRf6PGMqJ57WwCuRJM3oekVGFaKo auqYG/Ezwtw4eH6AZwFWOlHWfoePTtKmIp66CEUD5xu1qLnwHEGls31X6rWkj5nqeRFH/1 OLynig6eHi+c1FcCVeXf9KvjmAbPKaPUhgFiUqsPGHjo126hsffQlW7vZd0+OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793697052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kqGlpBjRQ8GvDvha1vDX0kAwiTjHIV5l0pryCU7dBzQ=; b=S3Zlco5y0UFUMEQmwDoi7zXSk4LkcULey9WTl9mm70t4NBLY70Ox9seILp5nkToGJoifKY cQQ9L9xTh90d+wdb5jJaS+qn4a/uqADRHhULTLBYtGFlSW+uVEHEgCVA+K3mbvjWpo2HsH JR39Uq6u8ZNFYn0+aa9SUDMP02/FVVtcThVaE0KOtQ/LCKg5ZJsj18q9MtMUiZhXYU/WJf AGwCCBBEwluAJPJG3Mk4Qo8Sz/hJVgPPaFODtWgTGq5S9m+pA4nPc8sdKu3mt/e5zHAm5U s9y2bOF8Rf0eJ4N9t2h7jpLa7+EBf0ODXFzQvby/lXFT0aEbhSL/I4co1PJvJw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jJjV4138wz1PHn for ; Tue, 03 Nov 2026 09:10:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 46110 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 03 Nov 2026 09:10:52 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Christos Margiolis Subject: git: 06e5b0422f3a - stable/15 - sound tests: Check the return value of close(2) List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 06e5b0422f3abf525472f6eb69677d7a32f4748f Auto-Submitted: auto-generated Date: Tue, 03 Nov 2026 09:10:52 +0000 Message-Id: <6ae9a51c.46110.51b28d8e@gitrepo.freebsd.org> The branch stable/15 has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=06e5b0422f3abf525472f6eb69677d7a32f4748f commit 06e5b0422f3abf525472f6eb69677d7a32f4748f Author: Christos Margiolis AuthorDate: 2026-10-27 11:27:32 +0000 Commit: Christos Margiolis CommitDate: 2026-11-03 09:10:44 +0000 sound tests: Check the return value of close(2) While here, remove two munmap(2) calls on mappings the tests require to have failed, since they are practically dead. MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D60800 (cherry picked from commit eb36c35ccf83ea94d46a3bcb282c01ceeaeb3bab) --- tests/sys/sound/mmap.c | 8 ++------ tests/sys/sound/polling.c | 10 +++++----- tests/sys/sound/sndstat.c | 4 ++-- 3 files changed, 9 insertions(+), 13 deletions(-) diff --git a/tests/sys/sound/mmap.c b/tests/sys/sound/mmap.c index 95ed9a483274..e14405e1b4e5 100644 --- a/tests/sys/sound/mmap.c +++ b/tests/sys/sound/mmap.c @@ -40,9 +40,7 @@ ATF_TC_BODY(mmap_offset_overflow, tc) buf = mmap(NULL, len, PROT_READ | PROT_WRITE, MAP_SHARED, fd, off); ATF_REQUIRE_MSG(buf == MAP_FAILED, FMT_ERR("mmap")); - munmap(buf, len); - - close(fd); + ATF_REQUIRE(close(fd) == 0); } /* @@ -124,9 +122,7 @@ ATF_TC_BODY(mmap_reject_prot_exec, tc) fd, 0); ATF_REQUIRE_MSG(buf == MAP_FAILED, FMT_ERR("mmap")); - munmap(buf, len); - - close(fd); + ATF_REQUIRE(close(fd) == 0); } /* diff --git a/tests/sys/sound/polling.c b/tests/sys/sound/polling.c index b7a328d13d4c..0f18c96e087c 100644 --- a/tests/sys/sound/polling.c +++ b/tests/sys/sound/polling.c @@ -98,7 +98,7 @@ ATF_TC_BODY(poll_kqueue, tc) ATF_REQUIRE_MSG(read(fd, buf, sizeof(buf)) > 0, FMT_ERR("read")); EV_SET(&ev, fd, EVFILT_READ, EV_DELETE, 0, 0, 0); - close(kq); + ATF_REQUIRE(close(kq) == 0); kq = kqueue(); ATF_REQUIRE_MSG(kq >= 0, FMT_ERR("kqueue")); @@ -113,9 +113,9 @@ ATF_TC_BODY(poll_kqueue, tc) ATF_REQUIRE_MSG(write(fd, buf, sizeof(buf)) > 0, FMT_ERR("write")); EV_SET(&ev, fd, EVFILT_WRITE, EV_DELETE, 0, 0, 0); - close(kq); + ATF_REQUIRE(close(kq) == 0); - close(fd); + ATF_REQUIRE(close(fd) == 0); } ATF_TC(poll_poll); @@ -154,7 +154,7 @@ ATF_TC_BODY(poll_poll, tc) wr = true; } } - close(fd); + ATF_REQUIRE(close(fd) == 0); } ATF_TC(poll_select); @@ -192,7 +192,7 @@ ATF_TC_BODY(poll_select, tc) wr = true; } } - close(fd); + ATF_REQUIRE(close(fd) == 0); } ATF_TP_ADD_TCS(tp) diff --git a/tests/sys/sound/sndstat.c b/tests/sys/sound/sndstat.c index ed292b570429..c78859fa4519 100644 --- a/tests/sys/sound/sndstat.c +++ b/tests/sys/sound/sndstat.c @@ -204,7 +204,7 @@ ATF_TC_BODY(sndstat_nv, tc) free(arg.buf); nvlist_destroy(nvl); - close(fd); + ATF_REQUIRE(close(fd) == 0); } #define UDEV_PROVIDER "sndstat_udev" @@ -383,7 +383,7 @@ ATF_TC_BODY(sndstat_udev, tc) free(arg.buf); nvlist_destroy(nvl); - close(fd); + ATF_REQUIRE(close(fd) == 0); } ATF_TP_ADD_TCS(tp)