From nobody Sun Nov 01 22:08:38 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jHprQ2sTlz6y2dv for ; Sun, 01 Nov 2026 22:08:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jHprQ1g1hz4jmn for ; Sun, 01 Nov 2026 22:08:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793570918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=w4TOKJs9qhf1okftQBVat145Bvce7k4ULAOUXuicZwk=; b=B16F2l0BgEacJvffWFpuBKvHmotX+kKCpqzj4B1ypMedR0772Vok/R4LBXIyFFR4OSZlhR 0gvjNTl43MftLcBJU/WB/lqEMecPhaDN0FNkL1z/CHX69w9KtJ+9ZWeQTtLQ4eYa4ooRDl nenIPWtOyyAGyEsg1NKmsdee/N8bplAF+FnUWW2sQrYvPXMQ+eJkp02mOrSKJ35YGpbdtY 7u7R3gVCsbb3Ss8OINBfQ9x9hVfMkTTMPGS7snZFen7kj//EfhKGd17Cz72WKjCoI+uHzd kivKpxduEbk2zuuVzba2VNmO0FQAmXZF8KChNDfWSxLAX7wj30lsBs4eqi2Hxg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793570918; b=tldV8PSNLEU1oN85+k9u7zT8MrFaibguNHEkwQn9cobzAzQJA1szMDGR1VgsJadi7jv4Tc 3YPW1cFbIA3Yap4ls5D3aTKmBXY2HXTtDIRMvxSH96H7LreP5uMizpZSX3YcFOeWDvEVWj u/VUzwHOx5zbT8eYMfXRJzKiC2fKb6//Ng71zbGyUJ5jyL3PX1l0ujlB/uFxb3z7OSZkBT wvk0IbahuzWq2tsu/GnTs8jQlxoGlnjFp0XqCSBifIKbvcTYuUSFHh1H4VQhpRVeAil6cK BIZO7D+/61UTKCTczaGONWWRirTdBdQ5CqKgDcZpGHr2ECoeY1oiYhews5SgJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793570918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=w4TOKJs9qhf1okftQBVat145Bvce7k4ULAOUXuicZwk=; b=AxtlcTgwok5O5iHSGbbdQzbfX4YhSXnm13/rrYYNpkqopWIOFigsJUVGqkvFexcHeA8blZ cD1BlLFdfW0ULoHwbMakFRU0UxFjjS9wWVhcKxkaZkh6nya8NzjNn1d8hcn+a/0HU0B1av /pSCvpQdItq5ffhe253BnO09NRAFcvPkZBAQgCf6OWfJFBA1+NFx7VRzzgoS2/NfzvvbLo NwGFXpVXrVFFEIbt01DVOG6KCTO6DjydyOEX7QskV8c2Os/v0kYx8FpddC07Xy+BsyesWd v5BaC67sXvuDCF2xOZnxgdEqMLapFfHPG9SD+8gX/NvzRyDzNdenLA4j9R5Xdg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jHprQ1KJHzHV5 for ; Sun, 01 Nov 2026 22:08:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 41d24 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 01 Nov 2026 22:08:38 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: ShengYi Hung Subject: git: 28093296d9e4 - stable/15 - libthr: Do not rely on UB in counter List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: Commits to the stable branches of the FreeBSD src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: aokblast X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 28093296d9e4a5744abb9ee78a36ce68638be491 Auto-Submitted: auto-generated Date: Sun, 01 Nov 2026 22:08:38 +0000 Message-Id: <6ae7b866.41d24.46f163ad@gitrepo.freebsd.org> The branch stable/15 has been updated by aokblast: URL: https://cgit.FreeBSD.org/src/commit/?id=28093296d9e4a5744abb9ee78a36ce68638be491 commit 28093296d9e4a5744abb9ee78a36ce68638be491 Author: ShengYi Hung AuthorDate: 2026-10-07 01:41:55 +0000 Commit: ShengYi Hung CommitDate: 2026-11-01 22:07:51 +0000 libthr: Do not rely on UB in counter counter + 1 > 0 is a undefined behavior and nobody guarantee that it will be honestly perform by the compiler that counter + 1 will always be INT_MIN. We switch to INT_MAX check instead to provide a deterministic result. Reviewed by: kib MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D60426 (cherry picked from commit 1d21e67e720a08992e81d626cff9d76524a81f22) --- lib/libthr/thread/thr_mutex.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/libthr/thread/thr_mutex.c b/lib/libthr/thread/thr_mutex.c index 82da8ab1ccba..1787db825bf3 100644 --- a/lib/libthr/thread/thr_mutex.c +++ b/lib/libthr/thread/thr_mutex.c @@ -865,7 +865,7 @@ mutex_self_trylock(struct pthread_mutex *m) case PTHREAD_MUTEX_RECURSIVE: /* Increment the lock count: */ - if (m->m_count + 1 > 0) { + if (m->m_count < INT_MAX) { m->m_count++; ret = 0; } else @@ -934,7 +934,7 @@ mutex_self_lock(struct pthread_mutex *m, const struct timespec *abstime) case PTHREAD_MUTEX_RECURSIVE: /* Increment the lock count: */ - if (m->m_count + 1 > 0) { + if (m->m_count < INT_MAX) { m->m_count++; ret = 0; } else