git: d89987b786a8 - stable/15 - sound: Address some XXX comments regarding AC'97 IDs
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 31 Mar 2026 09:55:17 UTC
The branch stable/15 has been updated by christos:
URL: https://cgit.FreeBSD.org/src/commit/?id=d89987b786a81ecde0d8cf247bb0d571892bfb54
commit d89987b786a81ecde0d8cf247bb0d571892bfb54
Author: Christos Margiolis <christos@FreeBSD.org>
AuthorDate: 2026-03-24 10:32:31 +0000
Commit: Christos Margiolis <christos@FreeBSD.org>
CommitDate: 2026-03-31 09:54:44 +0000
sound: Address some XXX comments regarding AC'97 IDs
These seem harmless to address. Not sure why the original author did not
just assign the appropriate names if he knew they were wrong.
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D56044
(cherry picked from commit edad981e1e8673b6dd14656fe75b9f239fb777ce)
---
sys/dev/sound/pcm/ac97.c | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/sys/dev/sound/pcm/ac97.c b/sys/dev/sound/pcm/ac97.c
index 14ff2f6a62ab..85f1f7ccf4d0 100644
--- a/sys/dev/sound/pcm/ac97.c
+++ b/sys/dev/sound/pcm/ac97.c
@@ -125,12 +125,7 @@ static const struct ac97_vendorid ac97vendorid[] = {
{ 0x57454300, "Winbond" },
{ 0x574d4c00, "Wolfson" },
{ 0x594d4800, "Yamaha" },
- /*
- * XXX This is a fluke, really! The real vendor
- * should be SigmaTel, not this! This should be
- * removed someday!
- */
- { 0x01408300, "Creative" },
+ { 0x01408300, "SigmaTel" },
{ 0x00000000, NULL }
};
@@ -238,12 +233,7 @@ static struct ac97_codecid ac97codecid[] = {
{ 0x594d4800, 0x00, 0, "YMF743", 0 },
{ 0x594d4802, 0x00, 0, "YMF752", 0 },
{ 0x594d4803, 0x00, 0, "YMF753", 0 },
- /*
- * XXX This is a fluke, really! The real codec
- * should be STAC9704, not this! This should be
- * removed someday!
- */
- { 0x01408384, 0x00, 0, "EV1938", 0 },
+ { 0x01408384, 0x00, 0, "STAC9704", 0 },
{ 0, 0, 0, NULL, 0 }
};